Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Phil Edworthy <phil.edworthy@renesas.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Hoan Tran <hotran@apm.com>
CC:     Hoan Tran <hotran@apm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        "Rob Herring" <robh@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] gpio: dwapb: fix a signedness bug handling IRQs
Thread-Topic: [PATCH] gpio: dwapb: fix a signedness bug handling IRQs
Thread-Index: AQHT+KgSebWfkfOpxUa8G2sYwj0vlaRJ6yDw
Date:   Thu, 31 May 2018 14:48:33 +0000
Message-ID: <TY1PR01MB1769FA633588A28A55A54636F5630@TY1PR01MB1769.jpnprd01.prod.outlook.com>
References: <20180531062424.3pfqikwzxryi6teu@kili.mountain>
In-Reply-To: <20180531062424.3pfqikwzxryi6teu@kili.mountain>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: acc6398b-56c5-4863-c611-08d5c705951c
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2018 14:48:33.1529
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB0922
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,

On 31 May 2018 07:24 Dan Carpenter wrote:
> Smatch flags a couple bugs here:
>=20
> drivers/gpio/gpio-dwapb.c:447 dwapb_configure_irqs() warn: always true
> condition '(pp->irq[i] >=3D 0) =3D> (0-u32max >=3D 0)'
> drivers/gpio/gpio-dwapb.c:627 dwapb_gpio_get_pdata() warn: always true
> condition '(pp->irq[j] >=3D 0) =3D> (0-u32max >=3D 0)'
>=20
> The problem is that we're storing error codes in pp->irq[] so it needs to=
 be
> signed for the error handling to work correctly.
>=20
> Fixes: da069d5d2b81 ("gpio: dwapb: Rework support for 1 interrupt per por=
t
> A GPIO")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks for the patch, I had already noticed the mistake and sent a patch.

Thanks
Phil

> diff --git a/include/linux/platform_data/gpio-dwapb.h
> b/include/linux/platform_data/gpio-dwapb.h
> index 5a52d69c13f3..419cfacb4b42 100644
> --- a/include/linux/platform_data/gpio-dwapb.h
> +++ b/include/linux/platform_data/gpio-dwapb.h
> @@ -19,7 +19,7 @@ struct dwapb_port_property {
>  	unsigned int	idx;
>  	unsigned int	ngpio;
>  	unsigned int	gpio_base;
> -	unsigned int	irq[32];
> +	int		irq[32];
>  	bool		has_irq;
>  	bool		irq_shared;
>  };