Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp693235imm; Thu, 31 May 2018 07:49:50 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLZMkYllAoKj9vQTqKttJW9koUwEwZGm+1cPvwWPj0OOfDEA+Oer5USGc/bWErR9hggJe25 X-Received: by 2002:a63:9c3:: with SMTP id 186-v6mr5875446pgj.357.1527778190019; Thu, 31 May 2018 07:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527778189; cv=none; d=google.com; s=arc-20160816; b=Q0PbwpeB2TZrPSbK9iIFAANGHT229/P1bAaGyGjhIe7cpy9QY3ePoeRKhBifaT3qnp Dl4Zllo5Rc/D4lk5FSc4xZqOQugNbSaVEJlPGPwqk0ox446p7HiEfidKot0oODdEWCgE 5+49ythWGR6SOcu1M0C/1AqNfwlA+52mTuUBz1z4g9/upreTyatNa3kkKFj9IdeEbNPA q1UH62K1teB2UNqOj1Uzu/oJj41oyV1VgWMNH7asT6eCH9X6A9fuzbjp1k9O9y5DTZta xYD2EW7oyN7JpMHUII1rvqNuRjZukM3yh8dcWBUladdNzHgUWxvBeEVEdcDs2F+31hR6 xmPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=GNPB4Dsj1k3U6pw/GwFEUfoLL9/+a0SbSxZYDBneyPE=; b=cynQu45AYCMoCcFxLjUX9ZeWedSd4i+flY4UIcPPsx6NqJsqpFNP4lYV1uDBcwp3fm I+w3qVQmF4FilX5pt0SUxjN0K/c4stAznQmqfqi6dxVIxvda3YUOXymilkwBBJzpyALj 1baaeuwMwqs2fsDiC/BFxEO8bGWvK4RfkJoFOJ89gyiYEbxEfyizuJ5HAjb9BIUsAsil wGiiYG0DaBJ8XUxPisRaeiNPkqYuaJiGVfNw4Of761iwHr77niLkNE961c1cgJSOk8Ct lYxRq/xhFUCpyGqG8ujNs91EfsTTM/z7CN074TW8dEsSdyN8J3E1vrZvn/+PxKWrPnmc s20w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=zSpVkele; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z18-v6si37010314pfd.357.2018.05.31.07.49.36; Thu, 31 May 2018 07:49:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=zSpVkele; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755483AbeEaOtD (ORCPT + 99 others); Thu, 31 May 2018 10:49:03 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:53184 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755042AbeEaOtB (ORCPT ); Thu, 31 May 2018 10:49:01 -0400 Received: by mail-it0-f65.google.com with SMTP id m194-v6so6670890itg.2 for ; Thu, 31 May 2018 07:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GNPB4Dsj1k3U6pw/GwFEUfoLL9/+a0SbSxZYDBneyPE=; b=zSpVkeleSw2TXlBetrshLtRE28tEanjFnTDy6DEgQYzSnvDQHMn3Inq0GUtI4EP2t/ xEDCFTVwWDtTUoxRv4Rl9kylJTjAzAyXkztrZD2mcaraW4JFRkyKzDvJWOrz8GMKRYwf zIyZLXKNC+Ejuwbt4482LHFl7ofYFbEq7rOsRuCt+aFj/IiVbu5v+gvzg8tY6OJ+GsVu cQvndmf1KKCSLpwfJ9x66KJ7gg7butBJ+Ag4KgnIGus/vch/4JjClYm5ZMR0kKfwV7ie 7Y9SayC5QIfM9ygZFqit8RET0YPN/ozaWLW82L53gzZg3Fc8TV51VBgfKfuo5FX4EuG3 tw8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GNPB4Dsj1k3U6pw/GwFEUfoLL9/+a0SbSxZYDBneyPE=; b=jtlrqT2iMXwCJVp+i/zZOR7M1Hw+6HiCNaKtyR3aNdhQJIsjxRrcq85zYeruE5SPFD krCtUu2OdK49+L0z+hRyIN8I8D1LBPoez9rOfb6LEB4CW57QJoJ4VdPV9fapRfsp67qN +hFt6N1pdJuGojQ/W5K9HmsAYbV0uHGAIjhx1+p3OFRC993hflNR2hh3yfGznof9q1Jz CLIlcuO7gZuwjMX8hrZEevM5Hxh1FLANzA9/exbD3AAikl9YaNi84tRVvyGfzClAfTdq C2NpcbkoN3ZwA/4JsWgs1b31Q9X5f7ARSYdw4/fRz+Jfr361Ha0oY0ySkDRvib41kqnN Qs/Q== X-Gm-Message-State: APt69E25YuuV338sl4WKUL3RXtnc+nnlh2+J8/W2wqo3WfieoAQop2LW 7iUG08ekDvBmKtr3ZU9nP5sVwA== X-Received: by 2002:a24:8189:: with SMTP id q131-v6mr277246itd.100.1527778141310; Thu, 31 May 2018 07:49:01 -0700 (PDT) Received: from [192.168.1.168] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id m14-v6sm207539iti.36.2018.05.31.07.48.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 May 2018 07:48:59 -0700 (PDT) Subject: Re: [PATCH BUGFIX 0/3] three fixes for the function bfq_requests_merged To: Paolo Valente Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, filippo.muzzini@outlook.it References: <20180531132313.2986-1-paolo.valente@linaro.org> From: Jens Axboe Message-ID: Date: Thu, 31 May 2018 08:48:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180531132313.2986-1-paolo.valente@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/18 7:23 AM, Paolo Valente wrote: > Hi Jens, > this series fixes three bugs in bfq_requests_merged. In more detail: > > - two linked bugs, with the first (critical: wrong lock) hidden by the > second (less critical: wrong check that made the body of the > function not be executed at all) > - a rather minor bug: superflous code Patch #2 doesn't apply on for-4.18/block. I hand applied it, all 3 are queued up now. -- Jens Axboe