Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <f42f8c4aeceb9025bc63716ec43e3a07a36dca8d.camel@perches.com>
Subject: Re: [PATCH 1/2] printk: remove unused flag LOG_NOCONS
From:   Joe Perches <joe@perches.com>
To:     Petr Mladek <pmladek@suse.com>,
        Maninder Singh <maninder1.s@samsung.com>
Cc:     sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
        linux-kernel@vger.kernel.org, a.sahrawat@samsung.com,
        pankaj.m@samsung.com, v.narang@samsung.com
Date:   Thu, 31 May 2018 08:12:23 -0700
In-Reply-To: <20180531121633.acuffu2b66q24c5c@pathway.suse.cz>
References: <CGME20180531102133epcas5p2e8d47887c1708836c9b70964983093e2@epcas5p2.samsung.com>
         <20180531102133epcas5p2e8d47887c1708836c9b70964983093e2~zs4eTmEuv0380103801epcas5p2U@epcas5p2.samsung.com>
         <20180531121633.acuffu2b66q24c5c@pathway.suse.cz>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2018-05-31 at 14:16 +0200, Petr Mladek wrote:
> On Thu 2018-05-31 15:47:51, Maninder Singh wrote:
> > This patch removes unused flag LOG_NOCONS for printk.
> > usage of this flag is removed long back with below commit.
> 
> Make sense.
> 
> > "5c2992ee7fd8a29d04125dc0aa3522784c5fa5eb"
> > printk: remove console flushing special cases for
> >  partial buffered lines
[]
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
[]
> > @@ -349,10 +349,9 @@ enum con_msg_format_flags {
> >   */
> >  
> >  enum log_flags {
> > -	LOG_NOCONS	= 1,	/* already flushed, do not print to console */
> > -	LOG_NEWLINE	= 2,	/* text ended with a newline */
> > -	LOG_PREFIX	= 4,	/* text started with a prefix */
> > -	LOG_CONT	= 8,	/* text is a fragment of a continuation line */
> > +	LOG_NEWLINE	= 1,	/* text ended with a newline */
> > +	LOG_PREFIX	= 2,	/* text started with a prefix */
> > +	LOG_CONT	= 4,	/* text is a fragment of a continuation line */
> >  };
> 
> Please, do not renumber the bits if there is no real need for it.
> The format of the log buffer is read also by external tool like
> "crash". It seems that "crash" ignores these flags but...

Hmm, if it's not an internal interface, then these
definitions should probably be removed from this file
and exposed in a uapi file.