Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp805807imm; Thu, 31 May 2018 09:41:11 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJK6ep9ZypCN7eFgKE/W+703i3Mw3DQqH0CQrjhKUTOibMAhqTqLt8L71hMLP4xD+wBnXAK X-Received: by 2002:a62:f20d:: with SMTP id m13-v6mr7564137pfh.170.1527784871632; Thu, 31 May 2018 09:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527784871; cv=none; d=google.com; s=arc-20160816; b=LOWlb3X2TKdEodnrHwDv7jqkACxGLQ4n4d6RakazDRdi+j5SfhUxluh0xhAujwX6EM 0hgrBBQ1VqM7xVm14bjn6FtId3ABJAEsR5tyjHVk4YZTGyw5yQFs+Q1f4wWfEVqTLxrE I4zFhwcEZeb6eX0SrNoz1hiLU/OsN7L3su/5/DVpkEw7E+12SYWqfTCI3hB8iMzTFGd6 KwXKtaWkyPb6zPlVImAtXmciQtYeL6Mv7joc13kFy21PPUQeqnjAccOO7pvV6+8Aj7aa cEcVJq17nYgwtEFAN0sK6cBTuKE8fvNIWlzpA3aipR3ZOS+W8RM6ejd5YOUN94W3wAUb /RKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=+tbD/pAt0o8ggKVdTCfZgaQy6hKPYSZi/wUD1E+Nx1s=; b=XE//wiYECcBOFPOep7UiCNxRQdIOUR/sD8WEYv0XG0lbYKHptr/pAdZKQeT0FIhduV /AC3YV1ZtTcDb9co1OFCeE64ks2yXuP9B8sDf0uL/55fV3CT/AkGW3m/bgR+BTMourLJ 3CmJcu5x1laMIQuWFQuHVrfBW3hEUXpqnx0bV0s/NuAQEyMPqlxZKWpKW6dxTAjdZ43O LdT0z8qTMuihjXws4RgtvHK41GFhatdV1u5WZE/AxEei4KZPcCziYsxxA6wXdQdfzHjf 4oc0fwBkr8xRM4wBwnd/fIiwcWTh7PHwNsTyJnSVXnoHU9QPnKtJPtUNstXQK4CiH1eR gtBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si24631679plj.216.2018.05.31.09.40.56; Thu, 31 May 2018 09:41:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755801AbeEaQj2 (ORCPT + 99 others); Thu, 31 May 2018 12:39:28 -0400 Received: from muru.com ([72.249.23.125]:45562 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755690AbeEaQjZ (ORCPT ); Thu, 31 May 2018 12:39:25 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6A7C9809F; Thu, 31 May 2018 16:41:47 +0000 (UTC) Date: Thu, 31 May 2018 09:39:21 -0700 From: Tony Lindgren To: Faiz Abbas Cc: Tero Kristo , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, paul@pwsan.com Subject: Re: [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Message-ID: <20180531163921.GO5705@atomide.com> References: <20180530141133.3711-1-faiz_abbas@ti.com> <20180530141133.3711-2-faiz_abbas@ti.com> <20180530145047.GC5705@atomide.com> <20180530152825.GG5705@atomide.com> <20180530155448.GH5705@atomide.com> <98c989ca-0694-5150-f74b-35f3e4bf20c0@ti.com> <20180531152623.GN5705@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Faiz Abbas [180531 16:36]: > Hi, > > On Thursday 31 May 2018 08:56 PM, Tony Lindgren wrote: > > * Tero Kristo [180531 06:18]: > >> On 30/05/18 18:54, Tony Lindgren wrote: > >>> * Tero Kristo [180530 15:44]: > >>>> On 30/05/18 18:28, Tony Lindgren wrote: > >>>>> * Tero Kristo [180530 15:18]: > >>>>>> For the OCP if part, I think that is still needed until we switch over to > >>>>>> full sysc driver. clkctrl_offs you probably also need because that is used > >>>>>> for mapping the omap_hwmod against a specific clkctrl clock. Those can be > >>>>>> only removed once we are done with hwmod (or figure out some other way to > >>>>>> assign the clkctrl clock to a hwmod.) > >>>>> > >>>>> Hmm might be worth testing. I thought your commit 70f05be32133 > >>>>> ("ARM: OMAP2+: hwmod: populate clkctrl clocks for hwmods if available") > >>>>> already parses the clkctrl from dts? > >>>> > >>>> It maps the clkctrl clock to be used by hwmod, if those are available. We > >>>> didn't add any specific clock entries to DT for mapping the actual clkctrl > >>>> clock without the hwmod_data hints yet though, as that was deemed temporary > >>>> solution only due to transition to interconnect driver. I.e., you would need > >>>> something like this in DT for every device node: > >>>> > >>>> &uart3 { > >>>> clocks = ; > >>>> clock-names = "clkctrl"; > >>>> }; > >>>> > >>>> ... which is currently not present. > >>> > >>> Hmm is that not the "fck" clkctrl clock we have already in > >>> the dts files for the interconnect target modules? > >> > >> Oh okay, yeah, we could parse that one, but currently it is not done, and is > >> not present for everything either I believe. > >> > >>> We can also use pdata callbacks to pass the clock node if > >>> needed. But I guess I don't quite still understand what we > >>> are missing :) > >> > >> So, what is missing is the glue logic only from the hwmod codebase. Right > >> now this is not supported but should be relatively trivial thing to add if > >> we really want to do this. > > > > OK let's think about this a bit for v4.19 then. > > > > I am not sure what the conclusion is. Should I try removing the > clkctrl_offsets, clkdm_name, and main_clk? No need to, it's not going to work currently without them. Regards, Tony