Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp819246imm; Thu, 31 May 2018 09:55:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIWkfb00kkDO0v67WeAslFKEFU4QYlPQkuWlGJ9bgAxlSotMlB38TTMw/1GD378XIKDy2rR X-Received: by 2002:a62:c809:: with SMTP id z9-v6mr7425190pff.5.1527785748340; Thu, 31 May 2018 09:55:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527785748; cv=none; d=google.com; s=arc-20160816; b=B851AkNYWkDW+M1DxShE7lrQm8lLd83h/NyuGRtFLe4Gygt1/ItG74JCigbif+VZO1 hW65zf80tAA3VFiun0iXxz6lYPD8JssVyvFaQUYX5Ulp6d/7Z//srFWGdPtoik0oub5k Fkf0jHBER5nf4IsYr0OuKrIHRidGNCWGSBlRGxT+hrWPLZAmgzbhuY2xoAvgPmn+cwyz otYAHfVyqAjMMBmUOoi33qH/QrLRZDAUEvuvh8V7nmLpccLG+HMV5FUroKOgQKioEn8X WUi1LFHnIhVsvCkpYo+R76+XR24vNGSqQEDqshcsLCvHsaRwYaRRUQGqfByc0qHsWAeJ l04Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=psrGnuvxf1h2vXyxQpNS7aaVmQEjTae6UFTGcY5Cduc=; b=lNQv9c0AeqO8f/H/PeSHHmFyEUOnUuMVkgqM0zgHw16yr1CEJo1FF86J/XUYhBcY5k qFtX3+jNJT0w+hmPj4KG9OxVQooZDskQcmQLj4Z/N6bXOSOUspTmHohuAKjPKDRBElv6 cfPRp7WV52g8XuUCXVfVMTjNQtCwO6GT/t0YeBYtIM0w0DyF0ZNodXD1RV5bd7bB6Dq/ yitavMlLFd1ckqqjdjbrf9+eP9IL3/bgfWpIMLd18NnjIMH9NO/B4dTpn9YiwtQPO8tQ /YMU2vieJzt+uPyIzvagUCnQwXgrdmK4uYf+zpN/d9ukhJZSTEytzsZaBzyxURJm4yas RQ1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zmCIxJGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1-v6si37998531plb.204.2018.05.31.09.55.33; Thu, 31 May 2018 09:55:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zmCIxJGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755776AbeEaQy4 (ORCPT + 99 others); Thu, 31 May 2018 12:54:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:37674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755728AbeEaQyw (ORCPT ); Thu, 31 May 2018 12:54:52 -0400 Received: from localhost (li1825-44.members.linode.com [172.104.248.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64054208A6; Thu, 31 May 2018 16:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527785692; bh=qFluqUP4FH8HpkkcQzj+2LYDHX9ciw1e6JflU3K00d4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zmCIxJGiBwtdOB9OW3LPU+JRVnPf0sgnPz8WDHHl3k/jCXBKg5uMeHB33MLJoarDt FKoFW7ApILpsWUjyTVyd8+oktU0YGj8QxxtXzeClx3Lt8oE4kV5ErGpKgbBnMdxixS LRwHAZb3kgrM34cjiyB5MvE9xZCodytfAhRG6i0o= Date: Thu, 31 May 2018 18:54:26 +0200 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , NeilBrown , "John L. Hammond" , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v2 6/6] staging: lustre: mdc: use large xattr buffers for old servers Message-ID: <20180531165426.GA23414@kroah.com> References: <1527603705-30450-1-git-send-email-jsimmons@infradead.org> <1527603705-30450-7-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527603705-30450-7-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 10:21:45AM -0400, James Simmons wrote: > From: "John L. Hammond" > > Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR > with OBD_MD_FLXATTRLS) RPC for an orphan or dead object. So for > clients connected to these older MDTs, try to avoid sending listxattr > RPCs by making the bulk getxattr (MDS_GETXATTR with OBD_MD_FLXATTRALL) > more likely to succeed and thereby reducing the chances of falling > back to listxattr. > > Signed-off-by: John L. Hammond > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10912 > Reviewed-on: https://review.whamcloud.com/31990 > Reviewed-by: Andreas Dilger > Reviewed-by: Fan Yong > Reviewed-by: Oleg Drokin > Signed-off-by: James Simmons > --- > Changelog: > > v1) Initial patch > v2) Rebased patch. No changes > > drivers/staging/lustre/lustre/mdc/mdc_locks.c | 31 +++++++++++++++++++++------ > 1 file changed, 24 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre/lustre/mdc/mdc_locks.c > index a8aa0fa..b991c6f 100644 > --- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c > +++ b/drivers/staging/lustre/lustre/mdc/mdc_locks.c > @@ -326,8 +326,10 @@ static void mdc_realloc_openmsg(struct ptlrpc_request *req, > { > struct ptlrpc_request *req; > struct ldlm_intent *lit; > + u32 min_buf_size = 0; > int rc, count = 0; > LIST_HEAD(cancels); > + u32 buf_size = 0; > > req = ptlrpc_request_alloc(class_exp2cliimp(exp), > &RQF_LDLM_INTENT_GETXATTR); > @@ -344,18 +346,33 @@ static void mdc_realloc_openmsg(struct ptlrpc_request *req, > lit = req_capsule_client_get(&req->rq_pill, &RMF_LDLM_INTENT); > lit->opc = IT_GETXATTR; > > +#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(3, 0, 53, 0) Why are you adding pointless version checks to mainline? Please don't add new ones of these, you need to be working on removing the existing ones. thanks, greg k-h