Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 31 May 2018 13:23:44 -0400 (EDT)
Message-Id: <20180531.132344.339904863786377155.davem@davemloft.net>
To:     laoar.shao@gmail.com
Cc:     edumazet@google.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: minor optimization around tcp_hdr()
 usage in receive path
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1527607651-28262-1-git-send-email-laoar.shao@gmail.com>
References: <1527607651-28262-1-git-send-email-laoar.shao@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Yafang Shao <laoar.shao@gmail.com>
Date: Tue, 29 May 2018 23:27:31 +0800

> This is additional to the
> commit ea1627c20c34 ("tcp: minor optimizations around tcp_hdr() usage").
> At this point, skb->data is same with tcp_hdr() as tcp header has not
> been pulled yet. So use the less expensive one to get the tcp header.
> 
> Remove the third parameter of tcp_rcv_established() and put it into
> the function body.
> 
> Furthermore, the local variables are listed as a reverse christmas tree :)
> 
> Cc: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

Applied, thanks.