Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp928981imm; Thu, 31 May 2018 11:57:12 -0700 (PDT) X-Google-Smtp-Source: ADUXVKInUme4W8II9BtYk/KNRbfBhChp5m/9a3M2ThGwqGFPuhv1zs7BccEmlE2dhDmZ9wSDkp9c X-Received: by 2002:a62:8910:: with SMTP id v16-v6mr7760697pfd.13.1527793032247; Thu, 31 May 2018 11:57:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527793032; cv=none; d=google.com; s=arc-20160816; b=dRPG8Kn7ec4dC9FGsf0iZK9uW15z3aicrYoFA2WYPSuv6k6v3suRGyDm3HHa2xAIwC eAGOD6Jg6uG1zmAcLQCAGI+fVt2EeJetjAVDG5AkWU8rycN+iisG8TQPJFQjDMrSwL4W nkPYOTtbjzzv/A2OJIcQfBitdSfcmLvh9BcJSm5J1zclfbRl+MlnCpPKnAk3GgQxnnJ+ r6bgpo1LfyQ96IaEmnLgLqL4uZWWJs/n4EVumffvwlWFuT1p62apoRyubRNGSFR7j5G3 Y6cLVZ2J9Rxu9umB0rd7mozTz+V8iT25ywKKj4NZ0ce7z1lYQwPPh6CglvEuRRudDG+L XXWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=owLQ+NP/vQi1b6a4xlUr9il+vO1F83/DIskWy+Vt+tU=; b=HBhreJGVyLx/hjM8vCL0iqgKY6yqdDtaDvLXGnfs4M4WXHGgV6J4c8iVL+sgtyWpST gltcHE2fQzAYI5/r9XtBbGZS5WvkyZfZv8FqvdDKdqTNcVtTX16+h6hNtucXMTWJMYRB 0SSW37sP73UIYQHtcPyoN7g9aQBBMbZZm8P8Rrpqy5CROq9/g3fi7DRnb06KZXb9sZaR Pt0u3Ziq43YXiVIFzZMWZnDCwNzdeRmO+fGcKBWFIH6xJH1/vxJux6Vv1PeDs5IUQ5y8 1oABCyP+3j2uPFShvv8sbxzt5ekE+WNiBaZ/CM9ePExKDbHCDDbvzFluCEC3PHQRvNVw PXFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hwrMrnWn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3-v6si37317286pld.96.2018.05.31.11.56.57; Thu, 31 May 2018 11:57:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hwrMrnWn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756072AbeEaS4C (ORCPT + 99 others); Thu, 31 May 2018 14:56:02 -0400 Received: from mail-qt0-f177.google.com ([209.85.216.177]:46172 "EHLO mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755955AbeEaSz6 (ORCPT ); Thu, 31 May 2018 14:55:58 -0400 Received: by mail-qt0-f177.google.com with SMTP id h5-v6so21123450qtm.13; Thu, 31 May 2018 11:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=owLQ+NP/vQi1b6a4xlUr9il+vO1F83/DIskWy+Vt+tU=; b=hwrMrnWntZITfuZyR+pexRSpvqzsWVwWh1V4XLrLIaW16x5wh2hHWtzX9wOG8dRkBc ndsRxkFntAk52elwH/vatKg5y0OZJkB4iKqPN9GZB2Qk9ISQ48X1cTY0jUd7w+J8t8S5 2l6tijsZCQY1MUxA/gEz5Tm4qvby9UGa7+dOJj+VMvBA9Xjv6/iNDd5OSusiF9Zf7KnQ ZRsJ2XL9OGvwfN4rtHOQhMgrhZJ43hrMgMX/eGa8Q0WHEcoUB7bexutWtPcxoLvQOC6s CyMsSFAZXhS/AejX3Lh3n7cBCQaFgOExdVugv/WrXhJBI1tH980pV94v0OlEK7BkPuUM Lbzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=owLQ+NP/vQi1b6a4xlUr9il+vO1F83/DIskWy+Vt+tU=; b=evC+Z2rHXPubvXw1EFYLHHdgXLQprNwnj9rt7rZ3VbbQa6jNn5YdNI+wZ0leMfWyW2 Y1cr4RdQHa5OLUyBb9aOjUljrvpR43p9mnh9HDLZOrlccvQ0fFJxDorEtl1gwEGMXVv6 vwSUl+TzrDj+CHPkHijr0Rpvx5aK/flS+TNk471Mm92wnitkiK9/7J7pd0nruiYMRREq xpIDlm8vuSI4mzz6ektamSpH4KARGvJcqy8fKHUJU62YkrwmxvvVAgKOBoaQ12/FVJxU qtGs/MywYenifc7O/QhPW+jRRPkHgFfo4oxXO9xxE3Dt3LR2qAfu27r2pD1OBQMNt/fM GqOw== X-Gm-Message-State: APt69E2tKKDrjmyJexpGiu/LT2zpCjeO5+CnLc7dSEhbmsVidoUkUdpK /xAJhllPAkJbVEnd1GoEtcL11g0HUUMPU/+7R4k= X-Received: by 2002:a0c:b2ca:: with SMTP id d10-v6mr2754281qvf.16.1527792957347; Thu, 31 May 2018 11:55:57 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a0c:9896:0:0:0:0:0 with HTTP; Thu, 31 May 2018 11:55:56 -0700 (PDT) In-Reply-To: <20180531072732.GA90146@google.com> References: <20180530163135.50081-1-liumartin@google.com> <20180531063118.GA7554@kroah.com> <20180531072732.GA90146@google.com> From: Andy Shevchenko Date: Thu, 31 May 2018 21:55:56 +0300 Message-ID: Subject: Re: [PATCH v4] driver core: hold dev's parent lock when needed To: Martin Liu Cc: Greg KH , Alan Stern , "Krogerus, Heikki" , Johan Hovold , Linux Kernel Mailing List , USB , jenhaochen@google.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 31, 2018 at 10:27 AM, Martin Liu wrote: > On Thu, May 31, 2018 at 08:31:18AM +0200, Greg KH wrote: >> On Wed, May 30, 2018 at 01:21:02PM -0400, Alan Stern wrote: >> > On Thu, 31 May 2018, Martin Liu wrote: >> > This looks okay to me. >> > >> > Acked-by: Alan Stern >> > >> > Greg, any more comments? >> >> Looks sane to me. Martin, thanks for all of the changes. > Great thank Alan, Greg and Andy for helpful hints and feedback. > Many Thanks! You are welcome! Btw, FWIW, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko