Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 31 May 2018 20:59:33 +0200
Message-ID: <s5hmuwf648a.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc:     "Yisheng Xie" <xieyisheng1@huawei.com>,
        "ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
        "Clemens Ladisch" <clemens@ladisch.de>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 15/21] ALSA: oxygen: use match_string() helper
In-Reply-To: <CAHp75VeNgTVT_O_ytF2C_iavkDLz5uxQggxboWpB9f1fgjkYdQ@mail.gmail.com>
References: <1527765086-19873-1-git-send-email-xieyisheng1@huawei.com>
        <1527765086-19873-16-git-send-email-xieyisheng1@huawei.com>
        <CAHp75VeNgTVT_O_ytF2C_iavkDLz5uxQggxboWpB9f1fgjkYdQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 31 May 2018 20:41:36 +0200,
Andy Shevchenko wrote:
> 
> On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
> > match_string() returns the index of an array for a matching string,
> > which can be used instead of open coded variant.
> 
> Sorry, didn't notice before one thing:
> 
> > +               j = match_string(known_ctl_names, CONTROL_COUNT, ctl->id.name);
> > +               if (j >= 0) {
> > +                       chip->controls[j] = ctl;
> > +                       ctl->private_free = oxygen_any_ctl_free;
> > +               }
> 
> It looks to me you may get rid of j completely by utilizing existing err.

Well, err isn't ideal as it's referred as the actual index.
That is, the line below looks weird to me:
	chip->controls[err] = ctl;

Of course, j isn't the best name, either, but at least, keeping the
same variable makes the code conversion logic clearer.


thanks,

Takashi