Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp986625imm; Thu, 31 May 2018 13:01:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIxt3E8a72Rqn5BI/dY6Djbbn82t2M4zf92uf/GLGDHflXkqxRDG3A9zTZyjo0aqX7t+Zlf X-Received: by 2002:a62:67c5:: with SMTP id t66-v6mr3850058pfj.20.1527796879193; Thu, 31 May 2018 13:01:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527796879; cv=none; d=google.com; s=arc-20160816; b=gyB4Jx1k9KEnssLjI3vdqoPFLKRvSckFXjbZRoecsvImUn5KfNp7jAO0hVjT1wyjpn VomusArQREPidtlSHy5eoXu1pTRSodRwDEmNOuz+vPikkB5lIYqCkVVCM/V9gMqUX1Oo N/0LzA1kvdoNY81rI+TOdHqbJO39TruXCmkJLW7x7XnS1FaB7+HStAysQYQxHZQuPhQq A0MI7HvAL93fHsGGXlJVy5eyJ8xnhn4CAvJngvlcnPpXrfKJHjwqVuZVq6mrWL1pyFha kY00uxMlxo2vf5A/8zbOpxN3akRCXSJolzsceLhPS+gtOskLOGWA1hvC2vucW3kkGUZm Jfmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=T6ZdPRIKgx6rUBu3LoqgeWZZU1qEZ17Fx+TbIIUZm1g=; b=WbfxqQrFx2ruoSRV7+q+vN6ueRKClvV851AFCPFflTo8HPspSBUWwwe0zZFzhoJkeO TIKI27r6eqb2Uyb/L6DqFoDLQhg0Bf8lYnkPeAM+ZXT4mpqDXJWCIM4X/0BOJAb6Uuqa nvU3AqDGzHItUK0eJnFTEBkOWUKr+VZJqWrcgB4eNH0EQxDMngSNm+S5nrdP79slJsf8 p7CgPDp0AzzuQiwqLD0mej4+b55OvEeeyyrvc7o8XOlXhxiW5ZrYbwtJCc9Fvns3BEcA lVlhuV1it+FXvaqMWWWe8Q7kCkDK0RxdUrz/7OWz8q1p6zCQy8wsAE3h5wD9qYfY3NPg k6uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u4-v6si15778229plj.43.2018.05.31.13.01.03; Thu, 31 May 2018 13:01:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754234AbeEaT7g (ORCPT + 99 others); Thu, 31 May 2018 15:59:36 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34052 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753983AbeEaT7b (ORCPT ); Thu, 31 May 2018 15:59:31 -0400 Received: from localhost (unknown [144.121.20.163]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 124AE10182065; Thu, 31 May 2018 12:59:30 -0700 (PDT) Date: Thu, 31 May 2018 15:59:30 -0400 (EDT) Message-Id: <20180531.155930.1197591227145779002.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH net] net/ncsi: Fix array size in dumpit handler From: David Miller In-Reply-To: <20180531041004.20172-1-sam@mendozajonas.com> References: <20180531041004.20172-1-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 31 May 2018 12:59:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Mendoza-Jonas Date: Thu, 31 May 2018 14:10:04 +1000 > With CONFIG_CC_STACKPROTECTOR enabled the kernel panics as below when > parsing a NCSI_CMD_PKG_INFO command: ... > This turns out to be because the attrs array in ncsi_pkg_info_all_nl() > is initialised to a length of NCSI_ATTR_MAX which is the maximum > attribute number, not the number of attributes. > > Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family") > Signed-off-by: Samuel Mendoza-Jonas Applied, thanks.