Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1001583imm; Thu, 31 May 2018 13:17:46 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKlmJqvLCiVVii850Siqt4iJ0HrkZUaiX8aRyRaIJPEowdbxvPAM9DiRId2GwzDMmlwYYlF X-Received: by 2002:a17:902:7782:: with SMTP id o2-v6mr8495309pll.247.1527797866184; Thu, 31 May 2018 13:17:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527797866; cv=none; d=google.com; s=arc-20160816; b=RPP84VVsiNNFqi+MSp7jXLblOH9TKxzTSE5DE+8taLVLG0/2sASaToLtVhDPqgU1zH aW9NydLtVvtXM4jOiFA97doloswnEY1hQsbrv9kfuzvi10Adtytrc7a380sr9tdQCbnq Z3Jb13VDYNzvom6o+lArLIe/S6xksc6uY0tl/EAvRgmYwwBi7igL3+2U0HstwtKn5ko9 1zWDVWBJJhdV0Bs4ic5Ha6xdjTulsbJo/At1cCu+VOBf3ua/ADfvbNZwLsQOUxzBYLSY NdxvqlzPSYFSFfq5JXjp2fus05dbYpLeWZF9TUcrqXI0qHF5jMTpB/BveLRQgRq8N+A8 /MTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=WWp1f2OtwMC6tuyQu4Fa2ZvbUZTeMeck/JIZFQJlKSE=; b=YOhTeG0aDr/xK0yiWGB86m2rg6ijes2dMHd13lpXAOkJc1CMswj4hhxNUlOSDVSw5D V+kdEIVW5JP1n/6MZIRi2FnLZFGGR2IgtOakxhL7X2EGwBIbKpnkOMCUWpFfeGEl7UZD hR1HrTXl7bjjRQJthGDPPOMUQCOzNfD3nftQcv15kDJE1Jmc/zVAQPvS25SyLU5Z5wMn mZhWOPIDukJU8jgGKVo/f9RAuN3AG9Fswz5kpPmLD9FkN9QDPZorwwmLk0vw1Wp79vvE eOQS/zxddpwqvgzl/LKDf2Day1yqYHBtIE9MwDiW9bSLX9feo2EKvUwPAECJPx+Sopbe Mr/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGm57gkj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b78-v6si37449994pfj.2.2018.05.31.13.17.31; Thu, 31 May 2018 13:17:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGm57gkj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281AbeEaURG (ORCPT + 99 others); Thu, 31 May 2018 16:17:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:47014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754071AbeEaURE (ORCPT ); Thu, 31 May 2018 16:17:04 -0400 Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40D8D208B4 for ; Thu, 31 May 2018 20:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527797824; bh=WWp1f2OtwMC6tuyQu4Fa2ZvbUZTeMeck/JIZFQJlKSE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vGm57gkjstXvaGm3bMeL9BqHEk3Rm+Lhpndb9GFLnRjfHK6ypY687yh71PbpnQBTx EQgEDPq8pb0KpWEoHgS8KjzUAP7MgHxFvrMEd+jG6ASqYqhjubmtELf+Y96akMV3w6 occFY2mav/4BBudGkT1HP9TgZ5plsQwTTCI8fyMU= Received: by mail-wr0-f171.google.com with SMTP id l41-v6so34225520wre.7 for ; Thu, 31 May 2018 13:17:04 -0700 (PDT) X-Gm-Message-State: ALKqPwd7v1hiNl3p0RTRuSFanLY4ipmihBw+/ZG3Xc26G3hKzW4/0Gpa M+eyO/bchpHT/arKEsiUL/5t1tzoQ1FhG00HV5ogqA== X-Received: by 2002:adf:b456:: with SMTP id v22-v6mr6246871wrd.67.1527797822785; Thu, 31 May 2018 13:17:02 -0700 (PDT) MIME-Version: 1.0 References: <1527789525-8857-1-git-send-email-chang.seok.bae@intel.com> <1527789525-8857-5-git-send-email-chang.seok.bae@intel.com> In-Reply-To: <1527789525-8857-5-git-send-email-chang.seok.bae@intel.com> From: Andy Lutomirski Date: Thu, 31 May 2018 13:16:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 04/15] x86/fsgsbase/64: Factor out load FS/GS segments from __switch_to To: "Bae, Chang Seok" Cc: Andrew Lutomirski , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Andi Kleen , Dave Hansen , "Metzger, Markus T" , "Ravi V. Shankar" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 31, 2018 at 10:58 AM Chang S. Bae wrote: > > Instead of open code, load_fsgs() will cleanup __switch_to > and symmetric with FS/GS segment save. When FSGSBASE > enabled, X86_FEATURE_FSGSBASE check will be incorporated. Reviewed-by: Andy Lutomirski