Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1150472imm; Thu, 31 May 2018 16:42:23 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIx+qeHM11RkBokXVSO+thS9D3GzcW5xU9QZOkmuL1Qq4WwVKUCpF8IJnKIwdzsrUWEYBLP X-Received: by 2002:a17:902:1e3:: with SMTP id b90-v6mr8574371plb.273.1527810143791; Thu, 31 May 2018 16:42:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527810143; cv=none; d=google.com; s=arc-20160816; b=KGO/tPp6WdZcxZTk54cY4oJzWMvJY1DYXpWw2AnwY/bNnjgLs7Yt2OVtoLpKQJfHfy DiID4wSPf4RRrEz68whyen3nEBVCoEnNo58qfxILRMzsNBGOjfIMLmqJOnxcfZyoyeEy XdkqySicD48og+vfw2I/JIhAfCphTBbITKjnJe9Z9mJlq4kvm6ktAWSbuSkT+TBDKILg +tH24RM36HlCPaLppOlCMlJtOK5Zqxi4RknR1jY+CjWogHu0sxgavw9ckd4XGJa5xrX2 b2cKMDbr8xCcSsRvmqGilA655l//zTH7hBEHc4pHpS3qw+ULYzaETzM8Pqm1aLAgkS2C s4/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=dLVdlPKQCO9j+D2ALY1KLpHn92iWn8oxoGeq+ncb+RU=; b=bGQArzm+baIDaVX4dGkPB/OyQTbbHFUWzYfijn7zznwB8ABLdHiWXhQ8ItPxU6hfxF PwrIU/jPuMWm1ioz5KDFzXSB6QO5avTRvZaKYbts7rncTyb7uCEbeCku9QIiNr1NN5/e S17hpvwBMZSPBKM1y4fNIS+L2M1y80HQoYKG5PXhwVAtzpSdijOATbAnsCP655EKnYvu 2m8/hFAxO+OR3o3pSyzAWcD/CIon5lzGUb/SzDog8jkPHCyi70CTE4hK4H7BHxuo56lF 1oxPENWKnqkEne77GBUQFBZDdGe0R/Fzh16HWFbf6SDlm8q3dduScQbvmFEGpx6L+EuU q/tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BePPr7rH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a33-v6si38264301pld.167.2018.05.31.16.41.32; Thu, 31 May 2018 16:42:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BePPr7rH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750795AbeEaXhT (ORCPT + 99 others); Thu, 31 May 2018 19:37:19 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:39171 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbeEaXhS (ORCPT ); Thu, 31 May 2018 19:37:18 -0400 Received: by mail-pf0-f195.google.com with SMTP id r11-v6so3986989pfl.6 for ; Thu, 31 May 2018 16:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=dLVdlPKQCO9j+D2ALY1KLpHn92iWn8oxoGeq+ncb+RU=; b=BePPr7rHnXe+LfA7qjQ/pjF+O7XHxeQlhl9Hf3wgwa5HPtKIrWnM1+gUmYJ6dPkdfF 40svgzEt7nMDMWhXQsuZToSmxvsFD/+5O5ro5yB6ZQUnsK/S0ZsMLBPeP2liRlXHOfIn X4YJZ8a/L3uNusKSTBCeTdef3g43AnMRRr+6C3aAh4U+PWC0a2t2FSneKeV4OasFj9qB KKaGx4bzVEhEfeJ/mmcbuhYFOHNPbI96jpQgS+JtgVgqugpsGROb2qDNm6o3hSvq2aYq EGvUi8Oxpm/EmsGA2GqDSkk6HRXFnKntD74ca0SKoRbL5AcGHE8pMu6D7nfmOHKpTZe3 A6Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=dLVdlPKQCO9j+D2ALY1KLpHn92iWn8oxoGeq+ncb+RU=; b=bx4gm+yKDETd0Mw/UGVW0LRxElkTkyPDHKkMyfLNJuj1iqKZoALTw5o/uC0nlqPLU9 2qUSHDrGboLoRSRLL/uC2muuLFhaqtgMiSvzAm/YaWrI2poiDmfmxpjKdF7S1cqIUa8J kNjs1ZaTwhJsFVaxYxQVhWe6fK/U2fVyecK3kIsyb6KNsuZxUaM0kRM48oMSWBmAZhHx 1/fl6dR39FXEE8vzaHsvGrOGgItvYaQ2BlhxWHm6cH7o1EvzPVzfc37qfeUNeLl4WzYt 0hJe0C5be/Ir5Tmv+koKpWwjk82TgwZmeNyINoZL9D/VuKALcN4zuP+8eJMTQ8uVxRy7 YbBQ== X-Gm-Message-State: ALKqPweJ2Gb8YFquMgSbDKAp91cFgWtzgMVcvKiHImLk5FYFcLFokR2C qvDFdDidiNnqZ2A+HsgAODw8og== X-Received: by 2002:a63:343:: with SMTP id 64-v6mr7081196pgd.354.1527809837664; Thu, 31 May 2018 16:37:17 -0700 (PDT) Received: from [100.112.72.59] ([104.133.9.107]) by smtp.gmail.com with ESMTPSA id j15-v6sm3370785pgv.17.2018.05.31.16.37.16 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 31 May 2018 16:37:17 -0700 (PDT) Date: Thu, 31 May 2018 16:37:10 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: "Kirill A. Shutemov" , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/shmem: Zero out unused vma fields in shmem_pseudo_vma_init() In-Reply-To: <20180531155256.a5f557c9e620a6d7e85e4ca1@linux-foundation.org> Message-ID: References: <20180531135602.20321-1-kirill.shutemov@linux.intel.com> <20180531155256.a5f557c9e620a6d7e85e4ca1@linux-foundation.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 May 2018, Andrew Morton wrote: > On Thu, 31 May 2018 16:56:02 +0300 "Kirill A. Shutemov" wrote: > > > shmem/tmpfs uses pseudo vma to allocate page with correct NUMA policy. > > > > The pseudo vma doesn't have vm_page_prot set. We are going to encode > > encryption KeyID in vm_page_prot. Having garbage there causes problems. > > > > Zero out all unused fields in the pseudo vma. > > > > So there are no known problems in the current mainline kernel? Correct - if we limit ourselves to the area of the shmem pseudo-vma :) Hugh