Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp118212imm; Thu, 31 May 2018 20:06:10 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ6al3QogDjYF4iApaP9r6YWPTHFsrHfqXSlk612MBPsuuu8M9E/n8ybVCKsDd2QasoZDRP X-Received: by 2002:a65:5042:: with SMTP id k2-v6mr7372183pgo.122.1527822370820; Thu, 31 May 2018 20:06:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527822370; cv=none; d=google.com; s=arc-20160816; b=igbTSmoVAHDDwASaO81Oq6N9YZr0OJLJ83EQEmorou+r8dEpCRUyP4hdnpMQbzHVqD QR4irEgDYOdzFnqOnKwd+6Eo6YvWnj/L0a4S3oSzYMenvcZseVUrsKRAx5uB1diuPfGn xmNu5V/WKQlhb/Vh/hERGvoBQmzZZnMYiemb3OBKOXU8ygwxvFmrZECgtI1ZiNpTTkdx Px9BmGDb+J4T5tnTe1F7s/0/NqwFa+mCf/P5wo42agsQcJ4rduAyqyXJIki3Lm8LsrmS 9GuMi16wNTlg8WVC6e2sc2HvMc9u3xH8LfJEUVVArVX5j52vMsiwRyhoy4GB21mlExLm hdLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=3L7EizulKD/jp2RYg4XG16miEvenEw2iknnXT9nJDEc=; b=Z2eulx7fkqroc/BL4ZYNfPX4rNEf4+7421dYVKw1rIX3ThWze9GVvJ5TlG+bEBZMfb vDqTQitr/+mo1cv4eklekfYzR6HcWqHxSE7whfFVLezM7udPbIEM1wvROVtLQwZvr/TA Be3RwFKlBUv+RQZuiEfBA8gkJc8qPs2hqToWmrneXIq6/8RsQx1Hj1moTTI53ZVzAOq2 /oSOJyV6kWIgX4LE49PX4seEy3LI7kmc/MCG6JWO4s39MX5qtCgFYTEE/EPLxvhXgjiy hJFHWUGiEpPZnldK+dQHFcWOm3SaVGUvUvem5FnDwXvRB3GKwEsixXJmG5glQhnkbcYC 4+tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3-v6si38543487plb.394.2018.05.31.20.05.56; Thu, 31 May 2018 20:06:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751031AbeFADEi (ORCPT + 99 others); Thu, 31 May 2018 23:04:38 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:49830 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750726AbeFADEg (ORCPT ); Thu, 31 May 2018 23:04:36 -0400 X-UUID: e82afa92439c40cdab3d851045ee8e8b-20180601 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1483203514; Fri, 01 Jun 2018 11:04:33 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 1 Jun 2018 11:04:31 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Fri, 1 Jun 2018 11:04:30 +0800 From: To: , , , , , , , , , , , CC: , , , , , , Subject: [PATCH v3] PCI: mediatek: Add system pm support for MT2712 Date: Fri, 1 Jun 2018 11:04:30 +0800 Message-ID: <1527822270-30280-1-git-send-email-honghui.zhang@mediatek.com> X-Mailer: git-send-email 2.6.4 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-off-by: Honghui Zhang CC: Ryder Lee --- drivers/pci/host/pcie-mediatek.c | 60 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c index dabf1086..5363cc7 100644 --- a/drivers/pci/host/pcie-mediatek.c +++ b/drivers/pci/host/pcie-mediatek.c @@ -132,12 +132,14 @@ struct mtk_pcie_port; /** * struct mtk_pcie_soc - differentiate between host generations * @need_fix_class_id: whether this host's class ID needed to be fixed or not + * @pm_support: whether the host's MTCMOS will be off when suspend * @ops: pointer to configuration access functions * @startup: pointer to controller setting functions * @setup_irq: pointer to initialize IRQ functions */ struct mtk_pcie_soc { bool need_fix_class_id; + bool pm_support; struct pci_ops *ops; int (*startup)(struct mtk_pcie_port *port); int (*setup_irq)(struct mtk_pcie_port *port, struct device_node *node); @@ -1179,12 +1181,69 @@ static int mtk_pcie_probe(struct platform_device *pdev) return err; } +#ifdef CONFIG_PM_SLEEP +static int mtk_pcie_suspend_noirq(struct device *dev) +{ + struct mtk_pcie *pcie = dev_get_drvdata(dev); + const struct mtk_pcie_soc *soc = pcie->soc; + struct mtk_pcie_port *port; + + if (!soc->pm_support) + return 0; + + list_for_each_entry(port, &pcie->ports, list) { + clk_disable_unprepare(port->ahb_ck); + clk_disable_unprepare(port->sys_ck); + phy_power_off(port->phy); + } + + return 0; +} + +static int mtk_pcie_resume_noirq(struct device *dev) +{ + struct mtk_pcie *pcie = dev_get_drvdata(dev); + const struct mtk_pcie_soc *soc = pcie->soc; + struct mtk_pcie_port *port; + int ret; + + if (!soc->pm_support) + return 0; + + list_for_each_entry(port, &pcie->ports, list) { + phy_power_on(port->phy); + clk_prepare_enable(port->sys_ck); + clk_prepare_enable(port->ahb_ck); + + ret = soc->startup(port); + if (ret) { + dev_err(dev, "Port%d link down\n", port->slot); + phy_power_off(port->phy); + clk_disable_unprepare(port->sys_ck); + clk_disable_unprepare(port->ahb_ck); + return ret; + } + + if (IS_ENABLED(CONFIG_PCI_MSI)) + mtk_pcie_enable_msi(port); + } + + return 0; +} +#endif + +static const struct dev_pm_ops mtk_pcie_pm_ops = { + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mtk_pcie_suspend_noirq, + mtk_pcie_resume_noirq) +}; + static const struct mtk_pcie_soc mtk_pcie_soc_v1 = { .ops = &mtk_pcie_ops, .startup = mtk_pcie_startup_port, }; static const struct mtk_pcie_soc mtk_pcie_soc_mt2712 = { + .pm_support = true, .ops = &mtk_pcie_ops_v2, .startup = mtk_pcie_startup_port_v2, .setup_irq = mtk_pcie_setup_irq, @@ -1211,6 +1270,7 @@ static struct platform_driver mtk_pcie_driver = { .name = "mtk-pcie", .of_match_table = mtk_pcie_ids, .suppress_bind_attrs = true, + .pm = &mtk_pcie_pm_ops, }, }; builtin_platform_driver(mtk_pcie_driver); -- 2.6.4