Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Message-ID: <888102f0-fd22-459d-b090-a1bd8a00cb2b@default>
Date:   Thu, 31 May 2018 21:51:05 -0700 (PDT)
From:   Zhenzhong Duan <zhenzhong.duan@oracle.com>
To:     <linux-kernel@vger.kernel.org>
Cc:     <mingo@redhat.com>, <tglx@linutronix.de>,
        Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
        <bp@alien8.de>, <hpa@zytor.com>
Subject: [PATCH] x86/microcode/intel: Fix memleak in save_microcode_patch
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Free useless ucode_patch entry when it's replaced.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
 arch/x86/kernel/cpu/microcode/intel.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/mi=
crocode/intel.c
index 1c2cfa0..461e315 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -150,6 +150,12 @@ static bool microcode_matches(struct microcode_header_=
intel *mc_header,
 =09return false;
 }
=20
+static void memfree_patch(struct ucode_patch *p)
+{
+=09kfree(p->data);
+=09kfree(p);
+}
+
 static struct ucode_patch *memdup_patch(void *data, unsigned int size)
 {
 =09struct ucode_patch *p;
@@ -190,8 +196,10 @@ static void save_microcode_patch(void *data, unsigned =
int size)
 =09=09=09p =3D memdup_patch(data, size);
 =09=09=09if (!p)
 =09=09=09=09pr_err("Error allocating buffer %p\n", data);
-=09=09=09else
+=09=09=09else {
 =09=09=09=09list_replace(&iter->plist, &p->plist);
+=09=09=09=09memfree_patch(iter);
+=09=09=09}
 =09=09}
 =09}
=20
--=20
1.7.1