Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp200417imm; Thu, 31 May 2018 22:18:39 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIoj4YRXCacD5X4ttinKJy3ImFXhhP27gDAeyqTpZupREub1sZSkEpAjez3eqhGmFYjoLXA X-Received: by 2002:a17:902:7248:: with SMTP id c8-v6mr3000570pll.128.1527830319538; Thu, 31 May 2018 22:18:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527830319; cv=none; d=google.com; s=arc-20160816; b=XtdtUx5H79M/ARlSlkGzYmi3yyfJjCap23qEYiwgnB9OmvM+JGyoO/VYzrOq25qSKC zwuDZEWsmeRLazTSXF9DLX5QweKpMOdlDMDkGPVmPNtUKppZkKfLHNRaveyMY9+CMP+Y hJueICPadtkJytNGKrRg5GS9J+w3KBvqdynxQ2w7+hIaToWOZtjpPY7iJVdqKi3UN5MO ii16ECg2xU+XkJH3OvQuAXHdBoIgAhujvt93PGMb3IuNJt6H7dCtN2kTZ0Y/aaJM99SK RcDtDRo8QUS3f2bUqttybb9xOEioKTom03oRVp3jjeH9Xr7+6Y/hQ2laKcNNNVhVa4sh RX8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=DfcYiGae0wAKSPWYUwQFdLjUazJjcPFPlpLUddbo9TI=; b=ZIODIe4GpCbMpxpeSzOTI2CS82SHGNZ49qBM/2pKIwUOHaSQ4t16w+UwE0Dp3S4zTO 6QJdGWFJw3AHcMhy3gAdpGtPrbpSrtK7SOnrhDqm5oAhF1GAykERZ7Fygyk8NP+2Vg86 mGoG4ygc8ml6qzIUY+8X6iy64OmuhDxST4+xyRHkrqc65GFsJQy+aFspUy9+fOAZzYGb rZU+RPi8mSZqwC9de+bIPNkHDUB1ZRh+tMKql1z6bzwm9w7ZlLG4Ew+2XbCLCbs3wtqT BdvFfZMPukFBssfRx8uZSeE+dqXXNiZIbCgwpZ2cGmqZCjlxjavtdei6VJOQn/o88RD1 n6kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n64-v6si14050241pfh.210.2018.05.31.22.18.24; Thu, 31 May 2018 22:18:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbeFAFQb (ORCPT + 99 others); Fri, 1 Jun 2018 01:16:31 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:60326 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbeFAFQ2 (ORCPT ); Fri, 1 Jun 2018 01:16:28 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fOcQM-0003o0-86; Fri, 01 Jun 2018 05:16:26 +0000 Date: Fri, 1 Jun 2018 06:16:26 +0100 From: Al Viro To: David Howells Cc: linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 20/32] vfs: Make close() unmount the attached mount if so flagged [ver #8] Message-ID: <20180601051625.GR30522@ZenIV.linux.org.uk> References: <152720672288.9073.9868393448836301272.stgit@warthog.procyon.org.uk> <152720685405.9073.17445116582570028610.stgit@warthog.procyon.org.uk> <20180531191955.GG30522@ZenIV.linux.org.uk> <20180601015255.GP30522@ZenIV.linux.org.uk> <20180601031829.GQ30522@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180601031829.GQ30522@ZenIV.linux.org.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 01, 2018 at 04:18:29AM +0100, Al Viro wrote: > +void umount_on_fput(struct vfsmount *mnt) > { .... which needs to do mntput() in case if it's attached.