Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp368988imm; Fri, 1 Jun 2018 02:17:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLu1U2gD7JnlJ4JaBcc5etRBPt3ZR48FFqSUUfkzwRqGZ3Jn3Vbknjpy5BCscrRD/mcJz5j X-Received: by 2002:a63:bf0c:: with SMTP id v12-v6mr8152490pgf.18.1527844639709; Fri, 01 Jun 2018 02:17:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527844639; cv=none; d=google.com; s=arc-20160816; b=iWhof6LZY9Ng5SsOOe7GPVydocLGAScYUUxSY/X3yZ/CbtPNrvIOp8N0r4flZuNhZ6 cA9Vx39yrKvp9xlrscTK4ogxpxrHR6sdcbemb1BGPqu6v8RS/iBLVukrPnoeaMv1fX5N /mFiKxjnnnuJRh8coWXGdbc+i/pOkfvd14x05i8h4R0NdgTRaLH2QCGNdQ0+SA6+q3Mk AAdddKB1gqfBXyVRTtaiAKns5uGYW6Tx/Ij0G5nEWcPHxHMPCqhfZ88rKJeXTaHr5OWV POSReDzs83sBLhzCdpmBrhozntOiXplPqmhOaI8XT+Kb73cn1AJhQPmmKGeUFrjKT+B9 pPFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=1+3Gx1aFQof7U/OJsZMiRJBwbPtZD2CSk6dL5MdydwE=; b=SNZ9EtCV7b46xBSYLB4EPE5bJjnbWY9Xz++4HRMzvVmtyPdU+56T1mWYiU4ghRzMDe blDePYrBodIzrj3dLmzM5yLi/Gd1o2isfp+bLxJLC3a0ltE3cD00le0hcGA+odP5mqzB bpXlmARaU+LwFnluSimUndOttWAhChEFJfjXzqBqMeVgY+ttqbhVfaEDV9ew/KPO6ugK RT1FLeF1zvEI09c9fWz/KgMjhyqN9gk0TlOkJsa08y3afRGPD2J3WZ4307eVz/VEdGlQ fD/qOd/4yJBV8d1s5oznmCFhzWUriMyHbq9fGRrpSnS6S4GvyvrDbnPsl8zpvJ6G7e3W 1swg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wgE5JvJe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y12-v6si1264948pfn.248.2018.06.01.02.17.05; Fri, 01 Jun 2018 02:17:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wgE5JvJe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223AbeFAJQZ (ORCPT + 99 others); Fri, 1 Jun 2018 05:16:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:55700 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbeFAJQY (ORCPT ); Fri, 1 Jun 2018 05:16:24 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5773D2075C; Fri, 1 Jun 2018 09:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527844583; bh=qYAaIk9hy6aHzlQMeOkG3tu00tFUb+7iuu8c+LvzUnQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wgE5JvJeE+aThGsFHyJn6bMS8bRQQ77YAWDWUJQOoNNr/IffAlGiVOr4fHXrJZHEE MVozdks9yyupLUo1jeoqsxlXKsGEnT701l/1/MWfHZp+WvADcFUvVs6ifI6geeqkNE E0vqc7j6S925KTsOhd+Z7eCwbKxzksgFlik+CnaU= Date: Fri, 1 Jun 2018 11:15:53 +0200 From: Greg Kroah-Hartman To: Sankalp Negi Cc: devel@driverdev.osuosl.org, NeilBrown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl. Message-ID: <20180601091553.GA5821@kroah.com> References: <20180531185542.phhu2rkdoq2czkav@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180531185542.phhu2rkdoq2czkav@localhost> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 01, 2018 at 12:25:43AM +0530, Sankalp Negi wrote: > This patch fixes following checkpatch.pl issues: > > WARNING : line over 80 characters > ERROR : code indent should use tabs where possible > WARNING : no spaces at the start of a line > ERROR : switch and case should be at the same indent > ERROR : space required before the open parenthesis > WARNING : braces {} are not necessary for single statement blocks Those are all different types of coding style cleanups and should be done as a patch series, only fixing up one "type" of thing at a time. thanks, greg k-h