Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp438112imm; Fri, 1 Jun 2018 03:46:47 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLZ5HjBv2ha4QISYH9TtTBx3T+O4O0m0MaNlhkbF1bFnJfhOH8UDtIifN7c28WYtHU+vc1/ X-Received: by 2002:a17:902:ab8d:: with SMTP id f13-v6mr10658995plr.81.1527850007487; Fri, 01 Jun 2018 03:46:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527850007; cv=none; d=google.com; s=arc-20160816; b=sbF2lFCSZEdNsGlQEudej9t1tiOhRZR/7tsVAjuyDxz7QuhM4Kpm4dy30TYD/4a2yI dlGn5ldF/s1063jA3ScLlkxoUb/+YJx6pxTRKdqvsU5qFG+PloGkDGcdQjFLEtJFdU7w LijRmJxgwUMS+hmqp/uSl4sE65oFsmZNrPhWo+zGyaGo8qiR63hvUZ+6xt8ASQHPbtpI AO2+ut4Cv9Pewyt4knm3UeZi2iPlw+/KEze5Zl4VkBWqLc0PAB7vCkTiwscBJ9iOilkT f2EwAY+lwvDRmrjBRcQK3+o1ilwRo3TaEgCGXcNEn9wkWh7+k3Lum1QZL3M0TWKOAMOj ohGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=YaRJxoOR8lTmtbo2gVQlV456CYbsXMXVGFTIvmV4sNQ=; b=dyPffZ/+ahnpobNfxX/aPHQTYH+Pn8GVdbeMwQ3XHXInNn/eer+z1oYQzMfNfKGwXT jiDooEGCtrlv8lY84Nh0402hmSOFGB5m5BVQIOMlzB4JLtT2s0yade1g0JyuFsXlGmk9 Bu2bTn5eykpbhrDiwauiRJpdiW3m5Bijh8PCJFK7uQ0YB1RsmBotb13ZLaKQKTFofCa4 WAvsHoTGOJMc006fcyIonyPsTf1yofXNGhaaUFqUAUsfgBy+SK507+OmcS6QXCB7l3GW kqtBUHz8p2RLd0ahrkmkK/7biXuF3cubY4iuhLo8v+lok2jlDNkyYFi6WxCCv5vz/ES4 YYag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=y/KacsAX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1-v6si38147841plr.332.2018.06.01.03.46.33; Fri, 01 Jun 2018 03:46:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=y/KacsAX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503AbeFAKpu (ORCPT + 99 others); Fri, 1 Jun 2018 06:45:50 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36019 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbeFAKpr (ORCPT ); Fri, 1 Jun 2018 06:45:47 -0400 Received: by mail-lf0-f68.google.com with SMTP id u4-v6so14161087lff.3 for ; Fri, 01 Jun 2018 03:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YaRJxoOR8lTmtbo2gVQlV456CYbsXMXVGFTIvmV4sNQ=; b=y/KacsAX9JG47OOVZskJSVAV23jmztw4mYz3J6b1k6MgnPMPwpJhNZcaD3nVDLujw6 ZBRDMoXYvhLW5XORSfl43ERs9yMaKTFhsVh3yta4eS8QlFvtrnX4GFkmWV35/aHkUwpr Ax6uORBWlspnjZMjsMzXO3RHFV57RyUg5eRUIKsq3CCuLX0q407hgN4l9l+l+Iy4yDEE hhky1fa2XmkDLzbJGcoaAE/pOnKQsbuBdQ0hxqzDIkrGDmuGi5zW9dkPStvDQLGj9F5U VaM+EmZhMGaOBtgD6CtHtFnDdbgJJcm2Jh2u2SSXhUtx6CTeYcUzbUDIxfV+8B2XCCT2 8GZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YaRJxoOR8lTmtbo2gVQlV456CYbsXMXVGFTIvmV4sNQ=; b=pGI+f4o1w6lUuYKO6fa93AZkwb+Yt+dOKrNn6vXMWgUuIKOz9075avJfH1qk+Ntnop MRbBmUZY50W4FIZX8kJw9eVSMPqpwKHtEXa6uYUwoNZwgo1GlB78f/hTpGEAvkp5RiOM 3t0dXYvVDrg5q/ENWp6o+TBpf5KqBOo+QYAz+L0qzKI7RfEnHvw3LtRz/6x1UrHlzZ4k Pc7ESZ8qP18W3m33AkKUewQygpOKXn9rKF1YDVy2q4/NFny1sHiddZN20Lxavho3zqlf TCN5HmfBtAaNyFR58BmQ3bw7wEewnk0GH8t+gKpzjNailFY8M80eR89RzN5o6Y/tJbiV ZJWg== X-Gm-Message-State: ALKqPwfR97daAVOsiFDhsNGVtwaD/NGTMV1KONNWtLgDqFTrzvRcZABg BfHlc3OmMk4nWnBqJ17NOF2zsw== X-Received: by 2002:a19:7b11:: with SMTP id w17-v6mr6271241lfc.103.1527849946142; Fri, 01 Jun 2018 03:45:46 -0700 (PDT) Received: from [192.168.0.10] (95-166-82-66-cable.dk.customer.tdc.net. [95.166.82.66]) by smtp.googlemail.com with ESMTPSA id y89-v6sm2176137lje.74.2018.06.01.03.45.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jun 2018 03:45:45 -0700 (PDT) Subject: Re: [GIT PULL 00/20] lightnvm updates for 4.18 To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , "Konopko, Igor J" , Marcin Dziegielewski References: <20180528085841.26684-1-mb@lightnvm.io> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <068976f7-38eb-1960-c62b-814ce75ab3e2@lightnvm.io> Date: Fri, 1 Jun 2018 12:45:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180528085841.26684-1-mb@lightnvm.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/28/2018 10:58 AM, Matias Bjørling wrote: > Hi Jens, > > Please pick up the following patches. > > - Hans reworked the write error recovery path in pblk. > - Igor added extra error handling for lines, and fixed a bug in the > pblk ringbuffer during GC. > - Javier refactored the pblk code a bit, added extra error > handling, and added checks to verify that data returned from drive > is appropriate. > - Marcin added some extra logic to manage the write buffer. Now > MW_CUNITS can be zero and the size of write buffer can be changed > at module load time. > > Thanks, > Matias > > Hans Holmberg (3): > lightnvm: pblk: rework write error recovery path > lightnvm: pblk: garbage collect lines with failed writes > lightnvm: pblk: fix smeta write error path > > Igor Konopko (4): > lightnvm: proper error handling for pblk_bio_add_pages > lightnvm: error handling when whole line is bad > lightnvm: fix partial read error path > lightnvm: pblk: sync RB and RL states during GC > > Javier González (11): > lightnvm: pblk: fail gracefully on line alloc. failure > lightnvm: pblk: recheck for bad lines at runtime > lightnvm: pblk: check read lba on gc path > lightnvn: pblk: improve error msg on corrupted LBAs > lightnvm: pblk: warn in case of corrupted write buffer > lightnvm: pblk: return NVM_ error on failed submission > lightnvm: pblk: remove unnecessary indirection > lightnvm: pblk: remove unnecessary argument > lightnvm: pblk: check for chunk size before allocating it > lightnvn: pass flag on graceful teardown to targets > lightnvm: pblk: remove dead function > > Marcin Dziegielewski (2): > lightnvm: pblk: handle case when mw_cunits equals to 0 > lightnvm: pblk: add possibility to set write buffer size manually > > drivers/lightnvm/core.c | 10 +- > drivers/lightnvm/pblk-core.c | 149 +++++++++++++++------ > drivers/lightnvm/pblk-gc.c | 112 ++++++++++------ > drivers/lightnvm/pblk-init.c | 112 +++++++++++----- > drivers/lightnvm/pblk-map.c | 33 +++-- > drivers/lightnvm/pblk-rb.c | 51 +------ > drivers/lightnvm/pblk-read.c | 83 +++++++++--- > drivers/lightnvm/pblk-recovery.c | 91 ------------- > drivers/lightnvm/pblk-rl.c | 29 +++- > drivers/lightnvm/pblk-sysfs.c | 15 ++- > drivers/lightnvm/pblk-write.c | 281 +++++++++++++++++++++++++-------------- > drivers/lightnvm/pblk.h | 43 +++--- > drivers/nvme/host/lightnvm.c | 1 - > include/linux/lightnvm.h | 2 +- > 14 files changed, 604 insertions(+), 408 deletions(-) > Hi Jens, Javier had some comments to 16, 18, and 20. The rest is ready to go. Would you like me to resend the patches? Thank you!