Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp441630imm; Fri, 1 Jun 2018 03:50:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKhAlQPn/ri4dZQFOmMNCBgMQbvIfjO/grwnTCTSFt7BxG2zjxVdyMIPOj5J1VvABbl2sCi X-Received: by 2002:a17:902:b588:: with SMTP id a8-v6mr10430167pls.308.1527850251185; Fri, 01 Jun 2018 03:50:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527850251; cv=none; d=google.com; s=arc-20160816; b=VjKcwiRiuZ1rFnOXufrNHkQrrMqOj/9WykSCzKrZUotaeujlFqJRJKil/Eh0wnRnjs NDpuJNeS1nHYqEuzSVzTMdaVmXW/iI8ShSdy6AXCO5gqqaftLDdkKZOAsgYvvxk+5Et3 jzlCl9gyrPdDA2rokdJNeVAiUItLE+dXPng9Swwl2DndjQgzK+nuJKKyb7Ki2RQLnRGq JjNgbi3BlIZxMp/hvCh12C/UrZxYcEGpBQZVxzglZ/jOeH3QpkfcsH7QnbOjK3wGrK8P P7QItOtYPcpxeFDsU4OMtyvyLwsaY5yIif4hyEb7GmVurAn6inntQ/NT/PbIrEtGRSez 7wCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=odLMeAJ+qHKcW8BliBQQEJ5O/yGYp5AgDpku1W7Fn08=; b=oX4tjARyj5Mcr29oMvrD5cETwa2zlxPGLMOrFaDQohpogC6gn6aWePxQIQJvdb9WY0 t8FjTUfzHlXeyHVl5/LpxGMqauLMKRS3Stt5An3OqjCi4lYtNQD9Gx2hS+B5Iwfc22oP 7Eu0ifWb/8PQXvJE8q41NyeNVDBS2rbk1O+Zt0Q81zzSTPj40I81SDShpvadPI2TBOq4 US4OIh39V7+N/dI/4MjzrNZI0l6c6W0nG9ufEybmhgQqjuxYnPlZ6Qjkl6d0MkXh6fTQ qoQmq10H71PNBP+L0W5ZJs9urOfvzHHd6DvDno2NgR7YOG+Nhy41PrwVtYms+T/V4DWf YB/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r21-v6si1217911pfh.333.2018.06.01.03.50.37; Fri, 01 Jun 2018 03:50:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbeFAKtE (ORCPT + 99 others); Fri, 1 Jun 2018 06:49:04 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:57762 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbeFAKtB (ORCPT ); Fri, 1 Jun 2018 06:49:01 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fOhcA-0003Bd-7H; Fri, 01 Jun 2018 18:48:58 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fOhc8-000896-JP; Fri, 01 Jun 2018 18:48:56 +0800 Date: Fri, 1 Jun 2018 18:48:56 +0800 From: Herbert Xu To: NeilBrown Cc: Thomas Graf , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/18] rhashtable: split rhashtable.h Message-ID: <20180601104856.zdawjbtejcpr22aa@gondor.apana.org.au> References: <152782754287.30340.4395718227884933670.stgit@noble> <152782824932.30340.8068908844678938422.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152782824932.30340.8068908844678938422.stgit@noble> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 01, 2018 at 02:44:09PM +1000, NeilBrown wrote: > Due to the use of rhashtables in net namespaces, > rhashtable.h is included in lots of the kernel, > so a small changes can required a large recompilation. > This makes development painful. > > This patch splits out rhashtable-types.h which just includes > the major type declarations, and does not include (non-trivial) > inline code. rhashtable.h is no longer included by anything > in the include/ directory. > Common include files only include rhashtable-types.h so a large > recompilation is only triggered when that changes. > > Signed-off-by: NeilBrown Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt