Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp530703imm; Fri, 1 Jun 2018 05:26:24 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLJmgkRoebcM1ZR3VhFjZGvzV9cy3FLZ7s9Jaa7ja+sFj9Kw8GKM9UVp0PobQRZbR+rvmru X-Received: by 2002:a65:65c8:: with SMTP id y8-v6mr8840460pgv.320.1527855984309; Fri, 01 Jun 2018 05:26:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527855984; cv=none; d=google.com; s=arc-20160816; b=eTN//PatgOFZ+pIfsN8ONTkRB9YWrbODhJa/xwqzDaNcCHoCYOwKMkfcmCCjHFCWrK /tlzWlXfWjeHHuzU2ntm7i8MBH1CrXiJSqGPEsc4ccvibQdDD9zSH+nU5JWD9AqujK9X aeXgmpMIXICQY6Jon0VnKkVbH6cmICMYhx/7pvLE7J8d1KbPY6jyOVVX8MTxzLmChjV/ KaqCK5LRZALb7p7J2t6D2ycRjTkhFSzI5sV32qR2M5ZKzaX6+1WylHgCCAFr8wmNY0vm jRjdVNEuiNtmbCIhxYC81jVahpB+RMfm8HEIwVsNzWRrIc1ELOBqzYpVDXJ+wtN5XFTF +Sug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=nMlJJnmiAFRzP50HGBZCwhtIvu75iJQo86J8FXkl1DY=; b=WXZVo25+BEk621ioV2e/RzBLGuUzCYAvT0nl3pVOujdVbT4xAnP4ysGb7uf/aPrn+a BKvVVLlHL0WhgYcFx2tCIUqXrtHcuCIdE8BMgW3S9+/aZwN+FZ/+i3xX/Fxq9linXgEs DaVt5J88Pwkh1hsNMbCXA/5uAMw29dzHu1ZEAEuqEhxnEmJWFWx+jzwFZqr0JWi1PrvY tNSKyFvuDWkayjQkkCbLJKtb5q8JYJ1mfSzPugu+D/j8h08IpSUkOUAq/HC36Q2fvK+q lPk5N3QeGMncZX2qXp8BlDgRtXjZr9SUPfnc04KwEDt2K7Uh8lW/j7F8swzBF45Iboud 0ETw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 189-v6si1910521pfg.163.2018.06.01.05.26.10; Fri, 01 Jun 2018 05:26:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbeFAMYX (ORCPT + 99 others); Fri, 1 Jun 2018 08:24:23 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751792AbeFAMYS (ORCPT ); Fri, 1 Jun 2018 08:24:18 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D038440BC056; Fri, 1 Jun 2018 12:24:17 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE182210C6CF; Fri, 1 Jun 2018 12:24:11 +0000 (UTC) Date: Fri, 1 Jun 2018 14:24:10 +0200 From: Igor Mammedov To: Pankaj Gupta Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org, linux-mm@kvack.org, kwolf@redhat.com, haozhong.zhang@intel.com, jack@suse.cz, xiaoguangrong.eric@gmail.com, riel@surriel.com, niteshnarayanlal@hotmail.com, david@redhat.com, ross.zwisler@intel.com, lcapitulino@redhat.com, hch@infradead.org, mst@redhat.com, stefanha@redhat.com, marcel@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, nilal@redhat.com Subject: Re: [Qemu-devel] [RFC v2 0/2] kvm "fake DAX" device flushing Message-ID: <20180601142410.5c986f13@redhat.com> In-Reply-To: <20180425112415.12327-1-pagupta@redhat.com> References: <20180425112415.12327-1-pagupta@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 01 Jun 2018 12:24:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 01 Jun 2018 12:24:17 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'imammedo@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Apr 2018 16:54:12 +0530 Pankaj Gupta wrote: [...] > - Qemu virtio-pmem device > It exposes a persistent memory range to KVM guest which > at host side is file backed memory and works as persistent > memory device. In addition to this it provides virtio > device handling of flushing interface. KVM guest performs > Qemu side asynchronous sync using this interface. a random high level question, Have you considered using a separate (from memory itself) virtio device as controller for exposing some memory, async flushing. And then just slaving pc-dimm devices to it with notification/ACPI code suppressed so that guest won't touch them? That way it might be more scale-able, you consume only 1 PCI slot for controller vs multiple for virtio-pmem devices. > Changes from previous RFC[1]: > > - Reuse existing 'pmem' code for registering persistent > memory and other operations instead of creating an entirely > new block driver. > - Use VIRTIO driver to register memory information with > nvdimm_bus and create region_type accordingly. > - Call VIRTIO flush from existing pmem driver. > > Details of project idea for 'fake DAX' flushing interface is > shared [2] & [3]. > > Pankaj Gupta (2): > Add virtio-pmem guest driver > pmem: device flush over VIRTIO > > [1] https://marc.info/?l=linux-mm&m=150782346802290&w=2 > [2] https://www.spinics.net/lists/kvm/msg149761.html > [3] https://www.spinics.net/lists/kvm/msg153095.html > > drivers/nvdimm/region_devs.c | 7 ++ > drivers/virtio/Kconfig | 12 +++ > drivers/virtio/Makefile | 1 > drivers/virtio/virtio_pmem.c | 118 +++++++++++++++++++++++++++++++++++++++ > include/linux/libnvdimm.h | 4 + > include/uapi/linux/virtio_ids.h | 1 > include/uapi/linux/virtio_pmem.h | 58 +++++++++++++++++++ > 7 files changed, 201 insertions(+) >