Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp602659imm; Fri, 1 Jun 2018 06:35:35 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJq4As1jtw+hjuZifn2gz/s8mIauBp9fqg70g+I5LPfEWSK+vY4V6iOlObhGo8pUMzuIxWe X-Received: by 2002:a17:902:543:: with SMTP id 61-v6mr11232615plf.47.1527860135518; Fri, 01 Jun 2018 06:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527860135; cv=none; d=google.com; s=arc-20160816; b=sa50ktS6pz6LVPZ4DrZQQEjunzJKYR0G8Mryx8iuUWC5adiMG6J+sRmu8E9v0UBjES Z3qabQsWQzNz69puQ7EBE7VpRlVVlO1+9tPx06wJ/nzPtfem9K9qhQKcA1DdMsfmLVgY sZOn/THkQx0fr7FPhJpiYJv9/f/MiW/mquS7TEs9k8cmbX2/pBDXq5FalPN5LF+KA2cq LkcW9hK3CwrHTx6zIv+aM6t0C7/Xm0zxms5d/EqvsCRYuaoBd0BBdNWh74WKJs5DOlgE xahTMGuezfJz3UeiTZ7u4+Ym03tnV6Ax+mVR9FHhTC2a8rp7/y+jqJFUaQCPc8cuaKP1 xX0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=4FKNIBl+iwmFPrp7Y8JjGMd7RWNiFGCa206V1izis+w=; b=0gz0396Z5r+EBYtVyE/91urJEWMiaq3okx9qWM94wRltCXkkx1jyd0M1YUfTwMBhaY vx3KQuHUdx2uNM+ci0SkvimFgqiWOnQD7eHf1Ffk3vxwvDoq56e3AK4TdEBRvF0cYsY5 yT4YpYe7RQqVD1iQN1SjahgXAX99kNE9ZvDmmckd+Cdx9b/K+Xtvbg/uwhN2OKx0MpeX Bl0yjN5nsq+PTDNpTmAx5Rv29xyZftwCAK3+WwK0/kzZZFHddXH+iyN1A0xt+H9hmTEO ZVIbiVcI7qKkkwLF1rZkcKN1hDVtoAUHd8RTKzAXFAOqkmg/S5W7FXjkHKJ7bOGeEdf8 3xEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lQfugVa7; dkim=pass header.i=@codeaurora.org header.s=default header.b=oMMGyjmN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6-v6si39861853plp.175.2018.06.01.06.35.19; Fri, 01 Jun 2018 06:35:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lQfugVa7; dkim=pass header.i=@codeaurora.org header.s=default header.b=oMMGyjmN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070AbeFANeK (ORCPT + 99 others); Fri, 1 Jun 2018 09:34:10 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36086 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbeFANeH (ORCPT ); Fri, 1 Jun 2018 09:34:07 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 205F86074C; Fri, 1 Jun 2018 13:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527860047; bh=7MN8FiJ9pAOhbInE5qFfBDDHm2xc4n0uBHK2MMJfcZA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=lQfugVa7P4BduZ80VxC5yYLfol8FC5wS/hWLrUpVgUJJSlAvDww6HHHy/byDgq4Lm RHbAWD9oB0XiwK0r17+ON42j5dN60XtKctQ4BhTDXItr2Csz03Tt/pbJTgeA0nmk1L 9B84d56Qw4nEg3cNTfgC7NG9f0AV2TbkxSuMg200= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.235.228.150] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9477B60224; Fri, 1 Jun 2018 13:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527860046; bh=7MN8FiJ9pAOhbInE5qFfBDDHm2xc4n0uBHK2MMJfcZA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=oMMGyjmNUXi16WrGCA74aNlF6JC66CnQ9h6HSE7K7+Fy5YZRmNMpQ8IKk98R2EsxA QORpEWVyvEcyrTLA6wx+cyi2D1OAytLNseahP8IRhdWuyJ1bbw+sFE6kwx3hWwZarV PGMDHifikwgrB5rO7t0OLbnUQy9WCDts5649I4mg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9477B60224 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback To: Don Brace Cc: Ryan Finnie , linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , "esc.storagedev" , "open list:HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)" , open list References: <1527542471-10316-1-git-send-email-okaya@codeaurora.org> <1527542471-10316-2-git-send-email-okaya@codeaurora.org> <51bb7b82-c4a1-435c-7668-639db96d76e1@finnie.org> <3ebb873ea4658275e7fa89c01cd8bfe1@codeaurora.org> From: Sinan Kaya Message-ID: Date: Fri, 1 Jun 2018 09:34:04 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <3ebb873ea4658275e7fa89c01cd8bfe1@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/2018 9:08 PM, okaya@codeaurora.org wrote: > I have seen that shutdown() is also called from remove(). > > remove() is supposed to do a safe cleanup too. If it is leaving the hw in inconsistent state even though it is c lling shutdown , it is yet another bug. Let's try to be constructive. I'll post a patch with the pci_disable added to shutdown only as in my original proposal. Somebody can deal with remove another day. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.