Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp702936imm; Fri, 1 Jun 2018 08:09:06 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKBpLDA1muqibPS9KGGFU91p6/7IYkTkOsPemMGIYGhJIPNfvy32lZFaHadIjP+zrxsuaRA X-Received: by 2002:a17:902:9a9:: with SMTP id 38-v6mr11725691pln.114.1527865745967; Fri, 01 Jun 2018 08:09:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527865745; cv=none; d=google.com; s=arc-20160816; b=vFl0bjQYYY+6TKc5a3AvEWO7Mo+qYykhxuO00Gh9GOggXAxKRWkhjpVwTvRsRkA/a8 9YhjI7T2Hb72dJY7hA8XQKr94ndoN4r01tvRT8uzP+PfwpKqr8DVSwEXUT+DAUlEUVZA DApMYuXNDLRBiMF5cPgM6rRVBWMnkWMgW13OFpRTpLroqE5Lcnh/ifxpLiKDvQy4QS/f dQyUeBPszODFVK4cwbg39Z8xoxyyLsNEO9FbR6lxBvyA/SgUXC0jvpy/hVlWuVY77F5d MEQMEXc7iCvZanFSa7PsmUjCkB44XXUkm5vJI2Nv9v20eeoK5idmXC2H0TTsf2ZQxafM vn0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=dsWZ6vW0ExmD80YBa2K562qGMS8PANMK4pn3wpi5/F4=; b=Z/X0BBbiT2Me/9VDieYv5QRwOSp+ZM30xls7GKxo1aIrD8OFy+4j84rYsPpwg1JFNn Rj/kzqj/w3pWuARO1krWErVgKaMY7qXp7a4CJDimgeL1UhrtE4EDhWq5PEuos2rpgQMe 25jzN1LRA8SqWzfIcFNQae4VK0IQxYkIIxpvUfjGihylT9HoXbbHBQNDYQofYCjbz3Bs LvawCT6G87pQPWeJK32xhwcooLExZ1fqkV9XyzgJRirXFhSmUD3oGQpVwoxt1U4BVxSx RTxQ0JGBRv91hREAJa+7YCdIJwShxZzCEIWbk1ZAko9lAxjC0Q3xYDXJ0Ci6TLtwLB3U X1Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PgR0c+0f; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m14-v6si32202624pgs.178.2018.06.01.08.08.51; Fri, 01 Jun 2018 08:09:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PgR0c+0f; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752642AbeFAPHE (ORCPT + 99 others); Fri, 1 Jun 2018 11:07:04 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:39201 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbeFAPHB (ORCPT ); Fri, 1 Jun 2018 11:07:01 -0400 Received: by mail-it0-f68.google.com with SMTP id c3-v6so2189404itj.4; Fri, 01 Jun 2018 08:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dsWZ6vW0ExmD80YBa2K562qGMS8PANMK4pn3wpi5/F4=; b=PgR0c+0fx9iSXc0n4fIdWY3jZ1FpKW/ntoEvy/1zLOO8nebE9P89gQC6WLz6Mssr+m DK2/wfnGFB3o9EpqOt4naxw+S8RUbrXOLlZmjrfV7+GEXVy4bAcC3Jtq4nsBSIafZhWz l3Hg/EBV5BSowX3rVfBExeGwUl7nQgMzpLcP89OCY/bDjuNbBH1qCd1pOefycAU2Mmtk r5qchBxIzos/bKw4m00XZVoVlkhvMagO8bAALrCt6X67mCHQPLp2gF+cDDf7pp2H5iJE R3XoTjGaVrm5jYbu/3VwI5LxhkNpu6vuqQgs1mfZxE2Nr851wFnUj3vUzm9Vc2A0MIxb +77w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dsWZ6vW0ExmD80YBa2K562qGMS8PANMK4pn3wpi5/F4=; b=ftFFiOUW6xRVA+eIir+rkwbnmGZZnP0VY19+Ajr2p34ms5/jH62UcRXjdDd7Y0At4n WwRBOfMxQ1DWryQuTEHIT60bDL4vJ/TXmhzf4DAJk0Xfs+Pi2BnHO329mY/5dXahDE3p MOtIzqiVtP18kJ7p3uZidPCkKcfnLlKl6Y+j4CSv6IU5UOPa0F6UUscTs4C6v3bdmUvw +gDSpDQ1CEBBMldva1XjKBNXL5RbnLrHnXGVGHuQ3HvIWlZOyZXd2VpSOYjR5JKwK8+1 awNw82cBcvFy/lMzqZ1/+L2UfX2xzvETAGmXbVgBq8XgXatXp8fYJKdTv+4SYp7VKlNM n8iA== X-Gm-Message-State: ALKqPwdY3WNKKQ3p+bpjW1GHgQKtCBMwYl6dXOV4PcFrN0Dicbtv0eEa zyPDTQ7hHCXq8oZfSLRNfz7eiHqaIbg= X-Received: by 2002:a24:f502:: with SMTP id k2-v6mr4903558ith.1.1527865620121; Fri, 01 Jun 2018 08:07:00 -0700 (PDT) Received: from nuclearis2_1.gtech (c-98-201-114-184.hsd1.tx.comcast.net. [98.201.114.184]) by smtp.gmail.com with ESMTPSA id e18-v6sm1025602itf.29.2018.06.01.08.06.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jun 2018 08:06:59 -0700 (PDT) Subject: Re: [PATCH v2] PCI: Check for PCIe downtraining conditions To: Sinan Kaya , bhelgaas@google.com Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180601150129.10486-1-mr.nuke.me@gmail.com> <35a67b5b-5f37-c779-64a3-eb5e21362e9c@codeaurora.org> From: "Alex G." Message-ID: Date: Fri, 1 Jun 2018 10:06:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <35a67b5b-5f37-c779-64a3-eb5e21362e9c@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/2018 10:03 AM, Sinan Kaya wrote: > On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: >> + /* Multi-function PCIe share the same link/status. */ >> + if (PCI_FUNC(dev->devfn) != 0) >> + return; > > How about virtual functions? I have almost no clue about those. Is your concern that we might end up printing more than our fair share of link statuses? Alex