Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp748873imm; Fri, 1 Jun 2018 08:53:55 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKK9y7B3Ue7iWNcZxnv2iikcTF0jFMp5C8gsBnNs/mbWdz2jSHU3jr6DRXV8Gxky2VKM1CS X-Received: by 2002:a62:df12:: with SMTP id u18-v6mr11435622pfg.230.1527868435462; Fri, 01 Jun 2018 08:53:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527868435; cv=none; d=google.com; s=arc-20160816; b=KGlHZ0nXMQOnRnsARSMgBjUQEX3/89RpEWdau87ljrnuHD2bvyKUlYQylhAGmt3sob VuGPAlTULUq++SKdk94se2t5Ff3zyAlP8xI1N/IyNdKFl+fItFaSoABjHYg911iKDVxY aKIT0JfG91Sx2rLWcQxf2T8WQpK9W6kBJM3TnTIeNjBNZhjUIBYx/QhKmKffcqfS866L ay0t6Jpv635hF85E0nSSpZpzS7TaHhuIUzWmA2AUWQY1xsbhVPCRE3WEKKOnueJfWgsy D9M2b5v4KOnKBRTuDd7QDaKoXprdtYVVmFE3MCsYafJ6pccBFhTKPdVs7VrMXS9Dyy4y +JrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=YpECvuEw5RBneLS3R27BptmbvybI6PXfSYU+afnFYcM=; b=TAjCxMTeB6qQTyzMN8clsAMmFezMaDfrtJeSv5rRAPNqBQpE/pUPSSJo35sQ0eArhp iqWMvhClM4TUpTweWf1uuJONkz6ivbUKiLo3yekNzJ6U3F3G+vZowlRvxcx/zACKGIuv ta3XMzd4ViJrdkSDX6MsYj/LTADCQy+SJmTf/O3olFNTSeyr9/7KL3ARZmfnTcbNeJbP 8MtE7uogxMmmaDe/Et0rEV6Op7he01iqVGLhmTeBUPAoRMYd7eQ5M2ulVIiVLxw8U88m 6cNwaQpcxA8AzdMQyhzzkXJFqfUoLNuo0KlrlxNfLrr2Ty4C5+63euCY+0z8EkfU97kk DDmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=CAYySjU+; dkim=pass header.i=@codeaurora.org header.s=default header.b=CAYySjU+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11-v6si32032519pgr.275.2018.06.01.08.53.40; Fri, 01 Jun 2018 08:53:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=CAYySjU+; dkim=pass header.i=@codeaurora.org header.s=default header.b=CAYySjU+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753285AbeFAPw7 (ORCPT + 99 others); Fri, 1 Jun 2018 11:52:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34376 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbeFAPw5 (ORCPT ); Fri, 1 Jun 2018 11:52:57 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B758A60708; Fri, 1 Jun 2018 15:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527868376; bh=J7ARA5D3bxll/TDjyIDMR8CAQ1dqpkIAH1pveHJY3Fg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CAYySjU+VdgBSyCwRwme2Uvkt7VbLcl5bDSsavPGtFRTcf1X1QjLaJzQNbQZwCSPD 0L9aLIw3IwMNr2x1UN0PcIOT29HYOnei3+vhyjWpt449s2Va27wyJB+jiCff+rkuM/ 06/NkCQTR9gjuI8w1tE21VKsLmJIFPcHhD9kPEb0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3C5C460769; Fri, 1 Jun 2018 15:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527868376; bh=J7ARA5D3bxll/TDjyIDMR8CAQ1dqpkIAH1pveHJY3Fg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CAYySjU+VdgBSyCwRwme2Uvkt7VbLcl5bDSsavPGtFRTcf1X1QjLaJzQNbQZwCSPD 0L9aLIw3IwMNr2x1UN0PcIOT29HYOnei3+vhyjWpt449s2Va27wyJB+jiCff+rkuM/ 06/NkCQTR9gjuI8w1tE21VKsLmJIFPcHhD9kPEb0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3C5C460769 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: "Gustavo A. R. Silva" Cc: Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] qtnfmac: fix NULL pointer dereference References: <20180601132408.GA2572@embeddedor.com> Date: Fri, 01 Jun 2018 18:52:51 +0300 In-Reply-To: <20180601132408.GA2572@embeddedor.com> (Gustavo A. R. Silva's message of "Fri, 1 Jun 2018 08:24:08 -0500") Message-ID: <87muwezep8.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Gustavo A. R. Silva" writes: > In case *vif* is NULL at 655: if (!vif), the execution path jumps to > label out, where *vif* is dereferenced at 679: > > if (vif->sta_state == QTNF_STA_CONNECTING) > > Fix this by immediately returning when *vif* is NULL instead of > jumping to label out. > > Addresses-Coverity-ID: 1469567 ("Dereference after null check") > Fixes: 480daa9cb62c ("qtnfmac: fix invalid STA state on EAPOL failure") > Signed-off-by: Gustavo A. R. Silva As commit 480daa9cb62c was recently applied to wireless-drivers-next I'll queue this to 4.18. -- Kalle Valo