From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@redhat.com>, Paul Mackerras <paulus@samba.org>,
       torvalds@transmeta.com,
       linux-kernel mailing list <linux-kernel@vger.kernel.org>
In-Reply-To: <20030904092915.GA16344@lst.de>
References: <20030903203231.GA8772@lst.de>
	 <16214.34933.827653.37614@nanango.paulus.ozlabs.org>
	 <20030904071334.GA14426@lst.de>
	 <20030904083007.B2473@flint.arm.linux.org.uk>
	 <20030904073845.GA14669@lst.de> <20030904010940.5fa0e560.davem@redhat.com>
	 <20030904092915.GA16344@lst.de>
Message-Id: <1062670026.1820.68.camel@gaston>
Mime-Version: 1.0
Date: Thu, 04 Sep 2003 12:07:07 +0200
Subject: Re: [PATCH] fix ppc ioremap prototype
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 24

On Thu, 2003-09-04 at 11:29, Christoph Hellwig wrote:
> On Thu, Sep 04, 2003 at 01:09:40AM -0700, David S. Miller wrote:
> > On Thu, 4 Sep 2003 09:38:45 +0200
> > Christoph Hellwig <hch@lst.de> wrote:
> > 
> > > Umm, right, so the typedef name is also completly bogus, if we're
> > > going to go that route it needs to be something likeb iocookie_t.
> > 
> > My suggestion is to just pass a resource and an offset to ioremap().
> 
> Here's a ioremap_resource implementation.  Tested on ppc32 with a
> converted sungem driver.

Please, make so that ioremap_resource can be passed a PCI IO resource
as well and just do nothing in this case.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/