Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp899977imm; Fri, 1 Jun 2018 11:30:17 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLlQhX4ZrqUH+92Cjhte+lfsfOBPSfz7Xo+kpFuK3ZY0+k4d+6t7OzNr5VFEZOvG4iaUSnd X-Received: by 2002:a62:59d0:: with SMTP id k77-v6mr11879121pfj.4.1527877817802; Fri, 01 Jun 2018 11:30:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527877817; cv=none; d=google.com; s=arc-20160816; b=XimdGAyUMPcbHhzTaZSDjSf8CWrBSPbKiBB69h/mXQn6hlUc7CwvcV5UiH5qerC5DC zHNHyTF6mS8/qaNPGH82g9fqXlYhAwW885pRu/WBILpUvw99CST0zf8E+B7kkhorrz80 4WVOEEVCVDXSCC8jmyaRCBia5zD+8zBnZA0hOB7eDNi/PK5Bk8vvHJmME41DyI2fGxPR G9Q8pf7z7c92VWC1BSKDFGnDRkS4PSttK5ZgfS89cEQq2UNc896Rqozb9eB30GZJlpx6 mpHa/kulK7Wy4I+RRFYs1DEHG+iv2Q6m5m/4bgC6s+INc2elOO6zXiX0slqINXaQppLi iQGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :ironport-phdr:arc-authentication-results; bh=DyPgCjR67Gn3soigQWOAOLkT60XbprcbYPRpjM2cCig=; b=OtWkIUbGT9i3WbH6NTtzJKw/cx7J/jcAYyhv7pQZVddblcdBhBjRNYV6Fe5hWJItfh pmotxkmRIxpCoZT/lSWpl01MjWozv0AEapm3aUhDPfimtJAjruqT+OVq1FFXMdP0ogqr DtbgBOZYlnkXOK2zAjeuBd99Brm06Habh1+UpZF5f4x41JWmoId8WE65JBksu/+DpH5i I+zkZD+VuJyJP14YWBo/++Z+TOac+cujQWzJ/zECOlLBfyDKCXN3z3jbPBAqZfj6Q9Po vb/VaOm9G2RAAU4NsbaaFHyQckfY+GxKNL2YnhPx5+Ozt3rh0FSl7Gimep4yH1eFlbq4 q5Pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5-v6si3496309pls.360.2018.06.01.11.30.03; Fri, 01 Jun 2018 11:30:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbeFAS3d (ORCPT + 99 others); Fri, 1 Jun 2018 14:29:33 -0400 Received: from mx1.ucr.edu ([138.23.248.2]:36805 "EHLO mx1.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbeFAS3c (ORCPT ); Fri, 1 Jun 2018 14:29:32 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3ApNxBVhGqhmlaEpiqirdRc51GYnF86YWxBRYc798d?= =?us-ascii?q?s5kLTJ7zoM+wAkXT6L1XgUPTWs2DsrQY07eQ6/iocFdDyK7JiGoFfp1IWk1Nou?= =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZr?= =?us-ascii?q?KeTpAI7SiNm82/yv95HJbAhEmDqwbaluIBmqsA7cqtQYjYx+J6gr1xDHuGFIe+?= =?us-ascii?q?NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S6dYDCk9PGAu+MLrrxjD?= =?us-ascii?q?QhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VC+85Kl3VhDnlC?= =?us-ascii?q?YHNyY48G7JjMxwkLlbqw+lqxBm3oLYfJ2ZOP94c6jAf90VWHBBU95RWSJfH42y?= =?us-ascii?q?YYgBAe0aMOpEs4XwvUcCoAGiCQWwAu7k1z9GhmXx3a0/y+ktHwHH3Q0gH90UsX?= =?us-ascii?q?TYsMn5OakJXOCo0KbI1y/PYO1L1jfg5oTDbxcsoPGNXLJwa8XRyFUjGx/Lg1iL?= =?us-ascii?q?tIzqIymV2v4TvGeG8uptTOSigHMkpQFpujWj2Nsgh43Tio8Wyl3I7zh1zYIrKd?= =?us-ascii?q?GiVkJ3fcKoHINNuyybM4Z6WN0uTm9otSog1LELuIS3cSoFxZkh2hXRceaIc5KS?= =?us-ascii?q?7RLmTOuRJDB4i297d7+nnBay9FSgyvX7VsmpzFZGtipFncfItnAKzxHT79KISv?= =?us-ascii?q?p5/ku4wTaP2Rzf5vhKIUwqiabXN4QtwrE3lpoUvkTDGjH5lF/qg6+Rc0Uo4umo?= =?us-ascii?q?6+L5bbX6vpKQKZN4hwXkPqktmsGzG/k0PwwQU2SB5+iwyKHv8VX8QLpQj/02lq?= =?us-ascii?q?fZsIrdJcQevqO4Aw5U0oY55Ba+EzuqzNoVkGIaLF1ZYhKLlZbmNEzTIPzgF/ew?= =?us-ascii?q?n0yskCt3x/DBJrDhBpTNLn7ekLbuZLp96FBTyBA1zd9B45JZEa8BIP3tVU/rrt?= =?us-ascii?q?DYDQE2Mxayw+n5DNVxzIQeWXiAAvzRDKSHk1iF/O1nGe6BaIIR8GL/LOIiz67k?= =?us-ascii?q?nGM0ghkaZ6b/mdMWb3W9A9xiIl6Fejzog9EcASIEuRc4QOX2iVqEFzlJaDL6W6?= =?us-ascii?q?M6+yF+C4+8C4rHbp6ijabH3yqhGJBSIGdcBQOiC3DtIs+VSfcFaXrKeed8mSZC?= =?us-ascii?q?WLS8Acd1xAOuvQ6ik+FPM+HOvCAUqMSwh5BO++TPmERqpnRPBMOH3jTIFjkskw?= =?us-ascii?q?=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2C1AADUjxFbhsjAVdFcGgEBAQEBAgEBA?= =?us-ascii?q?QEIAQEBAYVMjFqMCIJuk1eBeAEKLIRAggchNRcBAgEBAQEBAQIBEwEBAQgLCwg?= =?us-ascii?q?oL4I1JAGCfFIpbAEFASIBEoMiggGbODyMcTOHVwEHHkSBaAkBCIYBgixUgT+BD?= =?us-ascii?q?4JYinwCgSMBAQGLbItZAQYBAQECgS2NNIdihTABK5BHAgQCCQIFDyGBIQGCCHK?= =?us-ascii?q?Ba4Emgi6OQE98jm4BAQ?= X-IPAS-Result: =?us-ascii?q?A2C1AADUjxFbhsjAVdFcGgEBAQEBAgEBAQEIAQEBAYVMjFq?= =?us-ascii?q?MCIJuk1eBeAEKLIRAggchNRcBAgEBAQEBAQIBEwEBAQgLCwgoL4I1JAGCfFIpb?= =?us-ascii?q?AEFASIBEoMiggGbODyMcTOHVwEHHkSBaAkBCIYBgixUgT+BD4JYinwCgSMBAQG?= =?us-ascii?q?LbItZAQYBAQECgS2NNIdihTABK5BHAgQCCQIFDyGBIQGCCHKBa4Emgi6OQE98j?= =?us-ascii?q?m4BAQ?= X-IronPort-AV: E=Sophos;i="5.49,467,1520924400"; d="scan'208";a="959951326" Received: from mail-pf0-f200.google.com ([209.85.192.200]) by smtp1.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 01 Jun 2018 11:29:31 -0700 Received: by mail-pf0-f200.google.com with SMTP id z1-v6so14949162pfh.3 for ; Fri, 01 Jun 2018 11:29:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DyPgCjR67Gn3soigQWOAOLkT60XbprcbYPRpjM2cCig=; b=K/i24n6r2gMcngDKjgvOnmTsj5kkILAITKuTghtfSB6yLLgetITiF+jyq+ui5aLnlg QzcshpsnfmvEmznX2HBpTpV3hKsr8TWglqHXBwYsgmIwTbwm+p0tBwzyjb1K1nYERExk QoUux5avRhOjT8AclmNU2h+XWqYhZUCyqk+xzPkeF9iDv56kN0wcLqWjtUoULth/plUF laQkrAd9IHjmykIPKzmIjzj/gy/OriBX8vOjFzTTWywu8UBX4VGiJf9k0ZF5hZCoPb9Q Nqn6Bb7HWKiov4pIbrW8OnxtPJzm6U20bX4obzOVc8M7q14yflWPR8gDy8LFVWegJXSV VGyQ== X-Gm-Message-State: ALKqPwccxFRLO+qznLpTGAJt2xdDNCkE1SCHBMNGobfn6AyxKcnptscN 2BLLwFyAbnyeoox0b7X3DQ8qaSjecaJfBW8OreQiVYZlRK+ec4p1xQCJFo2o7ZhsyWjX5wWy3fF rCOmfAYAnjhXrkbJLckByMYeZyA== X-Received: by 2002:a65:508d:: with SMTP id r13-v6mr9948985pgp.134.1527877770700; Fri, 01 Jun 2018 11:29:30 -0700 (PDT) X-Received: by 2002:a65:508d:: with SMTP id r13-v6mr9948968pgp.134.1527877770372; Fri, 01 Jun 2018 11:29:30 -0700 (PDT) Received: from Yizhuo.cs.ucr.edu (yizhuo.cs.ucr.edu. [169.235.26.74]) by smtp.googlemail.com with ESMTPSA id s28-v6sm34338797pfg.89.2018.06.01.11.29.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Jun 2018 11:29:29 -0700 (PDT) From: "yzhai003@ucr.edu" To: Joerg Roedel , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: yzhai003@ucr.edu, csong@cs.ucr.edu, zhiyunq@cs.ucr.edu Subject: [PATCH] iommu/amd: Argument page_size could be uninitialized Date: Fri, 1 Jun 2018 11:30:14 -0700 Message-Id: <1527877815-11132-1-git-send-email-yzhai003@ucr.edu> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Argument "page_size" passing to function "fetch_pte" could be uninitialized if the function returns NULL The caller "iommu_unmap_page" checks the return value but the page_size is used outside the if block. Signed-off-by: yzhai003@ucr.edu --- drivers/iommu/amd_iommu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 8fb8c73..7c15eaf 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -1398,6 +1398,8 @@ static u64 *fetch_pte(struct protection_domain *domain, int level; u64 *pte; + *page_size = 0; + if (address > PM_LEVEL_SIZE(domain->mode)) return NULL; -- 2.7.4