Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp944643imm; Fri, 1 Jun 2018 12:21:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIxCoZeHgwXgKuvdAmZjeW4ll4Zv6aJsW1sKofM0GY8UrWTTxh+drKw7Uhbs3kzN58B2dwv X-Received: by 2002:a63:7906:: with SMTP id u6-v6mr1570119pgc.284.1527880876752; Fri, 01 Jun 2018 12:21:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527880876; cv=none; d=google.com; s=arc-20160816; b=fsHDIn0Ndl/db4XyPJORCa/Y1NGhDZOIxQzX0gd8YueT0Ay1PcHyOhKXMmr4rzCpxD Zv1hoyueUvyMgzBARd3E66kTDjd86xOgHH2FXyTWltSZdBXAOVDsaDDoTsBCTHDA3nx8 fk1ldv84EhBYcB4GxPMmwwsu1Xfya8tcYvXqxk5BhQsgUDNvkQGoUtv7knFvKTZHnOab JDRrBiB6ab5+zP15/Ycpqc0XwImJmWRAb4VgfC+b4AYpCkf2knQKaO40qvEZyaCh9hCz KY/jL0yCuQ7h9PM88gOxKbFSocogeYfpRUuYjpi4ZZzlyr4S2Q9/mHlr7Yytnln23vPn FH9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=uzN2FZzx/gOa98zd31UmKQ2YIKkHLpOShlYGsiJn6QU=; b=hry1iXHgHBVpmgJEvcOat6CEacec08HVwgzc6elykLwrFtQAtYajWRR9YKslPDuEU4 rLC1+rz28WmqCAsuo0+c0kabwOzn7CpoOrq82D22MNX329Bqc4Wsx2PCijRuCgL3O4Kd 8AiXqaOXvtwa0YEE6CEVXJPfW4C2J1eOv5rN6sEW8oGEEQi+yz13k8bNsDJFgigNWAN3 5y18g63bzvnqmNT8BM2T7DmOuq9zh41ZXzRzHTysPP1KfilekcLS9mfPFxe4Z/+KCXad xCSUR9MVz2XTmGCavgPs5/ojoubZnqcaiibaad4SIrsVUeCzREUdvs/REqofduLhXFsO BAJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bitmath.org header.s=20140924 header.b=RVxCCnI8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b24-v6si15389761pfl.223.2018.06.01.12.21.02; Fri, 01 Jun 2018 12:21:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bitmath.org header.s=20140924 header.b=RVxCCnI8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753641AbeFATTT (ORCPT + 99 others); Fri, 1 Jun 2018 15:19:19 -0400 Received: from mailrelay1-1.pub.mailoutpod1-cph3.one.com ([46.30.210.182]:61293 "EHLO mailrelay1-1.pub.mailoutpod1-cph3.one.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbeFATTQ (ORCPT ); Fri, 1 Jun 2018 15:19:16 -0400 X-Greylist: delayed 963 seconds by postgrey-1.27 at vger.kernel.org; Fri, 01 Jun 2018 15:19:16 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitmath.org; s=20140924; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=uzN2FZzx/gOa98zd31UmKQ2YIKkHLpOShlYGsiJn6QU=; b=RVxCCnI8R4nv77XKtudKw3Oik2tH31Ig8iNwn4KgqYKAgioCP1QcnjcUXFPdCcq9synvfX86hJSzT 96xldCixPiAYXeWG5h7CSMQciDZo3MeH4Y/P3y2HdnWis8gG7iEn8Amh9akVFaDPIeEg9sdOyrHR3C 0PxpKK/Piop02Il0= X-HalOne-Cookie: 121addfac42c3cd53c6ff6b48e91901f7f2d53a7 X-HalOne-ID: 6d9c663c-65ce-11e8-8fa3-d0431ea8a283 Received: from [192.168.19.13] (unknown [79.136.64.225]) by mailrelay1.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 6d9c663c-65ce-11e8-8fa3-d0431ea8a283; Fri, 01 Jun 2018 19:03:11 +0000 (UTC) Subject: Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches To: Dmitry Torokhov , Benjamin Tissoires Cc: Jiri Kosina , Jason Gerecke , Dennis Kempin , Andrew de los Reyes , "open list:HID CORE LAYER" , lkml References: <20170811004500.13740-1-dmitry.torokhov@gmail.com> <20180601184330.GD222005@dtor-ws> From: Henrik Rydberg Message-ID: <72b7120a-d304-0b2f-d04a-473631623f72@bitmath.org> Date: Fri, 1 Jun 2018 21:03:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180601184330.GD222005@dtor-ws> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> However, I interpret a firmware that send (confidence 1, tip switch 1) >> and then (confidence 0, tip switch 0) a simple release, and the >> confidence bit should not be relayed. > This unfortunately leads to false clicks: you start with finger, so > confidence is 1, then you transition the same touch to palm (use your > thumb and "roll" your hand until heel of it comes into contact with the > screen). The firmware reports "no-confidence" and "release" in the same > report and userspace seeing release does not pay attention to confidence > (i.e. it does exactly "simple release" logic) and this results in UI > interpreting this as a click. With splitting no-confidence > (MT_TOOL_PALM) and release event into separate frames we help userspace > to recognize that the contact should be discarded. This is in part why I objected to this patch on August 11th, 2017. Logically, the confidence state is a property of a contact, not a new type of contact. Trying to use it in any other way is bound to lead to confusion. Henrik