Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1051426imm; Fri, 1 Jun 2018 14:27:04 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLJswU+gxyEwlhGO7DGQExUCKctnJRpgGlZMb6ufk4zlaANsWtgIp0uyramqTizvzjoOAEx X-Received: by 2002:a17:902:7603:: with SMTP id k3-v6mr9220112pll.371.1527888424576; Fri, 01 Jun 2018 14:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527888424; cv=none; d=google.com; s=arc-20160816; b=zyPeinCztVwYWtXp7492VBEFeixOBS47WS9OsCLW2QIrTTuYaWoag3WWtHc9rLuLPB ziw0co1Ena5v/ViOwHfV+mbBYZGW2Wja/gT9JHUPsePej/1QDLhLhQByHYtcs6yp/3CP Q0WgMFQA5BaKYWbc/jANmt068lrYPFNTaOoJGk1BxGE3hT07vIAq82cF+es2s55OLL71 uiuGG1WCq974tT/Ea7l2aMe76pueW+qUSPa/zQ8vLAtaN8PfRkQjIyV5qT4FZDA7q9Rw bcMFoQppnG2jOs+gARc1OVh4SZAZ7kVohdwohBxQOYnygwZSY+Qoa9vNS3A+0tzq5RsL YwjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=FAEZ/zMBgpszWCWPKMJnJ12rLHCGd+ifs0cDLik0jts=; b=N3GJfVfAYgxDGueO30GyEVxSu0PTKUaYZ+3ozspyXzSNNS86y16Z1ONr32wXe3nayv i+v4F0e4w6oY+E0InPJf+GCBMXtuihSv19lYoSw126Sw2xRYgAfCcotTI+2kQzUs6LSZ 2sj9/CUvDP8OxwclxKZwbS5w216Y+CfM6AYnMxlBCVzcAokHNsS0GGCiRcIFQ/Nb8pls 8UmfRWcMfscDjtmp7NYoGJuWxlisfwohL5fjX2vMV0YAqYVNZnfD2WFmVauxq3fUIbKO z9SI0rjr4BZ2gxHdzzBYWfIt0sxYnBXlnTIF9Nyuj1DdmiXVowVQGhPerXnWF8I7B0X4 jY9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11-v6si40974116pfh.131.2018.06.01.14.26.49; Fri, 01 Jun 2018 14:27:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750902AbeFAV0Z (ORCPT + 99 others); Fri, 1 Jun 2018 17:26:25 -0400 Received: from foss.arm.com ([217.140.101.70]:58420 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbeFAV0Y (ORCPT ); Fri, 1 Jun 2018 17:26:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C1BF41596; Fri, 1 Jun 2018 14:26:23 -0700 (PDT) Received: from armageddon.cambridge.arm.com (armageddon.cambridge.arm.com [10.1.206.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 609453F53D; Fri, 1 Jun 2018 14:26:22 -0700 (PDT) Date: Fri, 1 Jun 2018 22:26:19 +0100 From: Catalin Marinas To: Stefan Wahren Cc: Stephen Rothwell , Marc Zyngier , linux-arm-kernel@lists.infradead.or, Will Deacon , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: linux-next-20180601: build error in arch/arm64/kvm/hyp/hyp-entry.S Message-ID: <20180601212619.6trmvqrgmbczekkt@armageddon.cambridge.arm.com> References: <457305318.78169.1527883507093@email.1und1.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <457305318.78169.1527883507093@email.1und1.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, On Fri, Jun 01, 2018 at 10:05:07PM +0200, Stefan Wahren wrote: > i can't build todays linux-next-20180601 and get the following error message: > > arch/arm64/kvm/hyp/hyp-entry.S: Assembler messages: > arch/arm64/kvm/hyp/hyp-entry.S:128: Error: constant expression required at operand 3 -- `bfi x0,x1,#VCPU_WORKAROUND_2_FLAG_SHIFT,#1' > > Related commit: > arm64: KVM: Handle guest's ARCH_WORKAROUND_2 requests > > Toolchain: gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu > Kernel config: arm64/defconfig Thanks for reporting this. I can hit this as well. It looks like an #ifndef __ASSEMBLY__ in the wrong place in arch/arm64/include/asm/kvm_asm.h. I can't tell whether it was caused by a merge conflict resolution or just some unfortunate interaction between the security fixes going via the arm64 tree and the other arm64 KVM patches. I'll have a proper look tomorrow. -- Catalin