Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1082766imm;
        Fri, 1 Jun 2018 15:08:51 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKIGfMiW8SgDUeZgbnleCqav/kzm9jq3/N/JhDVHrRLW8Ggoegdh1I7LBuRuCL6CnYD8i4n5
X-Received: by 2002:a62:ec5b:: with SMTP id k88-v6mr12222713pfh.85.1527890931803;
        Fri, 01 Jun 2018 15:08:51 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1527890931; cv=none;
        d=google.com; s=arc-20160816;
        b=HP+opNTEyka558xMhKzbntmk59slBfIocuZKO4P8IT3vKTeajbiGKq3aKDaoaLnEFl
         JJ1hvpc0MPzv0aN9aDHpISy7H83rDnmkyTKalGBnEaByLv3xDTsn6UsLUEHBsyR6xjYq
         QdnmPE3gU7jY3CJArr+e/eNxe0oVRoBVIgyMF1ml9hcv7kK5gio5/2jrN+U3mhDrGMvO
         YJAtHEDGIy3+Ewy7588fojzXEFH6Fqb89hGfj8tX1Gx8WNdAePNbHfC6Sy2uUP61rdpa
         DfgZlKkBXOLDQ3oAO2aU2DFq2/jeEQVpoU1wHpdbvs+vF9zU2lBr+C4I23T6Q8PCewbb
         E/8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=VIYa9Vb2tQm5PSOf5Of3c3nxyrD6LuZ/wnlS2HFVz+Q=;
        b=hIC7uldZB6k8L4D5RRuVPoEIGMi5dyE78qMO0i2lQe/173cQ+WqZHzA1BNYSVnQkNo
         EzQTRrkYiqMtV99wT7TaKD8L8RDQRTA0MF9YkxxHTMlRrgoPY6RmYBhFlZpzms/Haw3r
         W+YQZ9bn7YWa6Sbls8YTT8bmg0/vJVnItR+qap4P6ev9Xq8PwWdR5upgSHJvgDulWXHP
         czqtbDDg0DEab0UU9PAkzF4d597hgLKjCxM4GytHiNgrVwMMZCqtadC5KPnFUUKBgl0X
         95mdeUjfSMTjVbzedi+vN4N4IlkUg2QaaAYzP3Bj1M743jB14yRyykZ/5CW2zA0ZIDCe
         wr+w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id c2-v6si40699596plb.77.2018.06.01.15.08.37;
        Fri, 01 Jun 2018 15:08:51 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751209AbeFAWIG (ORCPT <rfc822;ttoukan.linux@gmail.com>
        + 99 others); Fri, 1 Jun 2018 18:08:06 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:2811 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750991AbeFAWIF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Jun 2018 18:08:05 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b11c3d10004>; Fri, 01 Jun 2018 15:08:17 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 01 Jun 2018 15:08:04 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 01 Jun 2018 15:08:04 -0700
Received: from HQMAIL104.nvidia.com (172.18.146.11) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 1 Jun
 2018 22:08:04 +0000
Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL104.nvidia.com
 (172.18.146.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2 via Frontend
 Transport; Fri, 1 Jun 2018 22:08:04 +0000
Received: from [10.20.229.152] (Not Verified[10.20.229.152]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121)
        id <B5b11c3c30003>; Fri, 01 Jun 2018 15:08:04 -0700
Subject: Re: [PATCH v2 1/2] power: supply: sbs-battery: don't assume
 MANUFACTURER_DATA formats
To:     Brian Norris <briannorris@chromium.org>,
        Guenter Roeck <linux@roeck-us.net>
CC:     Sebastian Reichel <sre@kernel.org>, <linux-kernel@vger.kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, Alexandru Stan <amstan@chromium.org>,
        "Doug Anderson" <dianders@chromium.org>
References: <20180601172400.50737-1-briannorris@chromium.org>
 <20180601173434.GA22509@roeck-us.net>
 <20180601183126.GA72050@rodete-desktop-imager.corp.google.com>
From:   Rhyland Klein <rklein@nvidia.com>
Message-ID: <10b558c4-9734-061f-c6ed-5b1288d1f23f@nvidia.com>
Date:   Fri, 1 Jun 2018 18:08:01 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180601183126.GA72050@rodete-desktop-imager.corp.google.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/1/2018 2:31 PM, Brian Norris wrote:
> Hi,
> 
> On Fri, Jun 01, 2018 at 10:34:34AM -0700, Guenter Roeck wrote:
>> On Fri, Jun 01, 2018 at 10:23:59AM -0700, Brian Norris wrote:
>>>  drivers/power/supply/sbs-battery.c | 54 +++++++++++++++++++++++++-----
>>>  1 file changed, 46 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
>>> index 83d7b4115857..8dea63464a3f 100644
>>> --- a/drivers/power/supply/sbs-battery.c
>>> +++ b/drivers/power/supply/sbs-battery.c
> ...
> 
>>> @@ -315,6 +320,27 @@ static int sbs_status_correct(struct i2c_client *client, int *intval)
>>>  static int sbs_get_battery_presence_and_health(
>>>  	struct i2c_client *client, enum power_supply_property psp,
>>>  	union power_supply_propval *val)
>>> +{
>>> +	int ret;
>>> +
>>> +	if (psp == POWER_SUPPLY_PROP_PRESENT) {
>>> +		/* Dummy command; if it succeeds, battery is present. */
>>> +		ret = sbs_read_word_data(client, sbs_data[REG_STATUS].addr);
>>> +		if (ret < 0)
>>> +			val->intval = 0; /* battery disconnected */
>>> +		else
>>> +			val->intval = 1; /* battery present */
>>> +		return 0;
>>> +	} else { /* POWER_SUPPLY_PROP_HEALTH */
>>
>> Static analyzers may complain that else after return is unnecessary.
> 
> I noticed (checkpatch complains) but decided I didn't care. It would be
> worse to promote the 'else' to top-level (things would look asymmetric).
> I suppose I could pull the 'return 0' out, but I'm not sure that would
> make the code any better.

I generally prefer to make checkpatch happy, so I would vote to move the
return outside of the if blocks as a minimal way of making it happy. In
general though,

Acked-by: Rhyland Klein <rklein@nvidia.com>

> 
>> Other than that
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>>> +		/* SBS spec doesn't have a general health command. */
>>> +		val->intval = POWER_SUPPLY_HEALTH_UNKNOWN;
>>> +		return 0;
>>> +	}
>>> +}
>>> +
> 
> Brian
> 


-- 
nvpublic