Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1386691imm;
        Fri, 1 Jun 2018 23:20:08 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKL73A5FUDj+l+TORl8A5teqzHX+2EA2ZEM2QTSEc7A77ULd3YeXnXDvNyWbxhFTUS+lGB9Z
X-Received: by 2002:a17:902:bf43:: with SMTP id u3-v6mr1787184pls.322.1527920408528;
        Fri, 01 Jun 2018 23:20:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1527920408; cv=none;
        d=google.com; s=arc-20160816;
        b=BfY/dOqroTg6ODDMIJm8XFtotCsB209MWSaSKXiMBoaQlS7PobV/pcRyoC5LP+pt4n
         R+PzX4pqYfCihKq1AgXLdHu0nwQisbBcR616PHpZNWwupnRoRNnqRiYhb8jjlUPDzRrz
         Vv3ZfriHornhrff5C8TsgNq/aHFU5dLHt1kmQYUxuoNrIc/jTij/9v1PxoG7FELc8brh
         ORgzUj5YJx+IUC2s4kESoBbbwzsQ4VaZ792qqBk/xEJy0J/gbH181cKZXvP6MY3eq1Rb
         IxawUAr0PyWzzySGcqF/pr3Tehm8fftENFi/ob6S7QBWWK9nEiQ9oeu2NcxcmpXA4vVI
         Bovw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:date:subject:user-agent:message-id
         :references:cc:in-reply-to:from:to:content-transfer-encoding
         :mime-version:dkim-signature:arc-authentication-results;
        bh=PkF2guQKoA9Ml+q+B8m0ghIIFssJnWjqFw33mdlnHjw=;
        b=zKEKtSWnOtsDnfbwzLlvac5c7pYtwHAAoesK7Y5P2/WQFrc/PknV+HI8exqh4wZlgU
         bZpy1iuoG5kuKxicCK5QqQ1gY3iX8HPdKtwYVd0QkeLamJJHxPdT1XH6qKW46c+8hLm8
         UtTSkEEKfj2dTEKsWvU1atwF4uRr88KdzU04VzQ6sSp/u3LHi01vpoRT92snjsYAEdgv
         C8k8ZTnYXd2yuKQWc3PIbphI4LzA4U4jU/5RL5UdsjrB8bMwM++fNe6a2aC5wvdZbkK0
         gwilmIoj0XHsaJf63Mot2Z6KzT82xr/oiGAG34NV45C0GoNt2MUW6ybvKoGAa9NkKifw
         w3uA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=vdlMi+Rr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id f8-v6si18056779pgu.6.2018.06.01.23.19.54;
        Fri, 01 Jun 2018 23:20:08 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=vdlMi+Rr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751555AbeFBGT1 (ORCPT <rfc822;ttoukan.linux@gmail.com>
        + 99 others); Sat, 2 Jun 2018 02:19:27 -0400
Received: from mail.kernel.org ([198.145.29.99]:51876 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751031AbeFBGTY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 2 Jun 2018 02:19:24 -0400
Received: from localhost (unknown [104.132.1.75])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id E121B2087D;
        Sat,  2 Jun 2018 06:19:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1527920364;
        bh=wqzMaWvBpFCp2GOgLujjLaSHeGuJUtq4xTRupZte1ds=;
        h=To:From:In-Reply-To:Cc:References:Subject:Date:From;
        b=vdlMi+Rr41iDY1rWy3FAde0OdFcKJsIhzd7U8QxZGBkz27sj9QG6aI+25q9jL7242
         lvUapGMPj26dFMm63eIXjsexG4FiXNpZyWtEYk28ObVT/PA0Fyhn14KmFINik0Gw1O
         fYmMnKr7LyQ2PxaV1+pHp83v6n7FKSATX7qLnK98=
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Anson Huang <Anson.Huang@nxp.com>,
        Stefan Wahren <stefan.wahren@i2se.com>, fabio.estevam@nxp.com,
        kernel@pengutronix.de, mark.rutland@arm.com,
        matteo.lisi@engicam.com, michael@amarulasolutions.com,
        mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <1439344955.9677.1526991935718@email.1und1.de>
Cc:     linux-clk@vger.kernel.org, Linux-imx@nxp.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <1526959560-6014-1-git-send-email-Anson.Huang@nxp.com>
 <1439344955.9677.1526991935718@email.1und1.de>
Message-ID: <152792036327.225090.14543251343485084840@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH 1/2] clk: imx6ul: add GPIO clock gates
Date:   Fri, 01 Jun 2018 23:19:23 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Stefan Wahren (2018-05-22 05:25:35)
> > +++ b/include/dt-bindings/clock/imx6ul-clock.h
> > @@ -242,20 +242,25 @@
> >  #define IMX6UL_CLK_CKO2_PODF         229
> >  #define IMX6UL_CLK_CKO2                      230
> >  #define IMX6UL_CLK_CKO                       231
> > +#define IMX6UL_CLK_GPIO1             232
> > +#define IMX6UL_CLK_GPIO2             233
> > +#define IMX6UL_CLK_GPIO3             234
> > +#define IMX6UL_CLK_GPIO4             235
> > +#define IMX6UL_CLK_GPIO5             236
> =

> this change looks like a breakage of devicetree ABI. You are changing the=
 mean of the existing clock IDs on i.MX6ULL, which probably regress the com=
bination of older DTBs with newer kernel.
> =


Agreed. Why can't we just tack on more numbers at the end?

> >  =

> >  /* For i.MX6ULL */
> > -#define IMX6ULL_CLK_ESAI_PRED                232