Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1443802imm; Sat, 2 Jun 2018 00:54:50 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKzDue7kqPIR003nBjHf3tvk+4UsIYasTzBwzCp8JHMGvXmBygL8pRbHbjfZmzKyE/yEpH5 X-Received: by 2002:a65:4587:: with SMTP id o7-v6mr6773566pgq.386.1527926090892; Sat, 02 Jun 2018 00:54:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527926090; cv=none; d=google.com; s=arc-20160816; b=E0oTSF0u+hWBCdFv7q+NqG76ZdI8SYV1F58fxMj6QOivVY+jDGPninYJF0HXBr5NZT myDf+fDNLsuB6gEAYGOt0CA4siR00w0a/y/ukkiU/6ABv9DUzrHMKkw2kG6VcoKxZQ/M J3daNM2+ZNM8xfUBLLSJ71tuzRB9XSfrR+UtPM7MC7Ivx+gS6lelRNL84DE1RVGGfexT EzBPkrgpT7XYmMXAk77nliwrCReYr3nBWDrJEYS1V+KSFfi5LAsc+RChwDYDuUPLX85o 8Y4i3nmtfik8yM95gU9izmZjPMHnLJfuIYnLZ0FSa0ByodBEvrLLcEEGiQSAeaAB6Jf6 WfJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=Zud/ElhD3TcQKf1nfKcLH6Y3gRP3ouoOzAT1tLtNHYs=; b=fCnk+KAgpH6u+Zl57CkHCwMwxXBmH5rMaOMnAZVSa/Lo6EscqT82szd2ZkHegBZpPx bmS2tg4SW8plVQgLk+ylYVm1+paTODCnzYkd6/tz2LVmdXfbhOQ35IFNdlLJIdjMMHJO yf/Rab83web3Kq2f9Fxa1hqMKJrkFER6xggBNU+jo/zj67TnXxJKyTewX29D0pPQ2+tz jQ/kghsThcSeHLYFFtFQpyc09sUDdWzqrEaMqkCnoh+4rYJA7ekHFOIOzzrbuzQ5qW3D 4hk1dyEdlnu/OPBLjNlIB1V+TQMzkDZnyMQLxqihAPQvL00dyXKgm+jahqD3ABOSsrKQ rWLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=mwGcUSyO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24-v6si41268220plo.489.2018.06.02.00.54.35; Sat, 02 Jun 2018 00:54:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=mwGcUSyO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbeFBHyE (ORCPT + 99 others); Sat, 2 Jun 2018 03:54:04 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:33248 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbeFBHyA (ORCPT ); Sat, 2 Jun 2018 03:54:00 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w527ppbb062312; Sat, 2 Jun 2018 07:53:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=Zud/ElhD3TcQKf1nfKcLH6Y3gRP3ouoOzAT1tLtNHYs=; b=mwGcUSyORt6LP3AuhUI8ZFTLV7E30c7U2JtmQRwfWqV5Cki1UOYrosix4drVeBQrjAU7 qGNE8TSg0+P+gra978EuMLOln8G49vsgQTib/VoQcHWnRPLqh6BX9/0cDH4jf+7yt1n9 OHix3Fs2TL9RMz+AnKdZNhhhLkyVX9xOANQ+eKMJDn8BmgkVXMEEhkMRh3/b8qIV30HI Y0Edyy4ARDbfyIBjmlANA9tMCvhW8x2dS6F/G209FoYpKiduATpwcHAiAAE5KaERp4Mu 6OyWLDKO1gTGGnNAQsnPBNvGXim94JmiykN87MwpCfsEOu8JdEmySYww6TTqI9J00xle ig== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2jbjpa873e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 02 Jun 2018 07:53:10 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w527r9ge013962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 2 Jun 2018 07:53:09 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w527r77V028782; Sat, 2 Jun 2018 07:53:08 GMT Received: from kili.mountain (/197.157.34.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 02 Jun 2018 07:53:07 +0000 Date: Sat, 2 Jun 2018 10:52:56 +0300 From: Dan Carpenter To: David Lechner Cc: Sekhar Nori , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] clk: davinci: cfgchip: testing the wrong variable Message-ID: <20180602075256.hrvidsfsmr33mv2f@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8911 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=912 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806020091 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a copy and paste bug here. We should be testing "usb1" instead of "usb0". Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks") Signed-off-by: Dan Carpenter diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c index c971111d2601..20a120aa147e 100644 --- a/drivers/clk/davinci/da8xx-cfgchip.c +++ b/drivers/clk/davinci/da8xx-cfgchip.c @@ -672,7 +672,7 @@ static int of_da8xx_usb_phy_clk_init(struct device *dev, struct regmap *regmap) usb1 = da8xx_cfgchip_register_usb1_clk48(dev, regmap); if (IS_ERR(usb1)) { - if (PTR_ERR(usb0) == -EPROBE_DEFER) + if (PTR_ERR(usb1) == -EPROBE_DEFER) return -EPROBE_DEFER; dev_warn(dev, "Failed to register usb1_clk48 (%ld)\n",