Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1452990imm; Sat, 2 Jun 2018 01:08:49 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLZIZzJl2Et9t9p1FL3z14cDi5tf48szMPcJmg14CMyV9Di+Ed6IEiEBmI21b2ILV8iJFAB X-Received: by 2002:a63:77c6:: with SMTP id s189-v6mr11584099pgc.450.1527926929826; Sat, 02 Jun 2018 01:08:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527926929; cv=none; d=google.com; s=arc-20160816; b=cVbs+z5c8qqaztmwrIUkCk6IbxcS6hPYpzTJTzR15P/XdACCpGFC5AWbfGm8Ra+UZ8 Sg3QukSCA/UKSJGocnKsfzL4Z4kCDObT3cpEqK/PMemBjjCmab8dCuXQmJ0gC+SQkfPn E2AflJAvX6Oa7wl1SQgWRij/gZWgXHvRh9D3t4q0RxRtLvUXYsIVbUVJBQhfXmxQ7Quw Qje6yEePsw61B4PJJtOGY6SPtuXBGfK0Ozc8Kr2q2ONUoVv80xj2fb7blRRFdsoH6ehy lZ1/cH34ZYQrv5i7jcptfYIR87Zg9ima6IBkjwGdjRSI1vUVytuhfYNfxa3btwieJv9O ox9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=E+QajuoMLD6t/Qc5YCS1fgG727UUTmBGbcCl3pH4iEs=; b=EfO/Ucn8lvNB/Kgm4X8hex9lvG8X7ywJFC3KR3QotohAYWABcAEgHzA5X+8xtXnAMK jQAhQ1HTZZ5ydfCq71LTDA3JOohnVb+E5Mm88gd6zLr0FTX0I3SiAAovstSBLB3/+nee ZVUUREdg5t4o/AuLWmRv6Y2ODex/wD0vuuu73+267n0cvZ2ia9S125SwY5mDAVeCA/3A wn/HWfT0ez9KJy8GdqFAphOI/VzNkoBN7S4Fr5pj7IfAnWtKfTPiH4X6J/8hUC22hGfN lBLZ8kmOm02L+rzzBqWjcOhxIX3u2cubWs5G6vhXia2lXNqqXzjNgoyOmonzod1OCfHZ 6+pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91-v6si41846635plh.488.2018.06.02.01.08.35; Sat, 02 Jun 2018 01:08:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbeFBIHg convert rfc822-to-8bit (ORCPT + 99 others); Sat, 2 Jun 2018 04:07:36 -0400 Received: from mondschein.lichtvoll.de ([194.150.191.11]:58195 "EHLO mail.lichtvoll.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbeFBIHa (ORCPT ); Sat, 2 Jun 2018 04:07:30 -0400 Authentication-Results: auth=pass smtp.auth=martin smtp.mailfrom=martin@lichtvoll.de Received: from 127.0.0.1 (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lichtvoll.de (Postfix) with ESMTPSA id 0655733407D; Sat, 2 Jun 2018 10:07:27 +0200 (CEST) From: Martin Steigerwald To: Ming Lei Cc: Jens Axboe , Tetsuo Handa , Bart.VanAssche@wdc.com, dvyukov@google.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, jthumshirn@suse.de, alan.christopher.jenkins@gmail.com, syzbot+c4f9cebf9d651f6e54de@syzkaller.appspotmail.com, martin.petersen@oracle.com, dan.j.williams@intel.com, hch@lst.de, oleksandr@natalenko.name, hare@suse.com, syzkaller-bugs@googlegroups.com, ross.zwisler@linux.intel.com, keith.busch@intel.com, linux-ext4@vger.kernel.org Subject: Re: INFO: task hung in blk_queue_enter Date: Sat, 02 Jun 2018 10:07:26 +0200 Message-ID: <6992049.xPdnW5VfcJ@merkaba> In-Reply-To: <20180602045353.GA20257@ming.t460p> References: <20180602045353.GA20257@ming.t460p> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ming Lei - 02.06.18, 06:54: > On Fri, Jun 01, 2018 at 10:31:13PM -0600, Jens Axboe wrote: > > On 6/1/18 8:36 PM, Ming Lei wrote: > > >> clear the bit when we need to, potentially even adding a debug > > >> check to blk_queue_enter_live() that complains if the ref was > > >> not already elevated. Though that would be expensive, compared > > >> to the percpu inc now. Not saying the bit is necessarily the > > >> best way forward, but I do like it a LOT more than adding an > > >> argument to generic_make_request.> > > > > We may introduce generic_make_request_with_ref() for > > > blk_queue_split(), what do you think of the following patch? > > > > Functionally it'll work as well. > > If you are fine with this one, I'm glad to prepare for a normal one, > so that we can save one precious bio flag, and the total number is > just 13. […] I am completely lost about what you are talking about. That is fine with me, but in case there is anything to test… let me know. I do not promise quick responses tough, as I have been quite a bit overwhelmed with stuff lately. Currently I run 4.17-rc7 without any blk-mq related patches and it appears to be free of hangs or stalls related to blk-mq. Thanks, -- Martin