Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1519693imm; Sat, 2 Jun 2018 02:55:43 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKlmOsxRIrCDHkFUWlQRgdYvnlwpmJidKGqsCxTRg414OOi/OpVltg7zsxWy6wJKpUXAmDE X-Received: by 2002:a65:5546:: with SMTP id t6-v6mr11536402pgr.363.1527933343294; Sat, 02 Jun 2018 02:55:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527933343; cv=none; d=google.com; s=arc-20160816; b=cfFEkaxDwqBXfLm2nwH3XHp5/RhTUvqrPf+T3xkv3n45tUTwGmxdNLf3g/i4kaayib luoE7W+J18+/v27QcnidIcIlco7xMHeS9ovCoxX5bVzZsnTTQJfUVCA/z1qE8Ip7nHmW 7cd+2R8veexjYfiQ7z++k9MfJ4ySxJNZ7sMgTvIw/eTgpoRY82RblQ3bbUaONdvzMG4P p/pCIDPzItUuCoxFx/E7wD0c8qLCVNnkFNef8Mrdq3XFeeyUY/8XSvL1E4UgwwxR/ZBL gjXn05EOh6kw4A777a9nPNCV/5VgJ0Hn8RGWVsDzTMj1YeFLbhmeWkcfspBm3UztUlIZ VHgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=NMl3oELFcJiW+2yvgWxLaAb3NqGh8Znk7FGnbN/SjS0=; b=RYAqFpnwfy9spdWM2Naxe60b6bM3Ezpr3nQFzSEt6cMFK3y9Y2IXrJAzRdHUTyolre DVDTzAuPpxp4/1L0gQAx3mHe14I8YXBzRHo3BFN8KzjG74IZC4MFgm03I1+ysTUXBnA0 f2kVCAM1kOwKXy6mW8Wld8P+QMWEDSOJQWlYiWBc58/W74b4IE5mgnwCJkbSd+5Rme73 9UgMVkuF6EUIgl1UKcfmuo6l08KZLOIitX4AAUHHMB1eB4np2uXi47ZBEOUT4qjUgTP8 ew/PeKXcV9RQIoBDaEX43aK+vbVZVr4DYt1hGQB9pj9a/n8ZjFIDzeEMXkU5lfzePETv KN2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RRlIDafw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h185-v6si19669426pgc.296.2018.06.02.02.55.28; Sat, 02 Jun 2018 02:55:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RRlIDafw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbeFBJxw (ORCPT + 99 others); Sat, 2 Jun 2018 05:53:52 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36361 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbeFBJxu (ORCPT ); Sat, 2 Jun 2018 05:53:50 -0400 Received: by mail-pg0-f67.google.com with SMTP id m5-v6so7952261pgd.3; Sat, 02 Jun 2018 02:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NMl3oELFcJiW+2yvgWxLaAb3NqGh8Znk7FGnbN/SjS0=; b=RRlIDafw/HekgRoBy0rKPhFxZm43rubre+xKt7VG9fKVg/oa02k/tNzArso3v0B3AN P6DM7Bae/W+W0CIN4vOM2MjcJcfXCSGZjJ/V3mcWmMq8wd0AR8loZD3Nc953OH8rg2fP C0+ADFukc+eAjZSEXUPoqNc2z0JC0I7o/9tm++puVwNNBaRy3jhdtgSie6JWMRjjyDbw mR7+aUyM/cWZDoEUCN7sTyaELRhQZ+f2RIzEVbsAhmuKCk0OQL4SsoJHekMxtewkNv2N Y4nIQHobiHFqxltzfTkqz16UZ1diROGw1HpxqMMGm/IdtzqYiaHyBWzjMBX81SZPAQ0u p75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NMl3oELFcJiW+2yvgWxLaAb3NqGh8Znk7FGnbN/SjS0=; b=Xwx6L1+Ov54//hEwoCKlfcK6FtwtZRYYdEYQqD+0S5vRiZs+YIE1rh6Kbzd/NyAYOt +OBErBjsJXDPb6QVlixiNDwsJf/r/cILq11Oq19T0ShwmDQMonSlDV4tEUoqmpcYNmBQ owacoh08dudV/UineK8rSqKUxEtM10c5QC3ZsgTIvpuU6ttZ3HbYyXwkghNGLrIKGOCW nPM6kT7xBbWfJSjQmTnr5ERB3XuU2988OYiyV52cCNzkolC9NP2kSS+M1no/0MJ0Qb8N 0AGhhj7G43YlCq87iOzxb07/ExduD4Z/GHWQbfWQzedaqGbNi5BMtrEgaf3lsr9fvre/ w49A== X-Gm-Message-State: ALKqPwdPuHIp0tIFw8WRZAts1cZPbPsrIgQNMjvc8ECBzx+xfa5o66fv 21yjogTs1MaV7FkLOLmYifg= X-Received: by 2002:a62:3d05:: with SMTP id k5-v6mr13805157pfa.122.1527933229518; Sat, 02 Jun 2018 02:53:49 -0700 (PDT) Received: from [10.246.221.134] ([50.234.174.228]) by smtp.gmail.com with ESMTPSA id t10-v6sm10780922pgn.20.2018.06.02.02.53.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Jun 2018 02:53:48 -0700 (PDT) Subject: Re: [PATCH 15/18] rhashtable: use bit_spin_locks to protect hash bucket. To: Herbert Xu , NeilBrown Cc: Thomas Graf , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , "David S. Miller" References: <152782754287.30340.4395718227884933670.stgit@noble> <152782824984.30340.1634082820568216846.stgit@noble> <20180602050322.liesw324q5kawcue@gondor.apana.org.au> From: Eric Dumazet Message-ID: <9bea77df-e7db-677a-31b2-710dc6d956ee@gmail.com> Date: Sat, 2 Jun 2018 05:53:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180602050322.liesw324q5kawcue@gondor.apana.org.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2018 01:03 AM, Herbert Xu wrote: > Yes the concept looks good to me. But I would like to hear from > Eric/Dave as to whether this would be acceptable for existing > network hash tables such as the ones in inet. What about lockdep support ?