Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1693664imm; Sat, 2 Jun 2018 06:49:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK40AK9H5w7wE5rqU9Of9P3RsN+A2iihENDmnJl9ZSmac34WvAg5gvgVPZ9ua5tEYFWHCK/ X-Received: by 2002:a17:902:ac1:: with SMTP id 59-v6mr12912281plp.36.1527947356486; Sat, 02 Jun 2018 06:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527947356; cv=none; d=google.com; s=arc-20160816; b=BnW9C0IHjtOOEuoa4ZKOJFWhPSwGUXYMzXL/Fr9emwwTH/6GBSN6frchioVkG3yej6 96hOk9tNP9CQ929fabxuUcTvUrJYxrc3dMgX27T2JbzMHyVYoBpe53FIdLQfJdoAR+jw F/mea0XOa740TjOW7Q9kuMfYOIiH5tefvdRtsAEQBEzua9xlxCv2RJDkPoIeg+nA80pT ehOenVghUbiOSns/XO5K2/f6nkoXl4UqpFcJtUDvP/bFg3srLeMTR9wQh6B8NCjjnFom Yi6nLX9Ij3gT+WVxeGjG7V+BcHGVO7+kKQ8EYnQ36kks0fTftMHuFBeNs0zOHdFuncpx cEnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature:arc-authentication-results; bh=Ll5SQps4+hAkGH5eo1PpXzejvYTaNs12uMhdpHYgGIE=; b=HqIFZRQ/ibUTjEdzEdtC8GTwRuxsRc4WXOSaURj9tLmpM5nM+rQoE//pTHL+y+3i4G UsTuo4fbC6qSKTUxBp15Nv0S6goeWa7SP/GNhCOat8asDTFkC0mRi1/gcxAUVOACjspf gLY/vZVYlQGKMzI12jFXvu3VtwYYL+9V60adklpefb0V0svAmorBQlA7XIzKdpQnYhKj zE+YH4usa1S8JsxcXa0DvkiDMo56GyvI3xKwlAKAmbC3pW2GsicZS/BEjTLdAI7wt5jp BoyxFooTxNTWjGAo7I0CyxOv6jH58gOzQzRpLiRA/5D7bpMOr8BzWgT8OE6nuvJRjoUB EtZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=sY8LYfC+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t189-v6si34281626pgc.163.2018.06.02.06.49.00; Sat, 02 Jun 2018 06:49:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=sY8LYfC+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750982AbeFBNsd (ORCPT + 99 others); Sat, 2 Jun 2018 09:48:33 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:37076 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbeFBNsa (ORCPT ); Sat, 2 Jun 2018 09:48:30 -0400 Received: by mail-io0-f177.google.com with SMTP id s26-v6so1284305ioj.4 for ; Sat, 02 Jun 2018 06:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Ll5SQps4+hAkGH5eo1PpXzejvYTaNs12uMhdpHYgGIE=; b=sY8LYfC+wibggv9Qg2VMc+AYC1/0iV7qoX1GcyX7g6Rtr/fKB9ycNx3Hkwcemvydsp ZWTt4tO5MvrOqXOlYHFX8WzOummpmspEJE54LdygsQF9rKu/2Ktcz9wLo7uhZQUi3eBN scgipLhTWHUjhGKAWh15u64TLfhCiC7XgTq4XyPo3BMqy4uGRABHtcRNwHq3lvI3jbfw 10jEs47Htk0nN7ZL4vNeThE5tiDTtO6dQabzyXj5TPpfmI5WSfPg4djILRvh/rYDTAjD ZpKmwCmqAjRUfpgbY/v8DYDL1cok4s+ao3q8otCxPcPhDDUZJebNehiL91h5hG89S70l 0kXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Ll5SQps4+hAkGH5eo1PpXzejvYTaNs12uMhdpHYgGIE=; b=EeW2pekkTPk8TNTh1HNAYzio5gaIdyLphgaUcuXtk9duQXyZ50mkL5uEdBWrEWDL0x 4DxSpMbQ/PSMpY0MiA6XI5v3IeOJhxI5/yyWMQMdRe/P9WQCqRWkAbHnF9WM3i54q0Oo Vnb7EL/y8tULmkQXcszhzLQDMIC+TFFb464ITOtcI0sckpmqiryaUckU+D8VNDd+AUnd bWhJ4lTyEP/q5yo3oGJpBzCHaY8L/6ErNxdNohKxuZJ/Lqv2r/Cxhi2GgQZlhD14+hja cNTdyISZGJec3AP+JA63M0/nADELWdnj+Djhyfi+Xlf1BWTPcNCL8q7+8XC3mHAuJ0dp hCsA== X-Gm-Message-State: APt69E3Zz9We04E3fl8T+zowSxdDXdLph87F0xLsCqkYzjciBev5pt2b zarldZjlPwqpRc+csJhxqom6Fw== X-Received: by 2002:a6b:106:: with SMTP id 6-v6mr14462179iob.175.1527947309732; Sat, 02 Jun 2018 06:48:29 -0700 (PDT) Received: from [192.168.1.117] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id f12-v6sm2257621itc.41.2018.06.02.06.48.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Jun 2018 06:48:28 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: INFO: task hung in blk_queue_enter From: Jens Axboe X-Mailer: iPhone Mail (15F79) In-Reply-To: <20180602045353.GA20257@ming.t460p> Date: Sat, 2 Jun 2018 07:48:26 -0600 Cc: Tetsuo Handa , Bart.VanAssche@wdc.com, dvyukov@google.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, jthumshirn@suse.de, alan.christopher.jenkins@gmail.com, syzbot+c4f9cebf9d651f6e54de@syzkaller.appspotmail.com, martin.petersen@oracle.com, dan.j.williams@intel.com, hch@lst.de, oleksandr@natalenko.name, martin@lichtvoll.de, hare@suse.com, syzkaller-bugs@googlegroups.com, ross.zwisler@linux.intel.com, keith.busch@intel.com, linux-ext4@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <0B5A5D8D-BA17-45C2-BCF7-609CDCF1A8DB@kernel.dk> References: <6db16aa3a7c56b6dcca2d10b4e100a780c740081.camel@wdc.com> <201805220652.BFH82351.SMQFFOJOtFOVLH@I-love.SAKURA.ne.jp> <201805222020.FEJ82897.OFtJMFHOVLQOSF@I-love.SAKURA.ne.jp> <25708e84-6f35-04c3-a2e4-6854f0ed9e78@I-love.SAKURA.ne.jp> <20180601234946.GA655@ming.t460p> <95c419d8-7f19-f9c0-a53f-3d381fe93176@kernel.dk> <20180602023622.GA2306@ming.t460p> <20180602045353.GA20257@ming.t460p> To: Ming Lei Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jun 1, 2018, at 10:54 PM, Ming Lei wrote: >=20 >> On Fri, Jun 01, 2018 at 10:31:13PM -0600, Jens Axboe wrote: >> On 6/1/18 8:36 PM, Ming Lei wrote: >>>> clear the bit when we need to, potentially even adding a debug check to= >>>> blk_queue_enter_live() that complains if the ref was not already >>>> elevated. Though that would be expensive, compared to the percpu inc >>>> now. Not saying the bit is necessarily the best way forward, but I do >>>> like it a LOT more than adding an argument to generic_make_request. >>>=20 >>> We may introduce generic_make_request_with_ref() for blk_queue_split(), >>> what do you think of the following patch? >>=20 >> Functionally it'll work as well. >=20 > If you are fine with this one, I'm glad to prepare for a normal one, > so that we can save one precious bio flag, and the total number is > just 13. We=E2=80=99ve never had much issue with bio specific flags, I prefer that ap= proach to a wrapper around generic_make_request().=20