Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1951549imm; Sat, 2 Jun 2018 13:06:02 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJBRhU+8LnHg8U9AfVtN/oAsNCrohxOl91prxmhkkC8fzJ2FNOQlTh/2/o2eAtYLN0n7wUv X-Received: by 2002:a63:9a01:: with SMTP id o1-v6mr6119747pge.439.1527969962669; Sat, 02 Jun 2018 13:06:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527969962; cv=none; d=google.com; s=arc-20160816; b=tAQ1iSyiDW3ZDfOQqk1j0SluTxmZOmjTKmeo04SN2lcfIuC6zDF8nvWeO6VNG5NtGk 9NX5II/ARHdWPty+TX1krJg2hTRLui5uCjY7xFCKMhx46S3c2DRI/KTHxueoq9su3cTa HAB66ZiL5vuhYr+ZrnYkPQaMMiiZa9cXa30QEZqZ6l0kBzWTp5Vh37yRp6ztc8T1BvLh T8N2bDi8l8/d2jSZHAFKorHTuFU6S7y0KLok7I0ZFX5qLR0evHSnGScxef+Ll2aNwby2 XFz4ZSctRZ1T6dYUXWECj5V0QxJ9Qs9l9k9G380w3wG18cKqjr5PF9nlmfFsMLPYFEf7 tj0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature :arc-authentication-results; bh=kPS9MD4jwHsnCWL1oQ9LXdkftU1y/nUHN2JL4SgkDes=; b=VjWJLgN+6jhiBQRSLGvO/YrM9obFtQS1NnWbh2HT3i1TiU2f2fBuJeQEAjrzrUmHR0 vwU1rSrITGkzKFKfo4yJEn+vpakYFVOkYQqzjpe2AvXUFo6V6Y75cFEaV0wmvw9xA/l7 7+gDcFS0cbQ5PLgCH7IoIYJX6m1JmBZcqv7g+VqxRu8pt3gVV8YNYL3b8dQCUixafRob Px4Jc0CZbJe425Iz3XHRaUA87q73OMnrje6dlo7A8Kgxr0W+vYQaRX75A7akN6i3aphA WqO1XEIFsrrymSNsnXPFoNryWuOEsSzZNC8wZwIqUpNVqCTtZLI3XN4e7JC+iISo/kj/ ugQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VGDl+Yz5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s194-v6si18811063pgc.602.2018.06.02.13.05.47; Sat, 02 Jun 2018 13:06:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VGDl+Yz5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbeFBUDG (ORCPT + 99 others); Sat, 2 Jun 2018 16:03:06 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:54003 "EHLO mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbeFBUDF (ORCPT ); Sat, 2 Jun 2018 16:03:05 -0400 Received: by mail-it0-f47.google.com with SMTP id a195-v6so5530672itd.3 for ; Sat, 02 Jun 2018 13:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=kPS9MD4jwHsnCWL1oQ9LXdkftU1y/nUHN2JL4SgkDes=; b=VGDl+Yz5IbYKcolSjTGQTM+lfBHPVEUBBl91kVgA+KU6aJ7LQ00n8Y86PAUAl9EsKe 0wN5WOTzrfBFBaInopclF1r+mXkush8fOhP6nf8IJbcX4Aos5gE1BZDtXkMo8N6HGXnn LKYAf0f+69QdjfV1atM5WVMDrro8EV2tNM1DWcbvL3BQjv78kTuV+s/a7kP7oS40BN6t TkbtRARQIAxMRxeyR0mHPwY8qaqeajVdYJsIqFqwwL7mu4b6bIJs85g22m/pdeGgduif G/rMpVrc3yH1Xa4k1cufvdAMLFL/DtaNFvKDXvuuVI1csSSHSGdwgItfjSU9H8FgTbUN TRMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kPS9MD4jwHsnCWL1oQ9LXdkftU1y/nUHN2JL4SgkDes=; b=O7HEX6PEgUgj1oXZYPoiGHHrK7wxAPEfPzketu50MbT0KcgdQwvu+hmLE4uD+Tskad LRm+4SFodlz7OIJoi2md3TIKeWVJegIIy/Cu67NtHBsYKVNtdKPJV8pm7hVt7g+yr5r4 UUm+bVRzFPFvWrcEvVv1UkRxt2xYyQ4qOQN1EFI6YqiNwejy4WXZw69WjzqsKe5qFabE eRHEbD1VZnmXkPbCvQcEjnKMFn5260W/wK2VOP+reWXYDIscGJopOEiFIWLsvOUeXAlH 6exUHfk9OWXzmnFzLomizyXnBRvEssyJECRX5aVMc0HiBqHtzZjJFxwwxkt3y8rZ5HbS ypYw== X-Gm-Message-State: APt69E0I1GhGS34rOOsv/s/b4uP1eLq5Vg/X1kHuOa1dy/ACHy00GLMx 6+cUjS+8Bvb58XF+5o70PquZ6g== X-Received: by 2002:a24:ac44:: with SMTP id m4-v6mr9372843iti.136.1527969784651; Sat, 02 Jun 2018 13:03:04 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id f201-v6sm2656231itc.44.2018.06.02.13.03.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Jun 2018 13:03:03 -0700 (PDT) Subject: Re: [PATCH] dm-crypt: fix warning in shutdown path To: Kent Overstreet , dm-devel@redhat.com, linux-kernel@vger.kernel.org, snitzer@redhat.com References: <20180602174504.1847-1-kent.overstreet@gmail.com> From: Jens Axboe Message-ID: <974665e7-fa4a-230b-99d8-e773489cc6bc@kernel.dk> Date: Sat, 2 Jun 2018 14:03:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180602174504.1847-1-kent.overstreet@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/18 11:45 AM, Kent Overstreet wrote: > The counter for the number of allocated pages includes pages in the > mempool's reserve, so checking that the number of allocated pages is 0 > needs to happen after we exit the mempool. Looks good, but needs a fixes line. I'll add one. -- Jens Axboe