Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1952708imm; Sat, 2 Jun 2018 13:08:07 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI+VBxnRrZSAwOst6Oc7+9u3BuDys117jyEKAZeB243lMocC1XQ7Td8Ep8PM3gYvRVEkGVo X-Received: by 2002:a63:a513:: with SMTP id n19-v6mr12509937pgf.381.1527970086994; Sat, 02 Jun 2018 13:08:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527970086; cv=none; d=google.com; s=arc-20160816; b=kyf5R0ezCBCjpEjlUeytTlGnvV1LLUEqbq17xZ9fOUzfnRnHVZ37t3W+ksheF8TDVl LhxD1cLDaHvMfOPsoaQHAUs46V1/gHl115DM4fLKv6m6t8mpu2A4OG1vi2WJE1O3nozn +B9GrCmXRhhvfmLs6Ca4nn0zhUcSAvLAZHjbAwMJF26UFBFRysNvjvyykZ5wXOYxXdRM 40wUJDhgXy296Ou9/URhh0F/vSvp7dUw4Klpr+nqgr8IXflUVOoLbIIfFAa8T/zWDpHK sQcikhKV5in98HGrthdUI5o++/wXk5egy1qO6Si4r4EGA85ohIH3ZpOMRwNRv56AILDx s7ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=iR3o/ChKeR8gZc22XBHiPgUh93IuammaCgCEdy8E+zs=; b=kK954rtZHbiKhgvm6CAyhRQkUVNd3dO+V418zSuvX6sE6+31ITzBNaKTGeZN7dyOIG B1I61G8czH4U45hQkWELfMzkT1sm87zvn1Rg8zQkXVffizAL2flqH6CQz2kA1RfL6Z2X RslPuAM1MnMrcYDYu7qcMWCAG77xMOHlIpDvcTJ/xLK/Ndg9LuV5QFuZyay2is44YWV5 IHebwXjT7hgJGw01AF5XV1kFGBzODY7OY/61BQFvtRf61DxKafjsSuISsjF7IWTw3M70 wwon7PwCt4rQQS78RpuW8QgIiaSubMCljQP6VG9pyfcYlFEveCSEr+PX+Yz0HWilLgKV Ynwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8-v6si41884770plp.468.2018.06.02.13.07.51; Sat, 02 Jun 2018 13:08:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbeFBUH3 (ORCPT + 99 others); Sat, 2 Jun 2018 16:07:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55646 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751267AbeFBUH2 (ORCPT ); Sat, 2 Jun 2018 16:07:28 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B93B3401EF04; Sat, 2 Jun 2018 20:07:27 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B08CE10E51AC; Sat, 2 Jun 2018 20:07:24 +0000 (UTC) Date: Sat, 2 Jun 2018 16:07:23 -0400 From: Mike Snitzer To: Jens Axboe , Krzysztof Kozlowski Cc: Kent Overstreet , dm-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: dm-crypt: fix warning in shutdown path Message-ID: <20180602200723.GA23980@redhat.com> References: <20180602174504.1847-1-kent.overstreet@gmail.com> <974665e7-fa4a-230b-99d8-e773489cc6bc@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <974665e7-fa4a-230b-99d8-e773489cc6bc@kernel.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 02 Jun 2018 20:07:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 02 Jun 2018 20:07:27 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'msnitzer@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 02 2018 at 4:03pm -0400, Jens Axboe wrote: > On 6/2/18 11:45 AM, Kent Overstreet wrote: > > The counter for the number of allocated pages includes pages in the > > mempool's reserve, so checking that the number of allocated pages is 0 > > needs to happen after we exit the mempool. > > Looks good, but needs a fixes line. I'll add one. Also needs the subject and header updated to reflect that it fixes the crash (Krzysztof please verify): Reported-by: Krzysztof Kozlowski Acked-by: Mike Snitzer