Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1954751imm; Sat, 2 Jun 2018 13:11:07 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKr6Iwuzi+MwWV5Lxy8o6FLBfQ5apUcUiBvLaOrdZbaLEzsp2Ahdz2guTmI97Fm8SggwTG/ X-Received: by 2002:a65:528c:: with SMTP id y12-v6mr4603970pgp.157.1527970267158; Sat, 02 Jun 2018 13:11:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527970267; cv=none; d=google.com; s=arc-20160816; b=gnXXGZwjL6BJsvSeRmTs0UX+Pu1YFKhJRt/IEFgM3zh+dct011f20qxCdqQyPSb2yp I2QJNyXFtm0NzSUIZoouxU4Wrf7ocXhsHW/En4xcrUccEdMxJYQzabHAg+sJMdI8P/x2 76EHaww5oDlFQscAzRx3VDRykn5pK3JqL4eDfzXscBH4ZLGZL1M/dTzZQIlUXUpy7IXH 3rB53tof2nVN6v7aKa/nzxQmnUXP+anp5AnkxPanTu1i3iGxvmZgkKfSUgfXL8aequSa sk83KnSZCNwlAy4pccelYXeQL7YRkyzcOc8U99GCi/fRqbPfOC5yet8xDQRLOJcptX3N +pzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=3s6LUAJrpVOPfrbuIcJToHlPnDzkmJWY4fKpRGgYwJg=; b=dzQXW7Okf+ifYOcWQUX5WiBqPc+t8PetQWBHq1nVSWg+XHJdA2VcblJQUnvcT+zhf/ RwHxux9WC67GT7c7hmnR6qEnlfAom4JYfqZA3HxrjxkKZ0bJVvbB3rzdZJLH6dssJfyV 5hK2y0TZyCL5AAp3ng8S3+ttGUX2yeB0S7gs5Tr2MoLMSnUBGbi5Hc70e2A2Gitb/3SL 04dw6Lc2/rdUGnQ0GPKIYRuqyOS+SdJaZNIkzAdnt4lpBt2AnM0Wyeb2tjl+JRXosgUg Ep5Vepzgb8NOTfejngKtn65BmVhImckx1Lhq566SyZaGH0hILN+evY9Hm09srH3MPCPr QIbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=RYBwnPoQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m32-v6si42752805pld.438.2018.06.02.13.10.51; Sat, 02 Jun 2018 13:11:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=RYBwnPoQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750740AbeFBUK3 (ORCPT + 99 others); Sat, 2 Jun 2018 16:10:29 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:46999 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbeFBUK2 (ORCPT ); Sat, 2 Jun 2018 16:10:28 -0400 Received: by mail-io0-f174.google.com with SMTP id d22-v6so19029822iof.13 for ; Sat, 02 Jun 2018 13:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3s6LUAJrpVOPfrbuIcJToHlPnDzkmJWY4fKpRGgYwJg=; b=RYBwnPoQHPIITCT9eXeA5Ks60lPztRhzalwybBpoeNSCLjljox1JxgS1B+gQtK1CiA nqxCWX/XylrQo5Of4h5797JTa+eE0zp3LHvWLdu3O7eNkLwFOfo/bosEkQSNTHc+X5SM TeMfHyBFdHNLtqs4e1HU8HoKM/V6e5UNklsVo01tWYiu9rMrsmRtqOVbID0s9HercLq2 F0YqeDhZsYAXQZQYB/pdSK74SDeFfGBSIm7de0HcWGWBVFhDz5WN+q5ftvyys3TtrqdU 1DEhBqj5atkn9PIG1rL7DFS1233K4Bc9hBQ6IFTf/2wgWU81M2qCP8PeaeluzZdZTj9s g8Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3s6LUAJrpVOPfrbuIcJToHlPnDzkmJWY4fKpRGgYwJg=; b=NVbfrfrfmNknU07hKAdS249xOdYqleqkxGRO5jFtcakOUP3DeDPG0cv2JZ+U8KdR+u D94/zrS9W/drEN8ZuE+2jW+nqX1K+FUx/IQh+tzZTakGH/HcIVULz1eZoSmGx3QG4J47 S75vwNCABYrwD7xaz32fdbt+j8fwt6J4C5o9X9A2kTi2vKXZr4bXB8KHyJFtZuYVixIR wJztSxygeJhJf2vyPQBjoySRTQcMiF+EBe78jvoKz0ZJoMPRI1iCmguB22d1TTHSHQQs m9AxEeOYHI3TMofVVtwHYcDVJoEcpwd86gdAymgkX02N95pvlT508/9hKJyin/KIQ529 k3rA== X-Gm-Message-State: APt69E2myFnxflPzfirlsaTxU1yxRXDGB2w634MZ5YfytSsPMr7VGtUd zNXs9BOijGAdiz2/p/K+crbbRmzShZc= X-Received: by 2002:a5e:8c15:: with SMTP id n21-v6mr10944259ioj.217.1527970227026; Sat, 02 Jun 2018 13:10:27 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id x16-v6sm2201595iob.75.2018.06.02.13.10.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Jun 2018 13:10:25 -0700 (PDT) Subject: Re: dm-crypt: fix warning in shutdown path To: Mike Snitzer , Krzysztof Kozlowski Cc: Kent Overstreet , dm-devel@redhat.com, linux-kernel@vger.kernel.org References: <20180602174504.1847-1-kent.overstreet@gmail.com> <974665e7-fa4a-230b-99d8-e773489cc6bc@kernel.dk> <20180602200723.GA23980@redhat.com> From: Jens Axboe Message-ID: Date: Sat, 2 Jun 2018 14:10:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180602200723.GA23980@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/18 2:07 PM, Mike Snitzer wrote: > On Sat, Jun 02 2018 at 4:03pm -0400, > Jens Axboe wrote: > >> On 6/2/18 11:45 AM, Kent Overstreet wrote: >>> The counter for the number of allocated pages includes pages in the >>> mempool's reserve, so checking that the number of allocated pages is 0 >>> needs to happen after we exit the mempool. >> >> Looks good, but needs a fixes line. I'll add one. > > Also needs the subject and header updated to reflect that it fixes the > crash (Krzysztof please verify): > > Reported-by: Krzysztof Kozlowski > Acked-by: Mike Snitzer Indeed, I have added that. Thanks Mike. -- Jens Axboe