Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2450975imm; Sun, 3 Jun 2018 04:04:04 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK9k3ACst7MDcwQ8SHWiSqL4fm3YsT4ot/X2rPcOTJCW7vouqO9xxhDayay2DuRXqiL+Nwu X-Received: by 2002:a62:cf44:: with SMTP id b65-v6mr4626595pfg.80.1528023844899; Sun, 03 Jun 2018 04:04:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528023844; cv=none; d=google.com; s=arc-20160816; b=lrFuj7q1kMJ575+8vCw8aXy2Qqvf7OVxe3wUkoOMAdZxDl5QP87MPgII3f0tQEB2S6 L+oJBYkmgEr8wK0FsuxIEssvKGUBIb0ZqpwTBo9AugRaxRxSA2FEepM296ftvXtR4BmC bNBs0NmB2r7trRlgU3woFGMk9CobF5JThlnJ6ILqixY6swC1RUyMGCvbn+QZ+U7pJA99 fkql51N2WHHkBqmqqAepR/9NxFZCoYJJnozQO6Ey3on/hpPj/t3OnBDMA09WaNec7FG9 sKnOlz2D1tw2MO4b8C8VkcIhT/CbZ8gyrLdoS8qfqZBjYJwFtDu4HGtb+2CQeZKLhrSN SJ8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=Et4bZP0unNRUklUN/mcKL8EN0bVmc1p5z5XbrKbEPxY=; b=MrB18rawVIy4oUbAJo678evv6bsdFPiE/c2uyNOVTvjOJ0wQDqRKa8ofGsCOE2ioeG NCk4aZpAhWPWVLHebLgdKEWmx01DZ4K4udNc5iujWXudNEyh27P9aeM27ccaisvFoEzU nEgEals05FojCuDPmCZcSDyto8vhoHogQueaQYotnTbwyzg2k/Ph9062hJ5o1ptFWW+R hPAL0ne75o9WAf6dkWUIfGIrob40E/KVYw6Xmis2a+lTZIb20UVatza7WTZ+C2J82KMf s8+xVg7JSVHOiYkirDhhGMp2hC48VX0QePBRi9NYytOsFbsDEa19CFIAQgMOfOOAuCFF 8N2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=K0VAE2WD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5-v6si43989775plo.113.2018.06.03.04.03.50; Sun, 03 Jun 2018 04:04:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=K0VAE2WD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751258AbeFCLD1 (ORCPT + 99 others); Sun, 3 Jun 2018 07:03:27 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:43327 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbeFCLDZ (ORCPT ); Sun, 3 Jun 2018 07:03:25 -0400 Received: by mail-pf0-f196.google.com with SMTP id j20-v6so14537456pff.10; Sun, 03 Jun 2018 04:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Et4bZP0unNRUklUN/mcKL8EN0bVmc1p5z5XbrKbEPxY=; b=K0VAE2WDAIIsYZ+HtC3x3q4Tf30QMyEkAwN//93CgBcdZ/tbksrSf1UivhZaVeTWRF 1PeaN09D9DTB/T4Nv/GyLdNLnUjXS218QvBea80bygGfiowcpF9McLgm4eK4XPj/1NZj r1o8BUI7xVRCIOSrBcViKCzr/LreQxEFoF5XMVeBTSItRkUJWHOAiL7A8NMH6KuviJag tx6BKzxNbe5CaaJbjR9+0GA0aUcuW1lthYgCKU8Lgu2Pudh5fT/ulEsEtdflMVsiXhsI qlVJeLra/L4pMM9TXGE64rurFNRn8V9riKI6MAObMlHTwJUJpbUoN03Z0CxG4HXsRg7P fASg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Et4bZP0unNRUklUN/mcKL8EN0bVmc1p5z5XbrKbEPxY=; b=qTSz+OoCcYhCKqsWRneZKKLQEJ4Oe/mpDePogKKO00+m/WOIDoyDf8wlxvFxix+M/+ N7aAKFvaitf76GJLERa4YmPORN/woHDyvCzgzX6irdACG9hnM4Rsp0udq9Ye9SIY0+iH yG1jWXeSlJgFcd4m6DZJdahgzBde53JWsj4CiGZQN6vJBfqzwFZSYkVcA8VTUI9aYPD5 zew4x982NVtvDCB354klShQ4PO4KfKg7UThxkCNMO2zHipE0aSfhWwmLXa5yle4dswwz iR1Y7SwNqU28WJRnvhIPYICocKc/kfDUv7KzU9yQjkHjPpE8/lXX360sVikiiKHVYtfM 09cg== X-Gm-Message-State: ALKqPwfbwUE9uz7KVcRKPReC/RhvXzAi+IVvOyetv/9jydWNcJKmCts4 ceXFrQGzvmDr7XVoq6en+lw= X-Received: by 2002:a62:9056:: with SMTP id a83-v6mr17461564pfe.186.1528023804813; Sun, 03 Jun 2018 04:03:24 -0700 (PDT) Received: from localhost.localdomain ([117.192.158.77]) by smtp.googlemail.com with ESMTPSA id l12-v6sm66368903pgr.82.2018.06.03.04.03.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jun 2018 04:03:24 -0700 (PDT) From: Varsha Rao To: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire , Lukas Bulwahn Cc: Varsha Rao Subject: [PATCH] message: fusion: Remove extra parentheses Date: Sun, 3 Jun 2018 16:33:07 +0530 Message-Id: <20180603110307.4080-1-rvarsha016@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To fix clang warning of extraneous parentheses and check patch issue, remove extra parentheses and replace x == NULL with !x. Following coccinelle script is used to fix it. @disable is_null,paren@ expression e; statement s; @@ if ( - (e==NULL) +!e ) s Signed-off-by: Varsha Rao --- drivers/message/fusion/mptbase.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 51eb1b027963..3fe53b65c5fa 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -335,11 +335,11 @@ static int mpt_remove_dead_ioc_func(void *arg) MPT_ADAPTER *ioc = (MPT_ADAPTER *)arg; struct pci_dev *pdev; - if ((ioc == NULL)) + if (!ioc) return -1; pdev = ioc->pcidev; - if ((pdev == NULL)) + if (!pdev) return -1; pci_stop_and_remove_bus_device_locked(pdev); -- 2.17.0