Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2496758imm; Sun, 3 Jun 2018 05:06:17 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIg30bWeyjiuKY5MraS4PMA71zpwzdprC7nB9gNJ4sOiGx3Ang+8llsMNFaXsAXpzHVGw6r X-Received: by 2002:a63:ac11:: with SMTP id v17-v6mr9864119pge.274.1528027577234; Sun, 03 Jun 2018 05:06:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528027577; cv=none; d=google.com; s=arc-20160816; b=CG+BVy1Y2CkfYUQLUrKXRoip7Nn3Z6y6n7QFVVdLNJ2SSwMhmvKe+ktZlnGEg4jSqa WjQF6bPMWuambI4+xa42rsEhZHaarpVAOg6KbagSpD/pM50j4nfTUy77d+/ezpn23ujp gz+Nr1LITjXE1qpg/NxOhZvzmsM0kpvHS9o+mM+4W0MSxJhf6ygUZdH9pfoOo90Sj8HJ C7RTkjiWzQiZUg4N34ABpMeT33B+POEGUmePZyaNm41pgKFkfsFWa83RhFEdMYknZBlC gTlWudKueRl+bZ31q9wYFMLA0uU9bIGXqg9tjmB9l4yfuHvQ2SIBE0H0gar16rHyELXY UclA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=bKAxB1FkxG3CtI7j4D75a//PwqHRtVcQ+Bq7xqyC07c=; b=wR2dlBgajN9viKKoEJBlJOlpKhyUasHvo8PRznFaaIvU3RZ1rP+wQYy3PDiCFMDbBb zeq1U+6B0PPWdS3BSSz5xuWldE86NMk77Pllw+pGKcJzf3mJoplF/CMcsfFDmcPl0DxV ZQc4IhHe0BasPGzH69YeWloZ7Iood+1QJXTUNWNgOctjBEWH280CQTS7Jrs5Yemst08f jnePAfP/kA3SHemOy1wGxBzyoGGVNVlBTr/dKUq0GkFT2T71vLjTJg/QF+rWzsPoYTkC qCmq16SxAluRouQ54PrUbKsxEaYt7K5pkdsyleYInG/qzq0PVZkgczGx1NWcPqzOn7Ff GmPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ppi/51TV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q75-v6si43949282pfk.268.2018.06.03.05.06.03; Sun, 03 Jun 2018 05:06:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ppi/51TV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751022AbeFCMFO (ORCPT + 99 others); Sun, 3 Jun 2018 08:05:14 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33891 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbeFCMFL (ORCPT ); Sun, 3 Jun 2018 08:05:11 -0400 Received: by mail-wr0-f194.google.com with SMTP id a12-v6so5398662wro.1 for ; Sun, 03 Jun 2018 05:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bKAxB1FkxG3CtI7j4D75a//PwqHRtVcQ+Bq7xqyC07c=; b=ppi/51TVc27WEPx47pHNnaCZ/PNs//xDYOf3S5V/QAHoY6h76nCawz9G5jfX3yneWU u9gZ6Eq41sfh2Geyr4Ce3pdG6uvv8O5oFD/vCwn2INzdgFNQIf2iKINQKmOTGWy8XNV5 rG6F68VkuFxt09n1/QGihKDlEKY3hVMHDgvKc29TITx69zyVjR59PFSVDOB7i5+0MIQH jhyMJRgBX3XScyef1swHHzw1vKfVDOk/Kq1IOsRIWyIAU56vN+/PreKiHYuNtLvY6cbN DySgKnOn4DoxkZhGgzVev7m78WV2KBEbSjOPSUSdcEVc4eFtDiJQUF9qz5quBH1dwvkM p84Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bKAxB1FkxG3CtI7j4D75a//PwqHRtVcQ+Bq7xqyC07c=; b=VKH4rEov04yyh0/hKhWByOUvjXGvl+MI3e4HyPNVcdHySVjTuJrfpgBhmnTrLjME3N elobcIylH5n0cT6bYWKIdSVX869Yqr9wFN4RXA6/e8w+VBJK/6BPgViQiFuqoyMSZYpy v/ywHjUPgYwyCcNCzg3EDGJ2IrOkkIbrTDVQMjitDKANGMhHsoh/EFit+2UYiZFEjzmu 3y63anDBUN8ApibdXBlzdKgvrCZ+fTZx7+hdQKDf+7+1X1/GaQvm0R6HieqxvxIn+74W h5qjN2+/osiHp2hruk7wxQmgY6cLasMA9Ldjk9r0M637Arcn6l9vWjV0G4BIce+rjIf9 z4RQ== X-Gm-Message-State: ALKqPwePQUWkplyD7OltiixRPSZ5IBrB2W+sDY2JTtaGYunJThZfyd/p tT1XhZAZVmy2omluy2aZW3M= X-Received: by 2002:adf:8506:: with SMTP id 6-v6mr14106425wrh.137.1528027510751; Sun, 03 Jun 2018 05:05:10 -0700 (PDT) Received: from localhost.localdomain (host86-175-51-38.range86-175.btcentralplus.com. [86.175.51.38]) by smtp.gmail.com with ESMTPSA id j21-v6sm5142448wme.36.2018.06.03.05.05.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jun 2018 05:05:10 -0700 (PDT) From: John Whitmore To: gregkh@linuxfoundation.org Cc: kstewart@linuxfoundation.org, colin.king@canonical.com, pombredanne@nexb.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Whitmore Subject: [PATCH v5 7/8] staging: rtl8192e: Optimise Comparison to NULL tests - Coding Style Date: Sun, 3 Jun 2018 13:04:12 +0100 Message-Id: <20180603120413.13042-8-johnfwhitmore@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180603120413.13042-1-johnfwhitmore@gmail.com> References: <20180603120413.13042-1-johnfwhitmore@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change comparison to NULL to better adhere to coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 7ea516609d4c..9cca4a8f1cf5 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c @@ -520,7 +520,7 @@ void HTConstructCapabilityElement(struct ieee80211_device *ieee, u8 *posHTCap, u PHT_CAPABILITY_ELE pCapELE = NULL; //u8 bIsDeclareMCS13; - if ((posHTCap == NULL) || (pHT == NULL)) { + if (!posHTCap || !pHT) { IEEE80211_DEBUG(IEEE80211_DL_ERR, "posHTCap or pHTInfo can't be null in HTConstructCapabilityElement()\n"); return; } @@ -624,7 +624,7 @@ void HTConstructInfoElement(struct ieee80211_device *ieee, u8 *posHTInfo, u8 *le PRT_HIGH_THROUGHPUT pHT = ieee->pHTInfo; PHT_INFORMATION_ELE pHTInfoEle = (PHT_INFORMATION_ELE)posHTInfo; - if ((posHTInfo == NULL) || (pHTInfoEle == NULL)) { + if (!posHTInfo || !pHTInfoEle) { IEEE80211_DEBUG(IEEE80211_DL_ERR, "posHTInfo or pHTInfoEle can't be null in HTConstructInfoElement()\n"); return; } @@ -687,7 +687,7 @@ void HTConstructInfoElement(struct ieee80211_device *ieee, u8 *posHTInfo, u8 *le * *****************************************************************************************************************/ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg, u8 *len) { - if (posRT2RTAgg == NULL) { + if (!posRT2RTAgg) { IEEE80211_DEBUG(IEEE80211_DL_ERR, "posRT2RTAgg can't be null in HTConstructRT2RTAggElement()\n"); return; } @@ -737,7 +737,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS) { u8 i; - if (pOperateMCS == NULL) { + if (!pOperateMCS) { IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in HT_PickMCSRate()\n"); return false; } @@ -799,7 +799,7 @@ u8 HTGetHighestMCSRate(struct ieee80211_device *ieee, u8 *pMCSRateSet, u8 *pMCSF u8 mcsRate = 0; u8 availableMcsRate[16]; - if (pMCSRateSet == NULL || pMCSFilter == NULL) { + if (!pMCSRateSet || !pMCSFilter) { IEEE80211_DEBUG(IEEE80211_DL_ERR, "pMCSRateSet or pMCSFilter can't be null in HTGetHighestMCSRate()\n"); return false; } -- 2.17.0