Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2619185imm; Sun, 3 Jun 2018 07:43:24 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI4PuvebKFhIE24d4Yvfb3Ei97vlULEtpPHYtU6jWOSE3PjUw+fevbkfR5SAsxnktJAGLko X-Received: by 2002:a62:d8c5:: with SMTP id e188-v6mr10121566pfg.151.1528037004676; Sun, 03 Jun 2018 07:43:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528037004; cv=none; d=google.com; s=arc-20160816; b=yrdUQUiKOcdYVTiLVK/KHcw3Xb0xSaMGiU5lK9NnKmkgG7hvRoenj5Jc7yyjhoNKLP PWrKzAOxA/Uolu3y7RXY0S6ehMg5u5Ew2hUE7YdbOOePexPSZeg8dOLnIzYK7qrG/fVM yqzkz7BWfLNoStJjWsRiIKwy5nmn9aJ9jZwh489m6vg3Nc3MjUhxfF/QlGIsfTsYa8By F8RVyXBTTU1WZRpLKkiFOvqH25u1PrGjxWcO36MQN5wIDrs6ytDfGzJ0uanPqNKtBt1f VFB3aL+sATC+yvHjPnl+fcMsWR4Ake3ElanW9eYPI8pymlu/BwoxMorzDdE7TTPsVx1c Leow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=/wEgiN9nOqf7HHaDzUSEDSGcL3Wdrr1KqzO+uxQnDVU=; b=ubz+CirD8gh89IASzhMovotFu43pi0BUsHIgBldA1lEE7VOO40ckaIkZ2fiG6Cs/ja BtJEy3QCoe7CuITsGGJaBaFmgNNQcYwdeH7pnTvSKzExQBCV1/d+4Y+6VffixPh2/1mc +lsm6VbY3vhcpl+XHn2zaI31D20ofoua849cJSj9c0jS7xJqL2gP3ihsMpThGEWHuBOA JwlZeK7SddRbRpvhllVZchfZsVqNfaBrqswVjNH4dwFiWz+/gVJOUrZU2WjMG586w3bd wIQYWcp8EZ01IS7QyJ+FxY+nTOmMXO2QNCx/d8LrMMjfat6tprzPG2wBzhmdQNlRrmXl CmVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w189-v6si21849115pgb.431.2018.06.03.07.43.10; Sun, 03 Jun 2018 07:43:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751547AbeFCOml (ORCPT + 99 others); Sun, 3 Jun 2018 10:42:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35580 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbeFCOmk (ORCPT ); Sun, 3 Jun 2018 10:42:40 -0400 Received: from localhost (unknown [96.70.232.49]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2E063100083F3; Sun, 3 Jun 2018 07:42:37 -0700 (PDT) Date: Sun, 03 Jun 2018 10:42:36 -0400 (EDT) Message-Id: <20180603.104236.1164095896276916209.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH net-next] net/ncsi: Avoid GFP_KERNEL in response handler From: David Miller In-Reply-To: <20180531070254.28878-1-sam@mendozajonas.com> References: <20180531070254.28878-1-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 03 Jun 2018 07:42:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Mendoza-Jonas Date: Thu, 31 May 2018 17:02:54 +1000 > ncsi_rsp_handler_gc() allocates the filter arrays using GFP_KERNEL in > softirq context, causing the below backtrace. This allocation is only a > few dozen bytes during probing so allocate with GFP_ATOMIC instead. ... > Signed-off-by: Samuel Mendoza-Jonas Applied with Fixes: tag added, thanks.