Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3006329imm; Sun, 3 Jun 2018 17:15:21 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ/vwUCgXzKcq1BP0Obwlvnhq41mXDg9xnTiTgsHFu2wX8gO1KgO6shWNAEKe7qe/XjFTbZ X-Received: by 2002:a63:7741:: with SMTP id s62-v6mr15766080pgc.103.1528071321861; Sun, 03 Jun 2018 17:15:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528071321; cv=none; d=google.com; s=arc-20160816; b=HBwjfIg+/dulwGIvmdfU3ZtwOLFaQsrrWuENKSAZPOnWhHL4xGLOu6r6cFwRr4QQlo VNPQseBaU/PqhKlcrvxDMy+hhEgpiw3g8HewQnCtiDW6Bmxkk4Lj6w+2Ct3+He5d0zGj NNDJy9YwG1Z7sqEwczd+0Zh7FlvkcvWQc9GUVNSCnSMjrI2r4MaBFTdwIvSxBMYHl5fu KDkZ0ROcmYhYRIghJTYPktF0tuyk1K2r+CLeQD8BC0xdCTm8om48OjtEusG740E2tN/C 8NR7F748aG3whS0bFlr3rocoAhw9VF4bdDTC2Qhz7nf6WQQNhZFa//Tjtk8HHAUWD8nx cixQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:references :in-reply-to:subject:cc:date:to:from:arc-authentication-results; bh=pEV1I6S3dp3QhnKwOBSsZGoSrx3Y82xRKToScsm4mlg=; b=JvfJeOLXs9tu4lReRTV0uH76K9SQrgP+brwjYyIkfC5hSnhu+M2JpM7QpZ2PBXhAb3 IR4D7N2s5QNNSm5FD2+CSydBE52oZUFzJYtwfxsPP+cHI/CQZufUTdcIsUfQbmX+Kl94 EyDVE6Apvq2O+OuYy4MN9DDFt6G1Ph0GpQxfQg/IbHQyxviwrJcYCdDhJjxfzgPi/FTV pXL6dhLwDEsderzfngP6AE7MFt9IFRV4rxe5rV+Y9l8l4RlpJPF6m6AwS7ifT5d1gRgS qijqBhjdkQyOoPxdS4Rzmxzb211hPRTnCiQtOl+y3IPBs2hZKOJEf0yH1RaTipJpBO5K XRUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c125-v6si4622189pga.413.2018.06.03.17.15.06; Sun, 03 Jun 2018 17:15:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751638AbeFDAOm (ORCPT + 99 others); Sun, 3 Jun 2018 20:14:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:39254 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbeFDAOl (ORCPT ); Sun, 3 Jun 2018 20:14:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0C704AEA4; Mon, 4 Jun 2018 00:14:40 +0000 (UTC) From: NeilBrown To: Abdun Nihaal , gregkh@linuxfoundation.org Date: Mon, 04 Jun 2018 10:13:58 +1000 Cc: matthias.bgg@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Abdun Nihaal Subject: Re: [PATCH 0/7] staging: mt7621-pci: Fix coding style issues In-Reply-To: References: Message-ID: <877enfqugp.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, Jun 03 2018, Abdun Nihaal wrote: > This patchset fixes the following set of coding style=20 > issues found using checkpatch. > > ERROR: space prohibited after that open parenthesis '(' > ERROR: trailing whitespace > ERROR: space required before the open parenthesis '(' > ERROR: space required after that ',' (ctx:VxV) > ERROR: spaces required around that '=3D' (ctx:VxW) > ERROR: spaces required around that '=3D=3D' (ctx:WxV) > ERROR: that open brace { should be on the previous line Hi, thanks for contributing these, how ever some of these issues have already been address (not all). I think you must be working from an old try. When submitting patches to drives/staging, they should be based on the staging-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Also, I'd suggest leaving linux-arm-kernel and linux-mediatek off the cc list. They are unlikely to be interested until the driver is ready to be moved out of drivers/staging. Thanks, NeilBrown > > Abdun Nihaal (7): > staging: mt7621-pci: Remove space after open parenthesis > staging: mt7621-pci: remove trailing whitespace > staging: mt7621-pci: add space before open parenthesis > staging: mt7621-pci: add space after comma symbol > staging: mt7621-pci: add spaces around equal symbol > staging: mt7621-pci: add space after '=3D=3D' symbol > staging: mt7621-pci: fix coding style error > > drivers/staging/mt7621-pci/pci-mt7621.c | 114 ++++++++++++------------ > 1 file changed, 56 insertions(+), 58 deletions(-) > > --=20 > 2.17.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlsUhEYACgkQOeye3VZi gbmqeQ//WA32pYuVChludSOQq2pmdfEHZLVBJoxzDx2ew0IVjjXOtSCx3dEig7qI pcgiQd9ER1zhBBt/9Y4Fxu4iWA20CA8sQcQJqbmfMIz1rf9yJOBag0hilnYH8SgU ccl9hmi+H1F4KPjB53zxFle5okyfiQPlUPzcdGecLg68MPjsNpQdr/XW2LgFwaMV J4PqwkjiG9tVWzhHYpNJIkHuW6tk5mgEHkiZFQBTUWW2IX4f0O5Spbju5d1Obc3e GBjyXap4xcKMI9zzbYPQet6VAb6Nm5XxuORJ5TZM5KzxTwDv3sJ9QYazynocn1zM h1vke1vueXrFo0RlELfWTn5kuwjVOWEdnzlNZnboKTOVV3F0xtR/QdDZuL9mJzbJ eds9Jpi2hOtHwTD2jZI1oz10kChWcW9k03kDOWmLUzRLnGGdqofhR8hE0xEj/OcF kedW54bI11Ol2xRxaOYTKGViu0wEKYH9devxw4qgH+u2mLHsCYNoZWzUnF8RLiIC k4bI4oKxTOsTiBJk9ZmGSU325wORyydScZQo++lJpU20gteUVXWisMsbcXJAW6y4 1c3VzajAuZH/ipMR4WEiMZX2T9ur9u0YxnQtGnxgpsXkqMeDvqEeQdC/JyuQmHT8 P9SmOV+eTkItLdq7nt13rAVmj2qgWnlkRQLFwMdZe0c6Zu/8sRw= =ysyz -----END PGP SIGNATURE----- --=-=-=--