Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3242576imm; Sun, 3 Jun 2018 23:26:28 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ8GCeermrfUXZRtRbbRf0cP9A9hlvDbjWr5nligOkG0oRtqMrgANtgvHufr99snJb0nOxT X-Received: by 2002:a62:a38d:: with SMTP id q13-v6mr20229868pfl.49.1528093588102; Sun, 03 Jun 2018 23:26:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528093588; cv=none; d=google.com; s=arc-20160816; b=iOHMQ9NDUWsOKN+VrS2tUlx+6CwOxjFmCyAY3xounYkFyipERG/Hojv/oTJ6+qVa4C bDqyjoOou0pWGKo5loc3ly/U4rM3e+hT2HsdsMYvVBXyHuJyLw1NMyZ+rYV4FtIGLkkM /l2ADI4nlpdEdbdQPJwWWUS1EH1aRwbB52GDAC7JE4njGYTwRU4Houd7fVX/DPPXh8pW yfTcwNzq3wR32voLANO9qdMeFCg6/oKsBi8c86tnmo2kRTlYeppFYg23cOa3hw88bi6V u8KccqNvwz+u7c8HgjkYjIiLG88mn2DObS09KVZ5HfPKHC4o10zvKCwOPFV75Wk0YzGK x24g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=cq1ZdOk1oC4jjlUiaMyzdp8B1X/VBe0YKC8+dLn9kWE=; b=DmsajdzJO+A8GbfEtO8CiV10wbLTCJ1t5Hp9A3x8tFHqMhi7vCaxdIFniERj9Gz7T1 0hMDifgPObs8d0tmDJ3Lb6x86bFyMzFqzwGB7tpZWOA9kjSNveC0ROscLDzzjM0PX2Vn 52R5l/Tkwo+hHF+zmLb/+5n2JSi2E+IqHWOUioJvFR5CnrvFmFNim+gHXJdKaCedKvFc Nd/MLgD0p0KFt1cYpf9qmopbxZWPeLrgFpU+4uf7ZXD468p9Saj1dmsfOQLBKU2Od+/W cF9voTgOtyF0UE5tdKGne4KSgYV3S0nBk6fQZF3Qk77HnzTQ6mhSvrfv3aBt34AarPax H0kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ee2OwpPo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13-v6si2882840pgo.121.2018.06.03.23.26.11; Sun, 03 Jun 2018 23:26:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ee2OwpPo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbeFDGZq (ORCPT + 99 others); Mon, 4 Jun 2018 02:25:46 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:43314 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbeFDGZp (ORCPT ); Mon, 4 Jun 2018 02:25:45 -0400 Received: by mail-lf0-f65.google.com with SMTP id n15-v6so6023605lfn.10 for ; Sun, 03 Jun 2018 23:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cq1ZdOk1oC4jjlUiaMyzdp8B1X/VBe0YKC8+dLn9kWE=; b=ee2OwpPoej18Sr335g4UGp+HpVRVz/WOqTqnwqOm3OXTLSe/Z+M+qWAWplAFsliEIR yI79UxBnjl9Ky3sH0BXC8S/vjRsIS35fLE82HTu1KFm/ZdWzY1R2a4Gfu83VSRqv+eB+ VXZyBR4dYmZKEJRLrvJLw/wLsIIajOlQmXK/XjJOoyX4RY03R2F0HQf+tdcKa/SJKMNx nJwlsqSUiwBVj75HI1UNp0YLxgazJ9feuqBtouP3Bj0PHEF6Cc3sCJL5zXgIj+tVp8il mXaUefeCMj39ut3pE1dT66XCpalnjkP0td+XT3QQ2KxJRCthgJOVdL/JLtNAuoFuvRXL 1rFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cq1ZdOk1oC4jjlUiaMyzdp8B1X/VBe0YKC8+dLn9kWE=; b=uefLjI/sD0R6sEgBDKK5F4nyCmG6CWdp99+R/SPmdQ/IOeN32FeBI3AV4aNUXEQXjb Q0X7kD0tzN5FbwL9xCo8uFKeoZGOMqvVagHzZfoYk3X4dXxYJDbfZe5A0sCuujZ+f8S3 NiTgyQVrnMyyON2H/nQ0AQl5rZSKTXvo93kZtsP1ae0Y/ryZ76fMr3X/pnP8NhylBrC1 1GDX8g/CXFhCwul+1rn0dV5HUj53wk7uleZctSSs7hzKkIloiYKEHqM9k+1lUGCPdc63 A+D7MrepfT6ImSDFHinkyuZYIcvkEAq+ydS+26NfIb+kA5VnXltIlmjMHjh8Br+CYJRC XpUQ== X-Gm-Message-State: ALKqPwcHziJBeRspJJjdjVRfSc7LdCtELHRsxYrDP3qux8fMpVUGeQ4h 9dLHyvOYrdtjN0cYt749AMUrCQBesgu1Lm//SCQ= X-Received: by 2002:a19:1714:: with SMTP id n20-v6mr11670974lfi.54.1528093544397; Sun, 03 Jun 2018 23:25:44 -0700 (PDT) MIME-Version: 1.0 References: <1527940734-35161-1-git-send-email-ufo19890607@gmail.com> <1527940734-35161-2-git-send-email-ufo19890607@gmail.com> <20180603124941.GA29497@rapoport-lnx> <20180604045812.GA15196@rapoport-lnx> In-Reply-To: <20180604045812.GA15196@rapoport-lnx> From: =?UTF-8?B?56a56Iif6ZSu?= Date: Mon, 4 Jun 2018 14:25:31 +0800 Message-ID: Subject: Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header To: rppt@linux.vnet.ibm.com Cc: akpm@linux-foundation.org, mhocko@suse.com, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wind Yu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike > My question was why do you call to alloc_constrained in the dump_header() >function rather than pass the constraint that was detected a bit earlier to >that function? Ok, I will add a new parameter in the dump_header. Thank you.