Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3295025imm; Mon, 4 Jun 2018 00:41:44 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL54MXaEM0UO2yDAP8VRBENNISrjHXD29UvRj1CnwiG9yxH+wRZfHmLIEN13IZ5u7uUZPub X-Received: by 2002:a17:902:4101:: with SMTP id e1-v6mr20712472pld.205.1528098104252; Mon, 04 Jun 2018 00:41:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528098104; cv=none; d=google.com; s=arc-20160816; b=dU407zODUtqlg0hwtuYjYe68t2HPJnr+9HhdzNyfEjIHKKDGH1iJax3D4dvyvwmmHL Kud3ADHXcGRlBvhsAAN+eC3gb18fZP8R6XDbGpfJnJqXXUQtBJObJHc6z0v1Y/WwQAgo GQKEQR/bWA9AKaQGOs64gy2lZworCR0HyQPSLiJZG/gmA6dZ3GYV895QqxitkshQdO/S 4PD8BVpkRXHpSnin/QPBMMvfla5ys0AChfYRDwFu/9LxVGQ8clWXDdoOplRqs5o8dnR7 GGh7VFgykoFHcApHDB/ypUT37R/mE84130jHQ6AJ2j9/T2iz9ZWG2UUyxAw38fiQNa9X qgrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=ZGaBntD0AWE4lR+1Z9r3SUA4Uy785wfwZjTBUVVDcqY=; b=AD1lZVM0Wu4SGLhGRLSGxOf+8sIULlqAQoHnz0MDR6pdEzjL5w9DG3a87GmK0dmglJ x+P5BpvUzWBbQZk3XWJc2/1ePCCZPPQNbXDe320Z/nXcyEA3j8E2kq98M2j7m9w63Ga/ WP9WO49RmzWNKp1q9NbJ6IbS4lsttxgLVRPE8Gy6BEz1J9rZYqqvb3WxI7dKxE96IoKs UYVfmKCMUTJuZj/IdQ0FjH8USofYp5nBHIfeNJyJB2nJThOyeoK3T/e1uquM7Avc1zYL /kA+cv7XHFTvg4Jv1Vt/wozIj/N5C3u1gWSBMH3gdMWwL8q9ThOGbu9xIO6MBmhfsHe1 CXqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=YG9Hu2iO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4-v6si35055156plp.357.2018.06.04.00.41.30; Mon, 04 Jun 2018 00:41:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=YG9Hu2iO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbeFDHjy (ORCPT + 99 others); Mon, 4 Jun 2018 03:39:54 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:45700 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbeFDHjv (ORCPT ); Mon, 4 Jun 2018 03:39:51 -0400 Received: by mail-vk0-f68.google.com with SMTP id n134-v6so19308179vke.12; Mon, 04 Jun 2018 00:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ZGaBntD0AWE4lR+1Z9r3SUA4Uy785wfwZjTBUVVDcqY=; b=YG9Hu2iOXP5mfp+Hzvo3Dp10yUcEAfRfrRm7sKEU3JS5m2C4HmiLIg6DaHJ/Zsnzk8 PenJNuWIeoqKwKz2lu6dGeyT438Ccci+JjmH85y7mVrJQHfHxzXQaL7z8vHo8Fr9Derd Op91HxMciqRdwfpmrv4PJjafixg4hERO5HqeKacsqEbPW/46ns7omz56IN11WnmpM6n1 HaGnL6cfy5RKs8F3OxFUuc4D5ftI+VXkMC01czrumSMtN7SKvuepQxS3d126T9NVX1lv CrXCaFraQ1/OZvmytTzYwcVx2nQRyKZHXcEc9Bz5r+NKt+On74fQ7aJS6MXIGe/9UW4E +pnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ZGaBntD0AWE4lR+1Z9r3SUA4Uy785wfwZjTBUVVDcqY=; b=YlSY1nu9we9eyCy/FV4jw35ANVBNuKfi56f26qh8xSJhkDceYp84DT/0LVEJy3t4eo PgOcSlLhuYZZZ5Bh/WW+vUsIkI4J7rGRn7v+5I8O8TMG1Z+KlpdJ60zZuxHzZUT/zcuf ov2vtHqRjbfbuvuED/cAOV2Mj1YSNDYlHnD/1vfnA+wtPCfarU3eupU5judBJuFSvjqs xrJGe87ss06q2ZySR7yrKdEU8hXQUP/HJdzHVCdNjdUizKiPMZa6fle843d8BgBvaBZS Mb8bi7JysmHuemtBkB4Pc+PrQL11M25jGxXvtNdzx7THZOk1mDwvrlmzcNWZhs40hjjW 0JOg== X-Gm-Message-State: APt69E2uQo/L1DxNPF37JP4eHTpzkVVvTc0BQ40AuISdqbQq20xRdZme wsHcHHZpsl5oknquJpKpVngTh3yv1ZbZhCdMX28= X-Received: by 2002:a1f:b508:: with SMTP id e8-v6mr12173689vkf.125.1528097990167; Mon, 04 Jun 2018 00:39:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:8596:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 00:39:49 -0700 (PDT) In-Reply-To: <20180602101155.26375-6-marek.vasut+renesas@gmail.com> References: <20180602101155.26375-1-marek.vasut+renesas@gmail.com> <20180602101155.26375-6-marek.vasut+renesas@gmail.com> From: Geert Uytterhoeven Date: Mon, 4 Jun 2018 09:39:49 +0200 X-Google-Sender-Auth: bTxIiBsnY1iz40rsbUlLxCu5A6A Message-ID: Subject: Re: [PATCH v3 06/10] mfd: da9063: Add custom regmap for DA9063L To: Marek Vasut , Steve Twiss Cc: Linux Kernel Mailing List , Marek Vasut , Geert Uytterhoeven , Lee Jones , Mark Brown , Wolfram Sang , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, Steve, On Sat, Jun 2, 2018 at 12:11 PM, Marek Vasut wrote: > While the datasheet for DA9063L (2v1, 23-Mar-2017) lists the RTC register > block, the DA9063L does not have an RTC. Add custom regmap for DA9063L to > prevent access into that register block. > > Signed-off-by: Marek Vasut Thanks for your patch! > --- a/drivers/mfd/da9063-i2c.c > +++ b/drivers/mfd/da9063-i2c.c > @@ -254,6 +341,10 @@ static int da9063_i2c_probe(struct i2c_client *i2c, Note that the line above doesn't check da9063->type, but da9063->variant_code... > da9063_regmap_config.rd_table = &da9063_ad_readable_table; > da9063_regmap_config.wr_table = &da9063_ad_writeable_table; > da9063_regmap_config.volatile_table = &da9063_ad_volatile_table; > + } else if (da9063->type == PMIC_TYPE_DA9063L) { ... so this may be slightly confusing. > + da9063_regmap_config.rd_table = &da9063l_bb_readable_table; > + da9063_regmap_config.wr_table = &da9063l_bb_writeable_table; > + da9063_regmap_config.volatile_table = &da9063l_bb_volatile_table; > } else { > da9063_regmap_config.rd_table = &da9063_bb_readable_table; > da9063_regmap_config.wr_table = &da9063_bb_writeable_table; However, da9063->variant_code doesn't seem to have been filled in at this point yet (the call to da9063_device_init() doing so is below, at the end of the probe function!), so commit 9cb42e2a8ed06e91 ("mfd: da9063: Add support for AD silicon variant") never actually handled the AD silicon variant correctly? Or am I missing something? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds