Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Message-ID: <7d20be40-4c15-4e15-a4d0-cd2efda6d701@default>
Date:   Mon, 4 Jun 2018 08:16:51 +0000 (UTC)
From:   Zhenzhong Duan <zhenzhong.duan@oracle.com>
To:     Linux-Kernel <linux-kernel@vger.kernel.org>
Cc:     <mingo@redhat.com>, <tglx@linutronix.de>,
        Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
        <bp@alien8.de>, <hpa@zytor.com>
Subject: [PATCH] x86/microcode/intel: Ensure new microcode processor flags
 match with cpu's pf
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Intel spec says: 'The processor flags in the 48-byte header and the
processor flags field associated with the extended processor signature
structures may have multiple bits set.'

Make sure processor flags of the new microcode intersect with current
cpu's. Comparing with old microcode's pf can't guarantee this.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
 arch/x86/kernel/cpu/microcode/intel.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/mi=
crocode/intel.c
index 461e315..54f4014 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -371,12 +371,10 @@ static int microcode_sanity_check(void *mc, int print=
_err)
 =09=09=09=09goto next;
=20
 =09=09} else {
-=09=09=09struct microcode_header_intel *phdr =3D &patch->hdr;
-
 =09=09=09if (!has_newer_microcode(data,
-=09=09=09=09=09=09 phdr->sig,
-=09=09=09=09=09=09 phdr->pf,
-=09=09=09=09=09=09 phdr->rev))
+=09=09=09=09=09=09 uci->cpu_sig.sig,
+=09=09=09=09=09=09 uci->cpu_sig.pf,
+=09=09=09=09=09=09 patch->hdr.rev))
 =09=09=09=09goto next;
 =09=09}
=20
--=20
1.7.3