Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3343248imm; Mon, 4 Jun 2018 01:48:31 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLXabHhm43B5y2U8VDlX54PwX/XuGiX2jeiyekySjMWjO5zdHCmwBeMIa95VHHlJpO37xrI X-Received: by 2002:a63:4c8:: with SMTP id 191-v6mr16553561pge.129.1528102111251; Mon, 04 Jun 2018 01:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528102111; cv=none; d=google.com; s=arc-20160816; b=kKqdofvM0v3/PAh0wnnwNMPesG81xF1o4/UzSbzNJjW4hihHqIoVD/gfABVv/t3jXr z3XDIyRLUDfLYEZkyxyOvaPU6jANXV0l1AyRFt3v1GEpE8SlgQqsUl1nT3C4ud1noKq8 +ruyK1aAaB+qIfVMkQD7c05V2sIibng4XyTwXTe3wGItFxrI4pCSGRMrkRbwhVE0W8ez IzPAehKjfq47lAX6wxQr1ZvkcROeudkgcs0eit/DbpKru5q9Z5kG/kHKAusdau38Fkig hbj1AcUzjguhYSzZnutDZCDq/IxsRhl1F/9o4zGJB2zCVHwfKy1BApKNTTNoZHUkgVad hZ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=1+5fF/WhH96M+kl1c8GUEWkslgv3YwWJ2DnMRJriz9I=; b=BLZ0XZrPcKyw1rmUcYpHjBzYpVqwBzxiHmIRHhHARO8D1gK6s2L3ZxKHhmkYfZxPf3 +9J4WPfDS2Orj32riW+Yvk09jPET3BhqGn0ooPzou3bCbLPvzGIxmtc+MtUHG040skL9 aK3b+sCplthAMyo/GSkFqpsit2uDZCxXRI00TazbCWVvepb+nbzM6M1+Z2U/hvOyoqvp ufzG7zDobc8VbJ0vmp6Z/rg5Qk2IrIlWEd/AqE9SbjM4KocbHSy79u8CaakdrLwY/lHY fnQK+dJCv/26Je/PFx5BsRjAepsFgHUel7OIN80FwVSuuQmJl/DqTmBkcY9slulg83PT xfvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Z2pnZBnj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a19-v6si10522611pfo.10.2018.06.04.01.48.16; Mon, 04 Jun 2018 01:48:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Z2pnZBnj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbeFDIrm (ORCPT + 99 others); Mon, 4 Jun 2018 04:47:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59932 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbeFDIrk (ORCPT ); Mon, 4 Jun 2018 04:47:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1+5fF/WhH96M+kl1c8GUEWkslgv3YwWJ2DnMRJriz9I=; b=Z2pnZBnj8DzcarGjmuV/Sz5av vf40wwycdq8AWmFCwmHcluD1s+Kuucib+K4+3jtIbRJOqjh50BFZzK4Fop/rnqqJ/iGPBsNroHWbk z/Rv71pyQ5hPrsMwixmWGGs1Ig5tC1rF/nqJpFfGhN53JHm2si836KV+6mMdX+PIbbsLVyLJ/vbms fuzasS7wV3BWYNLCm4jmmz724BeNJZb2/AkRQMfe70khA4yf0GgJJMa4dkMVNqv158u5ecduVkZiE G234ZhLDt104vFf5w/l3ow7jLR5xXJE9JdG6ERCdH6xZtqUmuBB6WrJOu4YlGYoPFTwcNJYklzGN2 mIXjZBDFw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fPl9P-00070z-Ut; Mon, 04 Jun 2018 08:47:39 +0000 Date: Mon, 4 Jun 2018 01:47:39 -0700 From: Christoph Hellwig To: Miklos Szeredi Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/39] vfs: optionally don't account file in nr_files Message-ID: <20180604084739.GD11333@infradead.org> References: <20180529144339.16538-1-mszeredi@redhat.com> <20180529144339.16538-6-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180529144339.16538-6-mszeredi@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 04:43:05PM +0200, Miklos Szeredi wrote: > Stacking file operations in overlay will store an extra open file for each > overlay file opened. > > The overhead is just that of "struct file" which is about 256bytes, because > overlay already pins an extra dentry and inode when the file is open, which > add up to a much larger overhead. But that overhead is exactly what nr_files accounts for, so this looks bogus to me.