Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3350413imm; Mon, 4 Jun 2018 01:58:55 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJdLPzzg3IA6tyQW2vRgMVOpz/1an8bvlR+R1YIihi6VutRiOUMDGOogc3WuYcLIIFBRxqs X-Received: by 2002:a62:9385:: with SMTP id r5-v6mr3996957pfk.59.1528102735017; Mon, 04 Jun 2018 01:58:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528102734; cv=none; d=google.com; s=arc-20160816; b=hhrgP2f5lVoO+umIrRdUiYjB5XfspsPB8XsOFjMb+kjwKrvBkGA62yq9I9JZSYT6jz GC/hQsYShobhoctz0d4ZzLvZpLUX3d2USZBmSAcRacyMOgLJ8i2Zp3+mBOXRXAq8Zs9W gpIH0kXt1Wvc6AjPLP1MoPGw5DHBchDaZjNef3D8Hh9Y17QlTEq/Th5t0proYd8g3Rdk gId4CDYz/imXG/NTtpJ3PiSkeinr17sE4oMVojesGBQ7wBynFSKiI3qPd5TM+H8huEIN ZuX/YDjTL5iMtbZnZuUdvcHJIKM2aB9f97mGgabafTHr0XxoHPjbHeIho8jsxU04sPOW UYgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=jhT8TihDwlH5NSg8rT7FoOnj37aS9muRlhGbmmv3Tjw=; b=mxqd7GTDdR12AgFKpdxjXiqTUPmeFoNknCKjATOfIk3VztBiymqZwBYlP7zjap9ew/ E61PQ56gv0XrIJQaQUl5lSA9reJlmfPCo+W0GEasfHDotKOtWbUziMQArk830FDZxVqv /HXSvXOvg3jdNCqvtJQZd4ouV9RaV5xFFI1ukmyacRKBOexv1QSV4Haum81UPb3NeHvy q69zeGlklhX21ykU9nACHS8CqDAPEMMB26fSShG/yqhauDxCvSbgJsAGfzlXL7I5XhU9 YKVUH12sE1Dekij2oyXAMGMlIeh2A1l7UPqheBlfmOs0AFM3kMyUbCF/i5rNQpj8M3B8 0Jxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Nrr3Fj0w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18-v6si46296734plp.159.2018.06.04.01.58.40; Mon, 04 Jun 2018 01:58:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Nrr3Fj0w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752089AbeFDI5c (ORCPT + 99 others); Mon, 4 Jun 2018 04:57:32 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:45754 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbeFDI5a (ORCPT ); Mon, 4 Jun 2018 04:57:30 -0400 Received: by mail-lf0-f65.google.com with SMTP id n3-v6so23960785lfe.12 for ; Mon, 04 Jun 2018 01:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jhT8TihDwlH5NSg8rT7FoOnj37aS9muRlhGbmmv3Tjw=; b=Nrr3Fj0wCmxT2qGGbWVNbqbC3wKC3y99ZwUNprdmjTX6ozJdknbHCuQWBraFuW+wsq 4Q8gLIzflkM/SSWDg30ZKRSbpY22P4F+Szhh1oe1jA/e9RpIcHGUcZILOjHkoe0NWtxA b1B2+/0M/tyPR+17A3VDurHIz1wRiGJ+olbiYarj+QpgF6O7ceQNGBWMd3auZUW8yVP5 eGJNuDucNQ1AY+X4NF6Fu+kGEh/IzeaWPqzwARIGKTLTJ26cXUq7tZISKEANIjVbbJoO D7l41H0H90py4t3+bYaNxjYPikOOPHEn6CMuUOx5SfV5g75qlxonuytXMdJE/aAEszVY Verw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jhT8TihDwlH5NSg8rT7FoOnj37aS9muRlhGbmmv3Tjw=; b=n8kcZOlIYRt5lqxC3VtvXE6aEyjx/Icah3oxedbKyYYqx9jBuHthZXltG/bRJryXer NRxGvilJKNr19rLz/6dGTvSG3ZjwdqCkxCl1GgpXUgOTyCcYAj7a9mgQlafTrmGfqQVd Nve+PkiF5coAOegmyMd/UUF7+rAsmxT6CLJFtqs67oqw8azqfizpjWYpPwUguOPALAyE +qfOS2uQ9gj5FIAYFb93wmlxY/6LxhVcouF324Uub7/ic7SzdB2Bwk2gEqbGldXxVE4v kvnTorIuHrktENilr4lmxATIN49C8zO03SXzNS4Ln/WQv55wV1XlMvKlu3HGIvotkslD AjEQ== X-Gm-Message-State: ALKqPwfdBMr+2o7TMZsXX84gRgWeBzTslmWTWpJ54b5P8UHC2mBXOBvI 16wicX6ZdDfv7VpHr5lBGevrZLLCSKtJPMjuRsQ= X-Received: by 2002:a2e:9d07:: with SMTP id t7-v6mr14286275lji.7.1528102649578; Mon, 04 Jun 2018 01:57:29 -0700 (PDT) MIME-Version: 1.0 References: <1527940734-35161-1-git-send-email-ufo19890607@gmail.com> <1527940734-35161-2-git-send-email-ufo19890607@gmail.com> <20180604065238.GE19202@dhcp22.suse.cz> In-Reply-To: From: =?UTF-8?B?56a56Iif6ZSu?= Date: Mon, 4 Jun 2018 16:57:17 +0800 Message-ID: Subject: Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header To: mhocko@kernel.org Cc: akpm@linux-foundation.org, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wind Yu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal > I have earlier suggested that you split this into two parts. One to add > the missing information and the later to convert it to a single printk > output. I'm sorry I do not get your point. What do you mean the missing information? > but it still really begs an example why we really insist on a single > printk and that should be in its own changelog. Actually , I just know that we should avoid the interleaving messages in the dmesg. But I don't know how to reproduce this issue. I think I can just recount this issue in the changelog. Thanks