Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3412950imm; Mon, 4 Jun 2018 03:14:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKn9pRx0zBPcHf0vvH5yzxUs7576ibdbDckg8BrhiC8maD2AH7dbBr87tk6ZH9SjpPceOFh X-Received: by 2002:a17:902:7896:: with SMTP id q22-v6mr21544857pll.243.1528107259484; Mon, 04 Jun 2018 03:14:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528107259; cv=none; d=google.com; s=arc-20160816; b=RIi3RkBb15aWb6YJh9XgqutEayZV3cNMyfeIBvB4BG3mzikOjzYZER+5Nbp5on70tH Gpt5ucAlEK0LiKQvxg4LK1QXyK2IkLFMH9v1BY++dIX30RfvdmdZtl8a57kVqHNa1rYq 1ibGCv7yUJdgzes7rs94bgDWHIPupbXoQjL3VAdhZv0CXxZ/JguwqKq6cOqpu7Q9pFfR S88nhNx6MZDg7dBic1NajUjfePKN+S7qvZRkrrTdvOPGmIl+fnO+vHTGWHBO9Hb+wN61 6zISCoTG4lSQ0SndrXlbfMMdyW+z30MnE5VgNSibOPMq7YEiWUU9H/D9ubH1ja895g96 w0hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:date:cc:to:from:subject :message-id:arc-authentication-results; bh=NZMDRbcY7PNzIQjZnHKti2aevNihMyPkbmxE1sSCEtc=; b=h2ZBH28MZqTsnLDkLfOqSpPXJpugsUvFm9+FSL+6DgPDfZjAxC+p/eNnMvat0ydSIP x5w0LqkPpnsjD7oILarjGzgwAAcAHXy/yVNG7t3m829HDljEjWmdyY+YI/pKFXYdqBvz whydJ4rBZasewBy2yOqmcMYKu8OfTS+uMbNWEjYJdwITSpe3RZuJC2CxwBKCH/3fsnWz CKdX7B/tz9vMsNiE5eOwpWBc/JsmXXkaKg69jXXCWTP49NbnMrHIlZ1WP2Ied5YXsNbO nTU6cja2xgNTY6gjdA1q6GITAXDkcRSQsEy46MqF8PEEKZu2gA9kahhSXD/iS0Tk3EB9 Sfxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o10-v6si6388622pll.158.2018.06.04.03.14.04; Mon, 04 Jun 2018 03:14:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752409AbeFDKMR (ORCPT + 99 others); Mon, 4 Jun 2018 06:12:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:8104 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbeFDKMP (ORCPT ); Mon, 4 Jun 2018 06:12:15 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2018 03:12:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,476,1520924400"; d="scan'208";a="234187004" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga005.fm.intel.com with ESMTP; 04 Jun 2018 03:12:08 -0700 Message-ID: <65c26f5db1275e958cfe6390e9336568b0158dea.camel@linux.intel.com> Subject: Re: [PATCH 0/8] serial: 8250: Add 485 emulation to 8250_dw. From: Andy Shevchenko To: Giulio Benetti , Greg Kroah-Hartman , "Matwey V.Kornilov" Cc: Jiri Slaby , Kees Cook , Matthias Brugger , Allen Pais , Sean Young , Ed Blake , Stefan Potyra , Philipp Zabel , Joshua Scott , Vignesh R , Rolf Evers-Fischer , Aaron Sierra , Rafael Gago , Joel Stanley , Sean Wang , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 04 Jun 2018 13:12:07 +0300 In-Reply-To: <20180601124021.102970-1-giulio.benetti@micronovasrl.com> References: <20180601124021.102970-1-giulio.benetti@micronovasrl.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-06-01 at 14:40 +0200, Giulio Benetti wrote: > Need to handle rs485 with 8250_dw port. > > Use existing em485 emulation layer for 8250 taking care to fix some > bug > and taking care especially of RTS_AFTER_SEND case. > I don't see in Cc list author of rs485 code, who might be interested in this. So, added him here. > Giulio Benetti (8): > serial: 8250_dw: add em485 support > serial: 8250_dw: allow enable rs485 at boot time > serial: 8250: Copy em485 from port to real port. > serial: 8250: Handle case port doesn't have TEMT interrupt using > em485. > serial: 8250_dw: treat rpm suspend with -EBUSY if RS485 ON and > RTS_AFTER_SEND > serial: 8250: Copy mctrl when register port. > serial: 8250: Make em485_rts_after_send() set mctrl according to rts > state. > serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and > RTS_AFTER_SEND set. > > drivers/tty/serial/8250/8250.h | 2 +- > drivers/tty/serial/8250/8250_core.c | 2 ++ > drivers/tty/serial/8250/8250_dw.c | 41 > ++++++++++++++++++++++++++++- > drivers/tty/serial/8250/8250_omap.c | 2 +- > drivers/tty/serial/8250/8250_port.c | 33 ++++++++++++++++------- > drivers/tty/serial/serial_core.c | 12 ++++++++- > include/linux/serial_8250.h | 1 + > 7 files changed, 79 insertions(+), 14 deletions(-) > -- Andy Shevchenko Intel Finland Oy