Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3413366imm; Mon, 4 Jun 2018 03:14:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK1T8TszzlMdUobmL0exK6jwURmUpf759dG3lJR3mePk+qbyc49PTZ58XUFLrzcpzPqxb6g X-Received: by 2002:a17:902:20e8:: with SMTP id v37-v6mr20978857plg.354.1528107291358; Mon, 04 Jun 2018 03:14:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528107291; cv=none; d=google.com; s=arc-20160816; b=GFVGv0L5GzJ8USQLEqScMNf0CDgeXGQ3ncWJWZ/2Rso4eOfPK3bgYGVlxqbgy/3SXT k2ZJ+OVvIMMgi5HYbNimqbOpt9RJiGJr3Epz1YODRu9dE/1C+EvTX0gETvibbW4mAxWp IUjuCBPnmO8ZOylRSD4FjuL3y95KJNmkWAuIZFgFi23k+dccIYfaAOvycI001VdB1ZrL xvX1s1+yxVs9AJiJ1QSUcN/3GHeirxo767kTUJ4NWOiAxno27McO79iAvsAwMry3vIkG UrXkbfWa4DemPZecKyf9u7J6nk6H2vnl+KOjJCuPrDfvEVcm+LpCLonFsctvQ3k19Ml/ EMbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:date:cc:to:from:subject :message-id:arc-authentication-results; bh=LkaiMnS/ODfSTWFUGZqGU580YyxJaeplffJl4+15J7c=; b=K5gsIBaytqQqbkGGfKghITmK8BEbHOHJnnNz3pbepNLGyo2MLWZcjTBT++fekCk0sg AZh4T1Vfa4KduchtcK73yXydejrROHJYc4spw9kS2msMgS8j/ryOwpnffJCfFCGVaYbA D0JUzjPQpba5ws5j+iYDZKq0HjhXaUleVN9ANjctQdWU4OL7KOYStX7g8M8dpQtjdAv+ sD7XxbQaROSEeBBbirzixWgac+ZsvP8Ri80e/YWCeAIHpUPqlBM1tu8zic1uMyQ3H9nG x815wNt/BUdA8O1oQUK42mlCKp+9mIIM4dppie/+6HVXO/Nu2sjpZdv+emt9pi9isDDJ nAeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2-v6si46420393plb.77.2018.06.04.03.14.37; Mon, 04 Jun 2018 03:14:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752313AbeFDKOG (ORCPT + 99 others); Mon, 4 Jun 2018 06:14:06 -0400 Received: from mga14.intel.com ([192.55.52.115]:35001 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752017AbeFDKOF (ORCPT ); Mon, 4 Jun 2018 06:14:05 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2018 03:14:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,476,1520924400"; d="scan'208";a="61070357" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga001.fm.intel.com with ESMTP; 04 Jun 2018 03:14:00 -0700 Message-ID: Subject: Re: [PATCH 3/8] serial: 8250: Copy em485 from port to real port. From: Andy Shevchenko To: Giulio Benetti , Greg Kroah-Hartman Cc: Jiri Slaby , Kees Cook , Matthias Brugger , Allen Pais , Sean Young , Ed Blake , Stefan Potyra , Philipp Zabel , Joshua Scott , Vignesh R , Rolf Evers-Fischer , Aaron Sierra , Rafael Gago , Joel Stanley , Sean Wang , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 04 Jun 2018 13:13:59 +0300 In-Reply-To: <20180601124021.102970-4-giulio.benetti@micronovasrl.com> References: <20180601124021.102970-1-giulio.benetti@micronovasrl.com> <20180601124021.102970-4-giulio.benetti@micronovasrl.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-06-01 at 14:40 +0200, Giulio Benetti wrote: > em485 gets lost during serial8250_register_8250_port(). > > Copy em485 to final uart port. Fixes better to go first. I think you need to reorder the series. > > Signed-off-by: Giulio Benetti > --- > drivers/tty/serial/8250/8250_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 9342fc2ee7df..c8c2b260c681 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -994,6 +994,7 @@ int serial8250_register_8250_port(struct > uart_8250_port *up) > uart->port.rs485_config = up- > >port.rs485_config; > uart->port.rs485 = up->port.rs485; > uart->dma = up->dma; > + uart->em485 = up->em485; > > /* Take tx_loadsz from fifosize if it wasn't set > separately */ > if (uart->port.fifosize && !uart->tx_loadsz) -- Andy Shevchenko Intel Finland Oy