Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3529600imm; Mon, 4 Jun 2018 05:15:01 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJwFqNnVSURQSOh0rQuY6TtNO+V64vH5qpuuVB0FNVyisGiPKc89cK2IG10K5cv2TCZgREJ X-Received: by 2002:a62:3085:: with SMTP id w127-v6mr21146233pfw.224.1528114501887; Mon, 04 Jun 2018 05:15:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528114501; cv=none; d=google.com; s=arc-20160816; b=FdxhGhvuCBIWA22GyRysi+xrom6xrfBl84s48pzm+Bm5bB73f9csq0WnZ6jG72G13i WGpBlSTwzk3xbaxTMNsof0qO95WTSYQErG8TInx6FF5MjcFe6cGjAzjg4vBX6eUh3u+U kSWpan0FglP4mGui4oOZKKqhl8nq6MqmJh+JVw8BJatD1q3nSb4bNqUPUnQBCs6c7Zjv z/QrlLOlgrFuE84z67yKNRBJRgSP1owJMQD3s0RAJIKWlIgI19WjhF9B2d8YvO0J1NKb 3V6d9/MmAzzd3mKza3w4AxF4Qj4IuEovrKxFnQxbTXyInelNtdEh+o1cK8iaTRn7pldP ymcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=qsLbhcrykDSp3k0ZMb6UMs2NY8aDgSbWyy7AIf7jSEE=; b=CTfQmNGOvfNAyOO2f8OuGR1pe4O0SpbhzyEvkfK3D7CdDDUVpMX61zIzfK4iTjG8sz NDfdL2xQHteUbNGLGJfvZJDJ/W1zRsvtj9P7o1hv7ShC6ROE3CLOrXNfstKmk7hnpT1U 7t81BmPkoIvpko05mr9Ln8+nG/BM9Cc1xoVb1Gm2c5LqAIp2w7ER4l6mAjKDFpAarwEo jOYTbh+yVWoo0Eh/ddlPgnet0THvHyiFkyG8miFWc1UKHNOcdU6zCGZzqUXiNAsxTO9D haFev5fxIMo7vKTsJjff5I0ziEipphwjTJ0Vf8AHkYyyRGCufk14MWCq53jBjOMgsx98 KV6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vG/0fb+T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11-v6si45737357plt.325.2018.06.04.05.14.47; Mon, 04 Jun 2018 05:15:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vG/0fb+T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbeFDMN6 (ORCPT + 99 others); Mon, 4 Jun 2018 08:13:58 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:42363 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbeFDMN5 (ORCPT ); Mon, 4 Jun 2018 08:13:57 -0400 Received: by mail-lf0-f54.google.com with SMTP id v135-v6so24842345lfa.9 for ; Mon, 04 Jun 2018 05:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qsLbhcrykDSp3k0ZMb6UMs2NY8aDgSbWyy7AIf7jSEE=; b=vG/0fb+TiCguJGR2QssQL1AjV/kSxOtDy6gYbJBWXUt/0f+QvX8GQam3qPFdiCdaEy R4K02PSSsWmKsNVGhHN5h3/QFhMCoctSvh4oDzw/csPn6/iAoETC5w+dQX3wOf21p6Jp vF7oqp/MsFtpAqGY5t/1/eZcqlamH8XyXOV2ZH91KbUM1R2dw4D8VdkMF2G4RaRu+8Vx P4LUuKXQ2VEqiYgQHSNPcRV3AZIYEGmZN0FN4NX+mL5XhRN0J0UjYPbkPOiB/1xgMriy h1SObhTShEkJQDWercO7DifERhO2vmQuCGeeDsa8Oa+Ymj1n+lGsE40d7++vmehxJgVF 15Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qsLbhcrykDSp3k0ZMb6UMs2NY8aDgSbWyy7AIf7jSEE=; b=kq1aUAKENjYI85FE3fyhYfIj+ihZieGS7yWbzhGkE1t/vMJCj2jFckLKYRmOrDBpIn oiMr0rYr02+pNlA3Vj7RJJEvFbgsjtGp6m4kj4PHUwCE2E9iiRuVJHj15r6QdvM4EXIm g7o90WvefJx8HH+gd8OmeysdLWtBJ7a4QntmQEs4bGOAwkjr+8ShncV742JFPv9uJAvA 2Hd8xX0faNIO8ax4hSaBJwzqdPB1wLG1jAbxK6FG72/ZZOZGNwkphsdLgutrPWTUen4u yxzSYUG8lFtCZwAZX3jJ9o1GjCdNg3hoaW+afMcycGh8GbfYD60ZS3mosT0gqkxKgVJj 0AlQ== X-Gm-Message-State: ALKqPwevUYt2p9gXW23IzZxHnOWlHOil+EtGiKEYRFypoawObcUUF/7/ ZTErbuFLCr/H+NjEPhPv/d3zJ1sOy1gc5TtThPNDzQ== X-Received: by 2002:a2e:60:: with SMTP id 93-v6mr12265031lja.96.1528114435924; Mon, 04 Jun 2018 05:13:55 -0700 (PDT) MIME-Version: 1.0 References: <1527940734-35161-1-git-send-email-ufo19890607@gmail.com> <1527940734-35161-2-git-send-email-ufo19890607@gmail.com> <20180604065238.GE19202@dhcp22.suse.cz> <20180604095212.GH19202@dhcp22.suse.cz> In-Reply-To: <20180604095212.GH19202@dhcp22.suse.cz> From: =?UTF-8?B?56a56Iif6ZSu?= Date: Mon, 4 Jun 2018 20:13:44 +0800 Message-ID: Subject: Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header To: mhocko@kernel.org Cc: akpm@linux-foundation.org, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wind Yu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal I will add the missing information in the cover-letter. > That being said, I am ready to ack a patch which adds the memcg of the > oom victim. I will not ack (nor nack) the patch which turns it into a > single print because I am not sure the benefit is really worth it. Maybe > others will though. OK, I will use the pr_cont_cgroup_name() to print origin and kill memcg's name. I hope David will not have other opinions :) Thanks