Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3745756imm; Mon, 4 Jun 2018 08:36:36 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIomVfWIdevj1nicpgZQzxQwGukNH20YOtvsAVyfLWWwBQfsfYKD4UeI3AL6/RXrbxgo1Uz X-Received: by 2002:a62:3ad8:: with SMTP id v85-v6mr21857580pfj.184.1528126596260; Mon, 04 Jun 2018 08:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528126596; cv=none; d=google.com; s=arc-20160816; b=zTO9rLwsjKSaxykHo2m2qUEqCM+ydxJ+sdACsBQGjtB69VKnCYhandhZP4FH25ocYb 3ji7/692kaWNVp6iuPW1oP1bHoyPEUCW020wkvQdMmGyex53fHbKj1LjiEb0bqCwaXlS k9IK9fVYJnTxo7jqdW7DJQg5+lylIxi4JxiLxJ7/GiPkqlY1uH4qyAT93qdJNDsO+Asd nOX8wdKInOoHrLKZNsmKLOZsvtiZDi289Usb9tv0M4OpPe72BH7qH/V2voldF7VMncER aldoHyf9bMvR8CnqHNZCz2delgd5dUWBCeVMkkh02xExWrBgVHHb/KKqTZbuKRIig7aj IO7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=JPjX+1+wECpR5Eo8YLo8hxA216+1bQSMlFCvTGoGc2o=; b=Fx54FS9qy8LUxpA7zxDMrkCR8+vcik+Z8z+7ptJNIL/NJ3Vkp/rFk1yRdDF6EI3ptP eLOp50v/zE1hco4woxy8UrRwNUlFYcEaPNb+9veii6Nc1Wo1TnhNBo+apEIGzaJAwqDf VBkDG//+lGwB0NtezT4P5eKqh8WFRCsqo3Doogs0fcGdtr6WwDshD0sItuqX8c4nLXsh gmr6Gcl0s3GP1veiA+tPxoD1wFsgcXg5syiOZayOgyWg4Sx3KO9aUKwzEl7oFbSIzurq lzrvfNRAjM740RtI7V5DnkUeWBk1t0jDkhlHzNRBbH6zgu9jE/DiKXKsissbE7M1q+Di KA4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w15-v6si2757604pfn.12.2018.06.04.08.36.21; Mon, 04 Jun 2018 08:36:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751052AbeFDPf4 (ORCPT + 99 others); Mon, 4 Jun 2018 11:35:56 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:48516 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbeFDPfy (ORCPT ); Mon, 4 Jun 2018 11:35:54 -0400 Received: from localhost (unknown [144.121.20.163]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BC95111658C35; Mon, 4 Jun 2018 08:35:53 -0700 (PDT) Date: Mon, 04 Jun 2018 11:35:52 -0400 (EDT) Message-Id: <20180604.113552.1136710379930167373.davem@davemloft.net> To: salil.mehta@huawei.com Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com, mehta.salil@opnsrc.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, wangxi11@huawei.com Subject: Re: [PATCH net] net: hns: Fix the process of adding broadcast addresses to tcam From: David Miller In-Reply-To: <20180601170011.22700-1-salil.mehta@huawei.com> References: <20180601170011.22700-1-salil.mehta@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Jun 2018 08:35:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Salil Mehta Date: Fri, 1 Jun 2018 18:00:11 +0100 > + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num, > + mc_mask, mac_entry->addr); Please indent things properly when arguments span multiple lines. The second line here should be precisely after the opennning parenthesis of the previous line. > + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num, > + mc_mask, mac_entry->addr); Likewise.