Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3751098imm; Mon, 4 Jun 2018 08:41:28 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK4ROk2DFZ8Rh5TsIlLzhespK4/aGPIQspuxme/861CXGTVFLle8kwb85y5J0QTl5UGaMx3 X-Received: by 2002:a17:902:8a87:: with SMTP id p7-v6mr21987353plo.278.1528126887960; Mon, 04 Jun 2018 08:41:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528126887; cv=none; d=google.com; s=arc-20160816; b=i2nuUFetnhYkqH/yuV9vITiw/KSnt+hGux5WgKKay21cnNEi/5Ijv30SzQFlnaaxfn 3CXNN1buprVQEMhUCfvsmL3q1Hv5k6XQCiFmNR1300O3tcWvoGVK3WU8aOpwBPu9jSNG 1pKbJJ0PERxyqldqxnTfuoMwYm6idYIFcLWvXGiV5Ujo2C6aNcjUOhI5IFlCNjA7lhb6 lkzMSdSPV/JiPZVmEIWosriiAUCfItKHsh+CTlLRaVm5hSiY/ezG/THYeGaub7YjA6GP vybyMjpMnxHCa6HJj5BhCKdut4diQsQbUy5qOw2lD90LyEWB8ryHNjmgO26SYcJN1QZS +FBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=VhoRIq36j+MQa+zY+r34tqgXu9VCgotqZmyr8Az93+g=; b=qRxIFowBa0TylhxXO7yjGY12V0WOnRkQoNXeyGONX6e1urVYnjvv0NYQaOyRUJn5iQ CzdYm75MEMwnFiLdWuqU3UqK15FqR9QROCtNjC//Vd+3GjwZO33LQ97KsbrkRSrF6TDd I3G841GV8Y0lm7MYJtwDAIQl/n5iUvCWHHtvIUMUJcs0xhLy9NIACowthlLakzRy7eRA jqiAjaIbwDudldjnLw+NN/zOb/dbeRz0EZNiG4M5FHXOALhkcHZWKA8qlFE5KQGk7JT2 TcSGR0DPua+eOFUPRvpsQb9OwGWKsPs2JTqpC/Uf3J8BTaBpD8uI2F8KQW1kHsHZtn0Z OiVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VJlrTZI6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p8-v6si837752pfh.249.2018.06.04.08.41.13; Mon, 04 Jun 2018 08:41:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VJlrTZI6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751338AbeFDPkS (ORCPT + 99 others); Mon, 4 Jun 2018 11:40:18 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:41161 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbeFDPkP (ORCPT ); Mon, 4 Jun 2018 11:40:15 -0400 Received: by mail-ot0-f195.google.com with SMTP id t1-v6so38200506oth.8 for ; Mon, 04 Jun 2018 08:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VhoRIq36j+MQa+zY+r34tqgXu9VCgotqZmyr8Az93+g=; b=VJlrTZI6/Jjl+0P+qr5z3HZ6sIIU9SRf+lclRF1AfLC3e6ajrJaVC3QlhsVKq1cUEX GTRN+5ycco803g/WQAkKuyxo5mleTBEhogeKi81uub1UUXHayy5b56baFs4JzHahsFD9 i0uoWXAjqUfwst2NENFHRfj1B7WcI5ZRtdK6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VhoRIq36j+MQa+zY+r34tqgXu9VCgotqZmyr8Az93+g=; b=C9gYyiWrSyn1+ExLhHrX/bjoWQyvqT2iwKYvi/lza392WXrvbk9BDyaplOd9UIhMdM I/LlcG6WwOo84gpW2abHWyZXN+ybGOFfCYwIZg4E1djDxad8100xmpnGxI//nvrrcjgx L+AmR7eHSjlzENeguCre/Cj2uuuHSsjQXdnYKMh0gf3Iqcq9rcQDXpsnE1WwZkijwj4e 2aTDfPNJXeVOYkE6wd2Y3RAorHb6DWVGGbLiugnFbuxq65w2OsRDs07bZYbMfp6EnKur Ehh8+N1SW39blOimSCI4OTiyCFH5RPXrhv40TR/J9nUoCR4sQJjw6yV/ME2yHMq9BjEN f/+Q== X-Gm-Message-State: ALKqPweSqYNWK643qSX/mLyRRwCZ/WcHez0ak2ZcBEjYGCOa6rmc3py0 xTrcUm+wmVILMtDpMSEvJ9AkFx05epE= X-Received: by 2002:a9d:36ed:: with SMTP id s42-v6mr14312829otd.131.1528126814735; Mon, 04 Jun 2018 08:40:14 -0700 (PDT) Received: from mail-ot0-f173.google.com (mail-ot0-f173.google.com. [74.125.82.173]) by smtp.gmail.com with ESMTPSA id t4-v6sm3542612otd.40.2018.06.04.08.40.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 08:40:13 -0700 (PDT) Received: by mail-ot0-f173.google.com with SMTP id q17-v6so27628400otg.2 for ; Mon, 04 Jun 2018 08:40:12 -0700 (PDT) X-Received: by 2002:a9d:17c2:: with SMTP id j60-v6mr2207182otj.329.1528126812236; Mon, 04 Jun 2018 08:40:12 -0700 (PDT) MIME-Version: 1.0 References: <20180529181740.195362-1-evgreen@chromium.org> <20180529181740.195362-4-evgreen@chromium.org> In-Reply-To: From: Evan Green Date: Mon, 4 Jun 2018 08:39:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/7] scsi: ufs: Make sysfs attributes writable To: Bart.VanAssche@wdc.com Cc: jejb@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, Vinayak Holikatti , Stanislav.Nijnikov@wdc.com, Gwendal Grignou Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 4, 2018 at 1:33 AM Bart Van Assche wrote: > > On Tue, 2018-05-29 at 11:17 -0700, Evan Green wrote: > > +static ssize_t _name##_store(struct device *dev, \ > > + struct device_attribute *attr, const char *buf, \ > > + size_t count) \ > > +{ \ > > + struct ufs_hba *hba = dev_get_drvdata(dev); \ > > + unsigned long value; \ > > + if (kstrtoul(buf, 0, &value)) \ > > + return -EINVAL; \ > > + if (ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_WRITE_ATTR, \ > > + QUERY_ATTR_IDN##_uname, 0, 0, (u32 *)&value)) \ > > + return -EINVAL; \ > > + return count; \ > > +} \ > > Casting an "unsigned long" pointer into an u32 pointer looks evil to me. > Please don't do this. > Will fix.