Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3757065imm; Mon, 4 Jun 2018 08:46:59 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJxgwuA3YqzeRs7DTyNxj7aUiopimeuLW2S/kIEUkVkpgAyYEXzxhmxQINTxl8mgmZ8uR6u X-Received: by 2002:a65:63cb:: with SMTP id n11-v6mr17572098pgv.185.1528127219248; Mon, 04 Jun 2018 08:46:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528127219; cv=none; d=google.com; s=arc-20160816; b=ivY6mpV36vKoxlJs9lNVPRHyDaZbGT+kK15D+aw06fgOVRXnTUgzir85liB8de9CDv Rr2YPRULgnWit9jrn/tJapImgxiN4mdJ5YLd9AXq8FeNpDLhRr1MZ4dg7sGsxwgHNaAs BD/7YwwRXMx8E84r9llXXa0qITnMoTKxegEYxy8eC4wDA9DSYcz4aJoIn/Wes6X8C6cC FI7vSGyF6865c+dW2zMqoX+fYUJzOjzSakLScwjB/78Vk2tjeITw5FDtZhYC+mnjOv1M J+5B//l+k+1fXUMJsz4hOcdf2+xQCiTmrcH+KAgIWG3qwvGRZMZxKFOZtV4MLFc+WzfA PxcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=n/25/774Mxys5L5wdxm+9d73lQesZUhfXbR9CXRSjEw=; b=Dey5uD9L7/xp1Sf9LYKl9E1ssaQjkUuAbORDFUwJUMco0Gd7+TjgSNJrlfyursuzmN +ww0qtFlUdv+5rKjZbPaxr7RBisodsv5AqpX9mbQPGgnHYpWPodlgADh36A5vw+nRngv gixKml7aKLjmXChHsuh0wCpBK2452RUW0FEpEA86AGsNKXnP0p29M3WHv0u6f8FS8RGx yGovm9ZYpFUw0eO7bL0s7wfmxFWQUS2/ReqG9czaxLpNb5nT/uIXNVAzKInmMl6izB8q wuSYPPDkvXHb6nYmk50CN16/b4/Z9fBjH8EUPNhfxwVkO5KJvccUqxFzKX2H1qb8EY+p wxYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RuBrjigL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y15-v6si873801pgv.452.2018.06.04.08.46.44; Mon, 04 Jun 2018 08:46:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RuBrjigL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbeFDPqK (ORCPT + 99 others); Mon, 4 Jun 2018 11:46:10 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:36837 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbeFDPqI (ORCPT ); Mon, 4 Jun 2018 11:46:08 -0400 Received: by mail-wr0-f179.google.com with SMTP id f16-v6so29366727wrm.3; Mon, 04 Jun 2018 08:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=n/25/774Mxys5L5wdxm+9d73lQesZUhfXbR9CXRSjEw=; b=RuBrjigLhQWbLNmIhtyh4XieyDTImALkYhqCtmSL/w/22pozD/AQ+5Truohojw9tdN RABn0sthsmCvB4NIgNZQhRVdOpd60WQdxVNuRff7j1htXO03zdBtSyA27FpRE4ajTnXJ pB9J/yZXOh2yrRAaiuFk9ZkXmAz+ada/mglbXqjt2gbSYCJJefHKPoQOuw5U5/Sj3mRb NfrIHCaiHtS3th1TppNunwKQHGM8nNlEfnfefxgBpsq9x3gxgg/DZWpZtOSQhBPFlyHG Y3zotaZwU//ErMgDuNud/iyb5IsHe/zYUjPE6pA6WnsiCqG0RdcL/JemEeBjLxM7oY1W u/Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=n/25/774Mxys5L5wdxm+9d73lQesZUhfXbR9CXRSjEw=; b=faPXhMbWa3ftucwFyAod2hD/95g2lnEYtV12haQoRnCpkrkCgEK+QF4p2Io8RU2YL1 TwLjx6VgSShmEHeGeWob6Inmyqt/3Y/QRMmpLrZHxk8n7qRSTIsv3wjJMigOEUsiL+IR J8RkYklLnwwmWvaJ/NN+8KkUEbxri3Olv2UaMLFEQgy7izKBaIcFFYX8/6pq6ZPOs66g ZpPmnzu4mO1NaHFJe8lPfFUFrh5oyOMmSCVNYh08QA3W6zqkGZK/IepOcT9sCCaB3wgA sMsuT0Jc/Iul/rQazn7Bvu2cMXVjfOuR/44OOHQR8KgFn/QPOypX5f43W0vzYYUfVT8w qUfg== X-Gm-Message-State: ALKqPwdWaM+UboNXNC3BLh/MqxQ7iZuAoqCXENn0j9E79mX0CoPcjTVa d5t7rK2zM2XJJN3Q4EvhxDEDRybBk/jPtWOk86PLjA== X-Received: by 2002:adf:9162:: with SMTP id j89-v6mr16584567wrj.196.1528127166924; Mon, 04 Jun 2018 08:46:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:c08b:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 08:46:06 -0700 (PDT) In-Reply-To: References: <20180604123238.82200-1-chiu@endlessm.com> From: Azael Avalos Date: Mon, 4 Jun 2018 09:46:06 -0600 Message-ID: Subject: Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change To: Hans de Goede Cc: Daniel Drake , Chris Chiu , Corentin Chary , Darren Hart , Andy Shevchenko , Linux Kernel , Platform Driver , acpi4asus-user , Linux Upstreaming Team , Bastien Nocera , Benjamin Berg Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi there Let me add my two cents on the Toshiba side. 2018-06-04 8:23 GMT-06:00 Hans de Goede : > > 1) drivers/platform/x86/toshiba_acpi.c > > I don't know how the key on Toshiba's behaves on models where > it is hardwired / under Windows With Toshiba we have two types of hardware implementations: 1st gen keyboards, supporting AUTO and FN-Z AUTO - Turns on/off automatically after some (configurable) time FN-Z - Creates "toshiba::kbd_backlight" and it's toggled by userspace 2nd gen keyborads, supporting AUTO, ON and OFF AUTO - Ditto ON - Always on OFF - Always off The second gen keyboards are completely driven by hardware, userspace must be checking sysfs for "kbd_backlight_mode" changes, however, the Toshiba interface emits the 0x92 ACPI event when we have a kbd mode change, but it's not currently being transmitted to userspace via netlink. Saludos Azael -- -- El mundo apesta y vosotros apestais tambien --