Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3797700imm; Mon, 4 Jun 2018 09:23:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ3aPdMEMmuV+7buQqRr5fdkahdmOTzYkza04guSIRTChBNNEXd62YJYjYIwv4etDPCcqug X-Received: by 2002:a63:7d47:: with SMTP id m7-v6mr17836743pgn.443.1528129393143; Mon, 04 Jun 2018 09:23:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528129393; cv=none; d=google.com; s=arc-20160816; b=hMZndY24HF4V7cUODOBRnUW+sYL3APv4zxJ2vHupIZsmmcUfyA6vEqEffpyAVzB/98 WqtSylNuNOeTTTpGYBrCWp3R+QkmGKDacEEb/1nMk1DrO5bIcOUmXPNsLcfnmtRe3kUr eEKIUcw5PfMMhaHmU/JRsutgAfYAjg1DEsouuaOXESmOn1gNSsUIHdoIck1oIjgYgQ2d pa2730IM49uf+DIkh9ON+6GK46CeLRxYXCJ5qKwAI1w+OGElpV88jgAx5EIjvmUgzNL8 uwG8e1T5z7Udc1mlm/Eb9JJsxpXK9Vmmp6JwDj0lkNRcojycYDG9Bhjqs/vQZvQoZVMR c32Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=8NG4fr4aY+opcufPV1YMaCdm0VXs8T/gVNqDIR+LcwY=; b=C7y8d6Q6aM5zP/TiEatsjy9KC2r/6IlF6JWfccvjElBV0EDOFF/pMG218LrixwwE+B eJAqn4QbBgf/ol7wvi7iaXcoTv/hWLiCS52tNfXzIdrNik1sEGNzWLGa/6/zvDIX6fmo 2/m2Aaxg/STXKXiKRX5chZ/jBPGmIF4t79WDfp+Kx9VBG6Is/tHIxm5ev42DT7yQlRzY AMFWQCUmnqfOT8EkdXWFEDfVdlN/Xapv/C7MWQZH78Vj+Qv1M6YMbmcCXWrYuQweLdjs QlHLl51U5My0ZBsSY/nKvOoXhvPolcfWnqoSHIhwqQLQEsqR7ktZPW6rUz7wRB5v9Ap9 uRjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=hHpVzQBh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a68-v6si33586610pgc.210.2018.06.04.09.22.58; Mon, 04 Jun 2018 09:23:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=hHpVzQBh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbeFDQVT (ORCPT + 99 others); Mon, 4 Jun 2018 12:21:19 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:33796 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbeFDQVS (ORCPT ); Mon, 4 Jun 2018 12:21:18 -0400 Received: by mail-it0-f67.google.com with SMTP id y127-v6so10822082itd.1 for ; Mon, 04 Jun 2018 09:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8NG4fr4aY+opcufPV1YMaCdm0VXs8T/gVNqDIR+LcwY=; b=hHpVzQBhsrEYI8PoEybDic90doDEXY9ALpxdho5uw2i1cIjRGLayMycI0RnSD+YKJu 1qwBC2wro8d6P4NBprsPUtnEbReXCwKZXfBEC9Me8QWpmVZko2jO6eatSiwxFQx3T1dI osDqkX7ZzX2gxprykXEwL7Q8+xNFKJpOyAxoED+ZqPvyI1vAqZzvfVc2scP57v6bPkWn MgZq/tFuarrccl+a3E5gm1SFLn3sHMxL/YVQox9JTgNCVOHrWVcSLWcGk7mFvVJYJUM0 rIoAETrxbR7bAl21GvCCeXR97a5Flwt9FsmQV9X2QBF34OIsxdICtlKJG/wNsBM04oui mpPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8NG4fr4aY+opcufPV1YMaCdm0VXs8T/gVNqDIR+LcwY=; b=WZz2ccGE7bfauIWNpA9EhrTW7UfA90bSXcouCY2PQSjx0FVxarp1Q9d726EgYx3hpU b6rtJmGqXvUDx2WzOQ0AvrwBLC8LaHXgk4B1k3nBwZYI0a6lkTJZYvrTo72y2/ETfyGc ourXQ2fk3W2Lc+jUoSRbzK3ZsBq/5EFnOokvFyMBSXv+kctxwmtB0Sf55wNovUlxnHFM XgVAjoppCl8RQYWujkgSEWkyudH4Sg528g7kiix6i+iJLwbartKhrQGfqU3WA7Bpic39 gpw81fsOHbxX00+k/q7YmyAFFNgs3et/6Qbz1NArSkwz9mhh0E+9BvJhP4rE1cNuUuzX irFQ== X-Gm-Message-State: APt69E3RlRhHOEKaf8gMKnahbuhwH8SrNMyimhHlK9GpCuIP3TBjQ2lq UVPjIRMdDql98VOlqMo5aV1d2vudreo= X-Received: by 2002:a24:250e:: with SMTP id g14-v6mr14415306itg.24.1528129277083; Mon, 04 Jun 2018 09:21:17 -0700 (PDT) Received: from [192.168.1.167] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id x6-v6sm282967itb.32.2018.06.04.09.21.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 09:21:15 -0700 (PDT) Subject: Re: [PATCH] blk-mq: return when BLK_MQ_S_STOPPED in blk_mq_run_work_fn To: Jianchao Wang , ming.lei@redhat.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <1528103035-8009-1-git-send-email-jianchao.w.wang@oracle.com> From: Jens Axboe Message-ID: Date: Mon, 4 Jun 2018 10:21:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <1528103035-8009-1-git-send-email-jianchao.w.wang@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/18 3:03 AM, Jianchao Wang wrote: > if hctx is stopped, don't run the queue in blk_mq_run_work_fn. I was puzzled, so had to look up those changes. That's definitely a regression caused by 15fe8a9, as you highlighted. Looks good to me, I'll apply it. BTW, this should have been explained in the commit message. I'll change it a bit. -- Jens Axboe